Re: [Qemu-devel] [PATCH v6 4/8] tpm-backend: Made few interface methods optional

[Amarnath Valluri <amarnath.valluri@intel.com>]

On Tue, 2017-07-18 at 10:15 +0000, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Jul 18, 2017 at 10:48 AM Amarnath Valluri
> <amarnath.valluri@intel.com> wrote:
> 
>         This allows backend implementations left optional interface
>         methods.
>         For mandatory methods assertion checks added.
>         
>         Took the opportunity to remove unused methods:
>           tpm_backend_get_type()
>           tpm_backend_get_desc()
>         
>         Signed-off-by: Amarnath Valluri <amarnath.valluri@intel.com>
>         Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>         Reviewed-by: Stefan Berger<stefanb@linux.vnet.ibm.com>
>         ---
>          backends/tpm.c               | 36
>         +++++++++++++++++-------------------
>          hw/tpm/tpm_passthrough.c     | 23 +----------------------
>          include/sysemu/tpm_backend.h | 19 +------------------
>          tpm.c                        |  2 +-
>          4 files changed, 20 insertions(+), 60 deletions(-)
> 
>    LINK    x86_64-softmmu/qemu-system-x86_64
> ../tpm.o: In function `qmp_query_tpm_inst':
> /home/elmarco/src/qq/tpm.c:261: undefined reference to
> `tpm_backend_get_type'
> collect2: error: ld returned 1 exit status
Thanks Marc, for pointing it out, i will this patch.

- Amarnath