Re: [PATCH] ACPI / PMIC: xpower: Do pinswitch magic when reading GPADC

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Fri, 2017-07-21 at 23:12 +0200, Rafael J. Wysocki wrote:
> On Saturday, July 08, 2017 04:58:03 PM Andy Shevchenko wrote:
> > On Sat, 2017-07-08 at 15:40 +0200, Hans de Goede wrote:
> > > Testing has shown that the TS-pin's bias-current needs to be
> > > disabled
> > > when reading the GPIO0 pin in GPADC mode.
> > > 
> > > It seems that there is only 1 bias current source and to be able
> > > to
> > > use it
> > > for the GPIO0 pin in GPADC mode it must be temporarily turned off
> > > for
> > > the
> > > TS pin, but the datasheet does not mention this.
> > > 
> > > This commit adds the necessary writes to turn the TS pin BIAS
> > > current
> > > off before and back on after reading the GPADC. This fixes the
> > > GPADC
> > > always returning a reading of 0.
> > > 
> > > 
> > > +	/* After switching to the GPADC pin give things some time
> > > to
> > > settle */
> > > +	usleep_range(6000, 10000);
> > 
> > msleep(6); ?
> > 
> Is this the only issue you have with the $subject patch?

As Hans explained to me there is no issue.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy