From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga09.intel.com ([134.134.136.24]:5011 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751830AbdGXLDv (ORCPT ); Mon, 24 Jul 2017 07:03:51 -0400 From: "Coelho, Luciano" To: linuxwifi , "kvalo@codeaurora.org" , "jprvita@gmail.com" , "Berg, Johannes" , "Grumbach, Emmanuel" CC: "linux-wireless@vger.kernel.org" , "linux@endlessm.com" , "netdev@vger.kernel.org" , "jprvita@endlessm.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] iwlwifi: Demote messages about fw flags size to info Date: Mon, 24 Jul 2017 11:01:27 +0000 Message-ID: <1500894086.20057.12.camel@intel.com> (sfid-20170724_130418_250267_501DFF64) References: <20170721145147.7572-1-jprvita@endlessm.com> In-Reply-To: <20170721145147.7572-1-jprvita@endlessm.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: T24gRnJpLCAyMDE3LTA3LTIxIGF0IDA3OjUxIC0wNzAwLCBKb8OjbyBQYXVsbyBSZWNoaSBWaXRh IHdyb3RlOg0KPiBUaGVzZSBtZXNzYWdlcyBhcmUgbm90IHJlcG9ydGluZyBhIHJlYWwgZXJyb3Is IGp1c3QgdGhlIGZhY3QgdGhhdCB0aGUNCj4gZmlybXdhcmUga25vd3MgYWJvdXQgbW9yZSBmbGFn cyB0aGVuIHRoZSBkcml2ZXIuDQo+IA0KPiBDdXJyZW50bHkgdGhlc2UgbWVzc2FnZXMgYXJlIHBy ZXNlbnRlZCB0byB0aGUgdXNlciBkdXJpbmcgYm9vdCBpZiB0aGVyZQ0KPiBpcyBubyBib290c3Bs YXNoIGNvdmVyaW5nIHRoZSBjb25zb2xlLCBzb21ldGltZXMgZXZlbiBpZiB0aGUgYm9vdCBzcGxh c2gNCj4gaXMgZW5hYmxlZCBidXQgaGFzIG5vdCBzdGFydGVkIHlldCBieSB0aGUgdGltZSB0aGlz IG1lc3NhZ2UgaXMgc2hvd24uDQo+IA0KPiBEZW1vdGluZyBpdCB0byB0aGUgaW5mbyBsZXZlbCBo ZWxwcyBoYXZpbmcgYSBjbGVhbiBib290IHByb2Nlc3MuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBK b8OjbyBQYXVsbyBSZWNoaSBWaXRhIDxqcHJ2aXRhQGVuZGxlc3NtLmNvbT4NCj4gLS0tDQoNClRo ZSBpZGVhIHdpdGggdGhpcyBlcnJvciBpcyB0aGF0IGlmIHRoZSBmaXJtd2FyZSBpcyB0b28gbmV3 IGFuZCBpbmNsdWRlcw0KYSBUTFYgdGhhdCB3ZSBhcmUgbm90IGF3YXJlIG9mLCB0aGVyZSBjYW4g YmUgdW5leHBlY3RlZCBpc3N1ZXMuICBGb3INCmluc3RhbmNlLCBzb21ldGltZXMgdGhlIEZXIEFQ SSBjaGFuZ2VzIHNvbWUgb2YgaXRzIHN0cnVjdHVyZXMgYW5kIHdlIHVzZQ0KVExWcyB0byBrbm93 IHdoaWNoIG9uZSB0byB1c2UuICBJZiBhIG5ldyBzdHJ1Y3QgaXMgaW4gdXNlIGJ5IHRoZQ0KZmly bXdhcmUgYnV0IG5vdCBieSB0aGUgZHJpdmVyLCBwcm9ibGVtcyB3aWxsIG9jY3VyLg0KDQpSZWNl bnRseSB3ZSBhY2NpZGVudGFsbHkgb21pdHRlZCBvbmUgVExWIGZyb20gdGhlIGRyaXZlciBhbmQg cmVsZWFzZWQgYQ0KbmV3IGZpcm13YXJlIHRoYXQgaGFkIGl0IHNldC4uLiBUaGF0J3MgdGhlIGVy cm9yIHlvdSBhcmUgY3VycmVudGx5DQpzZWVpbmcuICBXZSBoYXZlIGEgYnVnemlsbGEgZW50cnlb MV0gYW5kIGl0IGlzIGZpeGVkIGluIG91ciBpbnRlcm5hbA0KdHJlZS4gIFRoZSBmaXggd2lsbCBi ZSBzZW50IHVwc3RyZWFtIGluIHRoZSBuZXh0IC1maXhlcyByb3VuZCB3ZSBzZW5kDQpvdXQuDQoN ClRoaXMgc3BlY2lmaWMgY2FzZSBpcyBoYXJtbGVzcywgYnV0IEknZCByYXRoZXIga2VlcCB0aGlz IG1lc3NhZ2UgYXMgYW4NCmVycm9yLCBiZWNhdXNlIGluIG90aGVyIHNpdHVhdGlvbnMgaXQgY291 bGQgbGVhZCB0byB1bmV4cGVjdGVkDQpiZWhhdmlvaXIsIHNvIEkgcHJlZmVyIHRvIGtlZXAgaXQg dmVyeSB2aXNpYmxlLg0KDQoNClsxXSBodHRwczovL2J1Z3ppbGxhLmtlcm5lbC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5NjE5NQ0KDQotLQ0KQ2hlZXJzLA0KTHVjYS4= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753493AbdGXLEC (ORCPT ); Mon, 24 Jul 2017 07:04:02 -0400 Received: from mga09.intel.com ([134.134.136.24]:5011 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751830AbdGXLDv (ORCPT ); Mon, 24 Jul 2017 07:03:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,406,1496127600"; d="scan'208";a="882071551" From: "Coelho, Luciano" To: linuxwifi , "kvalo@codeaurora.org" , "jprvita@gmail.com" , "Berg, Johannes" , "Grumbach, Emmanuel" CC: "linux-wireless@vger.kernel.org" , "linux@endlessm.com" , "netdev@vger.kernel.org" , "jprvita@endlessm.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] iwlwifi: Demote messages about fw flags size to info Thread-Topic: [PATCH] iwlwifi: Demote messages about fw flags size to info Thread-Index: AQHTAjDlJpwNyvGVPEusQK59CDsovqJiwz0A Date: Mon, 24 Jul 2017 11:01:27 +0000 Message-ID: <1500894086.20057.12.camel@intel.com> References: <20170721145147.7572-1-jprvita@endlessm.com> In-Reply-To: <20170721145147.7572-1-jprvita@endlessm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.28.88] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6OB452C032241 On Fri, 2017-07-21 at 07:51 -0700, João Paulo Rechi Vita wrote: > These messages are not reporting a real error, just the fact that the > firmware knows about more flags then the driver. > > Currently these messages are presented to the user during boot if there > is no bootsplash covering the console, sometimes even if the boot splash > is enabled but has not started yet by the time this message is shown. > > Demoting it to the info level helps having a clean boot process. > > Signed-off-by: João Paulo Rechi Vita > --- The idea with this error is that if the firmware is too new and includes a TLV that we are not aware of, there can be unexpected issues. For instance, sometimes the FW API changes some of its structures and we use TLVs to know which one to use. If a new struct is in use by the firmware but not by the driver, problems will occur. Recently we accidentally omitted one TLV from the driver and released a new firmware that had it set... That's the error you are currently seeing. We have a bugzilla entry[1] and it is fixed in our internal tree. The fix will be sent upstream in the next -fixes round we send out. This specific case is harmless, but I'd rather keep this message as an error, because in other situations it could lead to unexpected behavioir, so I prefer to keep it very visible. [1] https://bugzilla.kernel.org/show_bug.cgi?id=196195 -- Cheers, Luca.