From: Gerd Hoffmann <kraxel@redhat.com>
To: Marcel Apfelbaum <marcel@redhat.com>,
Alexander Bezzubikov <zuban32s@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
ehabkost@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
rth@twiddle.net, seabios@seabios.org
Subject: Re: [Qemu-devel] [RFC PATCH v2 5/6] hw/pci: add bus_reserve property to pcie-root-port
Date: Wed, 26 Jul 2017 07:29:04 +0200 [thread overview]
Message-ID: <1501046944.29903.1.camel@redhat.com> (raw)
In-Reply-To: <4e3f9aad-3528-59b4-1fab-d109cf49632a@redhat.com>
Hi,
> > Gerd's suggestion was to set min(cap_value, children_found). From
> > such
> > point of view 0 can be a valid value.
> >
>
> I am lost now :)
> How can we use the capability to reserve "more" buses since
> children-found will be always the smaller value?
>
> I think you should use max(cap_value, children_found) to
> ensure you always reserve enough buses for existing children.
Was about to point out the same ;)
Yes, should be max(reserve-buses, child-buses-found). And reserve-
buses is actually a minimum, because the result can't be smaller than
reserve-buses.
cheers,
Gerd
next prev parent reply other threads:[~2017-07-26 5:29 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-22 22:15 [Qemu-devel] [RFC PATCH v2 0/6] Generic PCIE-PCI Bridge Aleksandr Bezzubikov
2017-07-22 22:15 ` [Qemu-devel] [RFC PATCH v2 1/6] hw/pci: introduce pcie-pci-bridge device Aleksandr Bezzubikov
2017-07-22 22:15 ` [Qemu-devel] [RFC PATCH v2 2/6] hw/i386: allow SHPC for Q35 machine Aleksandr Bezzubikov
2017-07-23 15:59 ` Marcel Apfelbaum
2017-07-23 16:49 ` Alexander Bezzubikov
2017-07-22 22:15 ` [Qemu-devel] [RFC PATCH v2 3/6] hw/pci: enable SHPC for PCIE-PCI bridge Aleksandr Bezzubikov
2017-07-22 22:15 ` [Qemu-devel] [RFC PATCH v2 4/6] hw/pci: introduce bridge-only vendor-specific capability to provide some hints to firmware Aleksandr Bezzubikov
2017-07-23 15:57 ` Marcel Apfelbaum
2017-07-23 16:19 ` Alexander Bezzubikov
2017-07-23 16:24 ` Marcel Apfelbaum
2017-07-26 19:43 ` Michael S. Tsirkin
2017-07-26 21:54 ` Alexander Bezzubikov
2017-07-26 23:11 ` [Qemu-devel] [SeaBIOS] " Laszlo Ersek
2017-07-26 23:28 ` [Qemu-devel] " Michael S. Tsirkin
2017-07-27 9:39 ` Marcel Apfelbaum
2017-07-27 13:58 ` [Qemu-devel] [SeaBIOS] " Laszlo Ersek
2017-07-28 23:15 ` Michael S. Tsirkin
2017-07-31 18:16 ` Laszlo Ersek
2017-07-31 18:55 ` Michael S. Tsirkin
2017-07-31 19:04 ` Laszlo Ersek
2017-07-28 23:12 ` [Qemu-devel] " Michael S. Tsirkin
2017-07-31 10:06 ` Marcel Apfelbaum
2017-07-31 18:36 ` Michael S. Tsirkin
2017-07-22 22:15 ` [Qemu-devel] [RFC PATCH v2 5/6] hw/pci: add bus_reserve property to pcie-root-port Aleksandr Bezzubikov
2017-07-23 12:22 ` Michael S. Tsirkin
2017-07-23 14:13 ` Marcel Apfelbaum
2017-07-24 20:46 ` Michael S. Tsirkin
2017-07-24 21:41 ` Alexander Bezzubikov
2017-07-24 21:58 ` Michael S. Tsirkin
2017-07-25 11:49 ` Marcel Apfelbaum
2017-07-28 23:24 ` Michael S. Tsirkin
2017-07-25 13:43 ` Michael S. Tsirkin
2017-07-25 13:50 ` Alexander Bezzubikov
2017-07-25 13:53 ` Michael S. Tsirkin
2017-07-25 14:09 ` Alexander Bezzubikov
2017-07-25 16:10 ` Marcel Apfelbaum
2017-07-25 17:11 ` Alexander Bezzubikov
2017-07-26 4:24 ` Marcel Apfelbaum
2017-07-26 5:29 ` Gerd Hoffmann [this message]
2017-07-28 23:26 ` Michael S. Tsirkin
2017-07-22 22:15 ` [Qemu-devel] [RFC PATCH v2 6/6] hw/pci: add hint capabilty for additional bus reservation " Aleksandr Bezzubikov
2017-07-24 20:43 ` Michael S. Tsirkin
2017-07-24 21:43 ` Alexander Bezzubikov
2017-07-25 11:52 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501046944.29903.1.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=seabios@seabios.org \
--cc=zuban32s@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.