From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/i915: Only skip updating execobject.offset after error
Date: Wed, 26 Jul 2017 12:08:46 +0300 [thread overview]
Message-ID: <1501060126.3720.1.camel@linux.intel.com> (raw)
In-Reply-To: <20170721145037.25105-4-chris@chris-wilson.co.uk>
On pe, 2017-07-21 at 15:50 +0100, Chris Wilson wrote:
> I was being overly paranoid in not updating the execobject.offset after
> performing the fallback copy where we set reloc.presumed_offset to -1.
> The thinking was to ensure that a subsequent NORELOC execbuf would be
> forced to process the invalid relocations. However this is overkill so
> long as we *only* update the execobject.offset following a successful
> update of the relocation value witin the batch. If we have to repeat the
> execbuf due to a later interruption, then we may skip the relocations on
> the second pass (honouring NORELOC) since the execobject.offset match
> the actual offsets (even though reloc.presumed_offset is garbage).
>
> Subsequent calls to execbuf with NORELOC should themselves ensure that
> the reloc.presumed_offset have been corrected in case of future
> migration.
>
> Reporting back the actual execobject.offset, even when
> reloc.presumed_offset is garbage, ensures that reuse of those objects
> use the latest information to avoid relocations.
>
> Fixes: 2889caa92321 ("drm/i915: Eliminate lots of iterations over the execobjects array")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101635
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-07-26 9:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 14:50 A bunch of execbuf regression fixes Chris Wilson
2017-07-21 14:50 ` [PATCH 1/4] drm/i915: Remove assertion from raw __i915_vma_unpin() Chris Wilson
2017-07-24 8:55 ` Joonas Lahtinen
2017-07-21 14:50 ` [PATCH 2/4] drm/i915: Only mark the execobject as pinned on success Chris Wilson
2017-07-24 8:57 ` Joonas Lahtinen
2017-07-21 14:50 ` [PATCH 3/4] drm/i915: Only skip updating execobject.offset after error Chris Wilson
2017-07-26 9:08 ` Joonas Lahtinen [this message]
2017-07-21 14:50 ` [PATCH 4/4] drm/i915: Force CPU synchronisation even if userspace requests ASYNC Chris Wilson
2017-07-26 10:19 ` Joonas Lahtinen
2017-07-26 10:45 ` Chris Wilson
2017-07-21 16:24 ` ✗ Fi.CI.BAT: warning for series starting with [1/4] drm/i915: Remove assertion from raw __i915_vma_unpin() Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501060126.3720.1.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.