All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: "Hervé Poussineau" <hpoussin@reactos.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes
Date: Wed, 26 Jul 2017 14:33:10 +0200	[thread overview]
Message-ID: <1501072390.29903.6.camel@redhat.com> (raw)
In-Reply-To: <20170726120529.GG7620@redhat.com>

  Hi,

> FYI, after adding qcodes to the keycodemapdb, (but not having picked
> your branch),

I don't think this is a good idea.  qkeycode numbers are a qemu-private 
thing, they can (and did in the past) change.  The names are api and
must not change.

> I was actually just going add an entry for QKeyCode names to the
> keycodemapdb, so we can convert straight to that, and also let
> us auto-generate the qemu_input_linux_to_qcode() table.

Ok, with the names it should work.

> Strangely there is no Linux key code defined for AltGr, so if we
> map via Linux key codes, we would loose ability to send AltGr

KEY_RIGHTALT?

cheers,
  Gerd

  reply	other threads:[~2017-07-26 12:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 16:46 [Qemu-devel] [PATCH for 2.10] ps2: fix sending of PAUSE/BREAK scancodes Daniel P. Berrange
2017-07-24 19:55 ` Hervé Poussineau
2017-07-25  8:32   ` Daniel P. Berrange
2017-07-25 11:53     ` Gerd Hoffmann
2017-07-26 11:28       ` Daniel P. Berrange
2017-07-26 11:44         ` Gerd Hoffmann
2017-07-26 12:05           ` Daniel P. Berrange
2017-07-26 12:33             ` Gerd Hoffmann [this message]
2017-07-26 12:45               ` Daniel P. Berrange
2017-07-27  9:50                 ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501072390.29903.6.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=berrange@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.