diff for duplicates of <1501089516.2401.29.camel@baylibre.com> diff --git a/a/1.txt b/N1/1.txt index 14998c6..39465b2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -40,10 +40,10 @@ On Tue, 2017-07-25 at 17:12 -0700, Stephen Boyd wrote: > > + clk_prepare_lock(); > > + > > + /* -> > + ?* if there is something wrong with this consumer protect count, +> > + * if there is something wrong with this consumer protect count, > > stop -> > + ?* here before messing with the provider -> > + ?*/ +> > + * here before messing with the provider +> > + */ > > + if (WARN_ON(clk->protect_count <= 0)) > > + goto out; > > + @@ -80,16 +80,16 @@ When the whole CCF moves to a stack approach, I'll be happy to help. > [..] > > + > > @@ -2952,6 +3134,17 @@ void __clk_put(struct clk *clk) -> > ? -> > ? clk_prepare_lock(); -> > ? +> > +> > clk_prepare_lock(); +> > > > + /* -> > + ?* Before calling clk_put, all calls to clk_rate_protect from a +> > + * Before calling clk_put, all calls to clk_rate_protect from a > > given -> > + ?* user must be balanced with calls to clk_rate_unprotect and by +> > + * user must be balanced with calls to clk_rate_unprotect and by > > that -> > + ?* same user -> > + ?*/ +> > + * same user +> > + */ > > + WARN_ON(clk->protect_count); > > + > > + /* We voiced our concern, let's sanitize the situation */ @@ -119,9 +119,9 @@ If you really insist on this, I'll yield but I'm not a big fan. > > +++ b/include/linux/clk.h > > @@ -331,6 +331,30 @@ struct clk *devm_clk_get(struct device *dev, const char > > *id); -> > ? */ -> > ?struct clk *devm_get_clk_from_child(struct device *dev, -> > ? ????struct device_node *np, const char +> > */ +> > struct clk *devm_get_clk_from_child(struct device *dev, +> > struct device_node *np, const char > > *con_id); > > +/** > > + * clk_rate_protect - inform the system when the clock rate must be @@ -147,7 +147,7 @@ Having this API available is whole reason I've been working on this for so long. By the now, you may have forgot but I explained the use-case in first RFC [0] Here is an example (wip) of usage [1] -[0]: http://lkml.kernel.org/r/20170302173835.18313-1-jbrunet at baylibre.co +[0]: http://lkml.kernel.org/r/20170302173835.18313-1-jbrunet@baylibre.co [1]: https://github.com/jeromebrunet/linux/commits/amlogic/wip/audio-clk-lock > diff --git a/a/content_digest b/N1/content_digest index be38bb0..a65be11 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,10 +1,17 @@ "ref\020170612194438.12298-1-jbrunet@baylibre.com\0" "ref\020170612194438.12298-6-jbrunet@baylibre.com\0" "ref\020170726001217.GC2146@codeaurora.org\0" - "From\0jbrunet@baylibre.com (Jerome Brunet)\0" - "Subject\0[PATCH v3 05/10] clk: add support for clock protection\0" + "From\0Jerome Brunet <jbrunet@baylibre.com>\0" + "Subject\0Re: [PATCH v3 05/10] clk: add support for clock protection\0" "Date\0Wed, 26 Jul 2017 19:18:36 +0200\0" - "To\0linus-amlogic@lists.infradead.org\0" + "To\0Stephen Boyd <sboyd@codeaurora.org>\0" + "Cc\0Michael Turquette <mturquette@baylibre.com>" + linux-clk@vger.kernel.org + Kevin Hilman <khilman@baylibre.com> + linux-amlogic@lists.infradead.org + Russell King <linux@armlinux.org.uk> + Linus Walleij <linus.walleij@linaro.org> + " Boris Brezillon <boris.brezillon@free-electrons.com>\0" "\00:1\0" "b\0" "On Tue, 2017-07-25 at 17:12 -0700, Stephen Boyd wrote:\n" @@ -49,10 +56,10 @@ "> > +\tclk_prepare_lock();\n" "> > +\n" "> > +\t/*\n" - "> > +\t?* if there is something wrong with this consumer protect count,\n" + "> > +\t\302\240* if there is something wrong with this consumer protect count,\n" "> > stop\n" - "> > +\t?* here before messing with the provider\n" - "> > +\t?*/\n" + "> > +\t\302\240* here before messing with the provider\n" + "> > +\t\302\240*/\n" "> > +\tif (WARN_ON(clk->protect_count <= 0))\n" "> > +\t\tgoto out;\n" "> > +\n" @@ -89,16 +96,16 @@ "> [..]\n" "> > +\n" "> > @@ -2952,6 +3134,17 @@ void __clk_put(struct clk *clk)\n" - "> > ?\n" - "> > ?\tclk_prepare_lock();\n" - "> > ?\n" + "> > \302\240\n" + "> > \302\240\tclk_prepare_lock();\n" + "> > \302\240\n" "> > +\t/*\n" - "> > +\t?* Before calling clk_put, all calls to clk_rate_protect from a\n" + "> > +\t\302\240* Before calling clk_put, all calls to clk_rate_protect from a\n" "> > given\n" - "> > +\t?* user must be balanced with calls to clk_rate_unprotect and by\n" + "> > +\t\302\240* user must be balanced with calls to clk_rate_unprotect and by\n" "> > that\n" - "> > +\t?* same user\n" - "> > +\t?*/\n" + "> > +\t\302\240* same user\n" + "> > +\t\302\240*/\n" "> > +\tWARN_ON(clk->protect_count);\n" "> > +\n" "> > +\t/* We voiced our concern, let's sanitize the situation */\n" @@ -128,9 +135,9 @@ "> > +++ b/include/linux/clk.h\n" "> > @@ -331,6 +331,30 @@ struct clk *devm_clk_get(struct device *dev, const char\n" "> > *id);\n" - "> > ? */\n" - "> > ?struct clk *devm_get_clk_from_child(struct device *dev,\n" - "> > ?\t\t\t\t????struct device_node *np, const char\n" + "> > \302\240 */\n" + "> > \302\240struct clk *devm_get_clk_from_child(struct device *dev,\n" + "> > \302\240\t\t\t\t\302\240\302\240\302\240\302\240struct device_node *np, const char\n" "> > *con_id);\n" "> > +/**\n" "> > + * clk_rate_protect - inform the system when the clock rate must be\n" @@ -156,7 +163,7 @@ "By the now, you may have forgot but I explained the use-case in first RFC [0]\n" "Here is an example (wip) of usage [1]\n" "\n" - "[0]: http://lkml.kernel.org/r/20170302173835.18313-1-jbrunet at baylibre.co\n" + "[0]: http://lkml.kernel.org/r/20170302173835.18313-1-jbrunet@baylibre.co\n" "[1]: https://github.com/jeromebrunet/linux/commits/amlogic/wip/audio-clk-lock\n" "\n" "> \n" @@ -240,4 +247,4 @@ "> Please say clk_rate_protect() and clk_rate_unprotect() here.\n" > -4a501b546ef2ad96c3ecbdb8669b7f2b0c86ea4d0bbf713e878968d0d061461e +14b72234c5ad150c95c36a2812655a0eec9cd150b7744614ac7c5ee5b8379fe8
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.