All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Tom Rini <trini@konsulko.com>, "Wold, Saul" <saul.wold@intel.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] image: Convert vmdk/vdi/qcow2 to strict CONVERSION_CMD types
Date: Thu, 27 Jul 2017 22:14:15 +0100	[thread overview]
Message-ID: <1501190055.22282.171.camel@linuxfoundation.org> (raw)
In-Reply-To: <20170727162010.GB26163@bill-the-cat>

On Thu, 2017-07-27 at 12:20 -0400, Tom Rini wrote:
> On Thu, Jul 27, 2017 at 04:08:40PM +0000, Wold, Saul wrote:
> > 
> > On Tue, 2017-07-25 at 15:58 -0400, Tom Rini wrote:
> > > 
> > > The vmdk/vdi/qcow2 IMAGE_FSTYPEs predate wic.  As such, they
> > > provide
> > > some similar underlying functionality in order to produce a
> > > "disk"
> > > image
> > > that in turn can be converted into different formats that various
> > > hypervisor types work with.  They do not however provide the
> > > ability
> > > for
> > > other disk image types to be converted into these same output
> > > types.
> > > Furthermore, they are less flexible than what wic does
> > > provide.  This
> > > drops the old style vmdk/vdi/qcow2 types and re-introduces them
> > > under
> > > the CONVERSION_CMD framework.  The equivalent of vmdk is now
> > > wic.vmdk
> > > and so forth for the other types.
> > > 
> > I like this also!  Strong work!
> > 
> > Would this allow us to further collapse the live-vm-common.bbclass
> > back
> > to just image-live.bbclass.  I know that the magic mapping that
> > happens
> > in set_live_vm_vars() has caused confusion in the past and removing
> > that mapping would be pretty awesome.
> Yes, with this there is only one user of live-vm-common.bbclass, so
> it could be folded back.

This patchset looks to have caused a number of selftest failures:

https://autobuilder.yocto.io/builders/nightly-oe-selftest/builds/409/steps/Running%20oe-selftest/logs/stdio

I suspect there are some testcases which need updating with this
change, would you be able to take a look please?

Cheers,

Richard





  reply	other threads:[~2017-07-27 21:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25 19:58 [PATCH] image: Convert vmdk/vdi/qcow2 to strict CONVERSION_CMD types Tom Rini
2017-07-26  7:25 ` Ed Bartosh
2017-07-27 16:08 ` Wold, Saul
2017-07-27 16:20   ` Tom Rini
2017-07-27 21:14     ` Richard Purdie [this message]
2017-07-27 22:45       ` Tom Rini
2017-07-28 11:09 ` Jonathan Liu
2017-07-28 11:31   ` Tom Rini
2017-07-28 11:35     ` Jonathan Liu
2017-07-28 11:40       ` Ed Bartosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501190055.22282.171.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=saul.wold@intel.com \
    --cc=trini@konsulko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.