All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Philip Oakley <philipoakley@iee.org>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches
Date: Tue, 01 Aug 2017 21:29:31 +0530	[thread overview]
Message-ID: <1501603171.1671.8.camel@gmail.com> (raw)
In-Reply-To: <CAGZ79kYg9jQ3kaKnNEJCH9fde=ar1KPiUr7=X+TguNc0Twqdzg@mail.gmail.com>

On Mon, 2017-07-31 at 13:23 -0700, Stefan Beller wrote:
> On Sun, Jul 30, 2017 at 9:18 AM, Kaartic Sivaraam
> <kaarticsivaraam91196@gmail.com> wrote:
> > Replace the dashed version of a command with undashed
> > version and quote it.
> 
> I like it, but similar as below, we'd want to go for
> consistency.
> 
I assume you mean the consistency in quoting i.e., you're expecting the
patch to use (") instead of (') for quoting. Correct me, if I'm wrong.

> > 
> > Further, remove duplicated space character.
> 
> https://en.wikipedia.org/wiki/Sentence_spacing
> seems like a globally controversial thing. (I assumed
> it was some sort of local dialect before researching
> it properly)
> 
Man, I had no idea about people using two spaces after period.

> I personally do not mind one way or another regarding
> (double) spaces after a period, but I would think we'd
> strive for consistency throughout the project.
> 
Consistency is crucial. I'll just remove that part of the patch.

-- 
Kaartic

  parent reply	other threads:[~2017-08-01 16:00 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-30 11:09 [PATCH 1/2] doc: fix small issues in SubmittingPatches Kaartic Sivaraam
2017-07-30 11:09 ` [PATCH 2/2] doc: add another way to identify if a patch has been merged Kaartic Sivaraam
2017-07-30 14:49 ` [PATCH 1/2] doc: fix small issues in SubmittingPatches Philip Oakley
2017-07-30 16:17   ` Kaartic Sivaraam
2017-07-30 16:18   ` Kaartic Sivaraam
2017-07-31 20:23     ` Stefan Beller
2017-07-31 20:34       ` Junio C Hamano
2017-08-01 15:59       ` Kaartic Sivaraam [this message]
2017-08-01 17:38         ` Stefan Beller
2017-08-02 12:22           ` [RFC] The correct and consistent alternative to quote a command ? Kaartic Sivaraam
2017-08-02 15:37             ` Junio C Hamano
2017-08-02 17:32             ` Stefan Beller
2017-08-03 15:35               ` Kaartic Sivaraam
2017-08-01 16:05       ` [PATCH 1/2] doc: fix small issues in SubmittingPatches Kaartic Sivaraam
2017-08-01 16:05         ` [PATCH 2/2] doc: add another way to identify if a patch has been merged Kaartic Sivaraam
2017-08-01 17:46           ` Stefan Beller
2017-08-02 12:32             ` Kaartic Sivaraam
2017-08-02 16:01               ` Junio C Hamano
2017-08-02 16:28                 ` Junio C Hamano
2017-08-02 17:58                   ` Stefan Beller
2017-08-07 14:34                     ` Kaartic Sivaraam
2017-08-07 14:33                 ` Kaartic Sivaraam
2017-08-01 21:04       ` [PATCH 1/2] doc: fix small issues in SubmittingPatches Philip Oakley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501603171.1671.8.camel@gmail.com \
    --to=kaarticsivaraam91196@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=philipoakley@iee.org \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.