Re: [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

From: Mika Kahola <mika.kahola@intel.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC
Date: Wed, 02 Aug 2017 16:18:14 +0300	[thread overview]
Message-ID: <1501679894.16922.28.camel@intel.com> (raw)
In-Reply-To: <20170802124254.dkdzswr6ncw4r2um@platvala-desk.ger.corp.intel.com>

On Wed, 2017-08-02 at 15:42 +0300, Petri Latvala wrote:
> After a bit of digging into this n_words conundrum that I also could
> not understand, I found the issue Mika described.
> 
> kms_plane_multiple et al basically do
> 
> igt_crc_t crc;
> 
> 
> and then they pass &crc to test-internal helper functions, which pass
> the igt_crc_t* pointer to various igt lib functions. The problem is,
> those lib functions take igt_crc_t** so that they can give you the
> correct pointer, kms_plane* wrongly expect them to modify the passed
> object.
> 
> Mika, can you fix this while you're at it?
Right, we can do this without changing the original function call. I'll
throw a patch shortly.

Cheers,
Mika

> 
> 
> 
> --
> Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx