From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
"arnd.bergmann"
<arnd.bergmann-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
jslaby-IBi9RG/b67k@public.gmane.org,
jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org,
heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
hpeter-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
vigneshr-l0cyMroinI0@public.gmane.org,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 0/2] serial: 8250: add support for MediaTek BTIF controller
Date: Wed, 02 Aug 2017 21:02:15 +0300 [thread overview]
Message-ID: <1501696935.29303.367.camel@linux.intel.com> (raw)
In-Reply-To: <1501695470.25246.7.camel@mtkswgap22>
On Thu, 2017-08-03 at 01:37 +0800, Sean Wang wrote:
> On Wed, 2017-08-02 at 20:14 +0300, Andy Shevchenko wrote:
> > On Thu, 2017-08-03 at 01:05 +0800, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote:
> > > From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > >
> > > This patchset introduces the support for MediaTek BTIF controller.
> > >
> > > MediaTek BTIF controller is the serial interface similar to UART
> > > but
> > > it
> > > works only as the digital device which is mainly used to
> > > communicate
> > > with
> > > the connectivity module also called CONNSYS inside the SoC which
> > > could
> > > be
> > > mostly found on those MediaTek SoCs with Bluetooth feature.
> > >
> > > And the controller is made as being compatible with the 8250
> > > register
> > > layout so it tends to be integrated with existing 8250 core driver
> > > and
> > > have no requirement for the modem configuration additionally such
> > > as
> > > the
> > > baud rate calculation and assignment.
+Cc: Arnd.
> > Why it requires a separate driver?
> >
> > 8250_of is for DT enabled drivers.
> >
>
> Hi, Andy
>
> thanks for your information
>
> the hardware is not completely identical to 8250 device,
> it has extra registers belonged to platform control such as internal
> loopback, dma disable/enable, sleep/wakeup setup and so on, so I
> create
> it as a separate driver.
Over all 200+ LOCs I didn't see any of the above except loopback, which
is one property that can be easily added to 8250_of.c.
Moreover, if you have more code coming I would suggest you to split
8250_of to library and driver parts and re-use stuff from there.
Arnd, what is your opinion about new 8250 OF based drivers?
--
Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] serial: 8250: add support for MediaTek BTIF controller
Date: Wed, 02 Aug 2017 21:02:15 +0300 [thread overview]
Message-ID: <1501696935.29303.367.camel@linux.intel.com> (raw)
In-Reply-To: <1501695470.25246.7.camel@mtkswgap22>
On Thu, 2017-08-03 at 01:37 +0800, Sean Wang wrote:
> On Wed, 2017-08-02 at 20:14 +0300, Andy Shevchenko wrote:
> > On Thu, 2017-08-03 at 01:05 +0800, sean.wang at mediatek.com wrote:
> > > From: Sean Wang <sean.wang@mediatek.com>
> > >
> > > This patchset introduces the support for MediaTek BTIF controller.
> > >
> > > MediaTek BTIF controller is the serial interface similar to UART
> > > but
> > > it
> > > works only as the digital device which is mainly used to
> > > communicate
> > > with
> > > the connectivity module also called CONNSYS inside the SoC which
> > > could
> > > be
> > > mostly found on those MediaTek SoCs with Bluetooth feature.
> > >
> > > And the controller is made as being compatible with the 8250
> > > register
> > > layout so it tends to be integrated with existing 8250 core driver
> > > and
> > > have no requirement for the modem configuration additionally such
> > > as
> > > the
> > > baud rate calculation and assignment.
+Cc: Arnd.
> > Why it requires a separate driver?
> >
> > 8250_of is for DT enabled drivers.
> >
>
> Hi, Andy
>
> thanks for your information
>
> the hardware is not completely identical to 8250 device,?
> it has extra registers belonged to platform control such as internal
> loopback, dma disable/enable, sleep/wakeup setup and so on, so I
> create
> it as a separate driver.
Over all 200+ LOCs I didn't see any of the above except loopback, which
is one property that can be easily added to 8250_of.c.
Moreover, if you have more code coming I would suggest you to split
8250_of to library and driver parts and re-use stuff from there.
Arnd, what is your opinion about new 8250 OF based drivers?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sean Wang <sean.wang@mediatek.com>,
"arnd.bergmann" <arnd.bergmann@linaro.org>
Cc: robh+dt@kernel.org, gregkh@linuxfoundation.org, jslaby@suse.com,
jan.kiszka@siemens.com, heikki.krogerus@linux.intel.com,
hpeter@gmail.com, vigneshr@ti.com, matthias.bgg@gmail.com,
devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] serial: 8250: add support for MediaTek BTIF controller
Date: Wed, 02 Aug 2017 21:02:15 +0300 [thread overview]
Message-ID: <1501696935.29303.367.camel@linux.intel.com> (raw)
In-Reply-To: <1501695470.25246.7.camel@mtkswgap22>
On Thu, 2017-08-03 at 01:37 +0800, Sean Wang wrote:
> On Wed, 2017-08-02 at 20:14 +0300, Andy Shevchenko wrote:
> > On Thu, 2017-08-03 at 01:05 +0800, sean.wang@mediatek.com wrote:
> > > From: Sean Wang <sean.wang@mediatek.com>
> > >
> > > This patchset introduces the support for MediaTek BTIF controller.
> > >
> > > MediaTek BTIF controller is the serial interface similar to UART
> > > but
> > > it
> > > works only as the digital device which is mainly used to
> > > communicate
> > > with
> > > the connectivity module also called CONNSYS inside the SoC which
> > > could
> > > be
> > > mostly found on those MediaTek SoCs with Bluetooth feature.
> > >
> > > And the controller is made as being compatible with the 8250
> > > register
> > > layout so it tends to be integrated with existing 8250 core driver
> > > and
> > > have no requirement for the modem configuration additionally such
> > > as
> > > the
> > > baud rate calculation and assignment.
+Cc: Arnd.
> > Why it requires a separate driver?
> >
> > 8250_of is for DT enabled drivers.
> >
>
> Hi, Andy
>
> thanks for your information
>
> the hardware is not completely identical to 8250 device,
> it has extra registers belonged to platform control such as internal
> loopback, dma disable/enable, sleep/wakeup setup and so on, so I
> create
> it as a separate driver.
Over all 200+ LOCs I didn't see any of the above except loopback, which
is one property that can be easily added to 8250_of.c.
Moreover, if you have more code coming I would suggest you to split
8250_of to library and driver parts and re-use stuff from there.
Arnd, what is your opinion about new 8250 OF based drivers?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-08-02 18:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 17:05 [PATCH 0/2] serial: 8250: add support for MediaTek BTIF controller sean.wang
2017-08-02 17:05 ` sean.wang
2017-08-02 17:05 ` sean.wang at mediatek.com
2017-08-02 17:05 ` [PATCH 1/2] dt-bindings: serial: Add MediaTek BTIF controller bindings sean.wang
2017-08-02 17:05 ` sean.wang
2017-08-02 17:05 ` sean.wang at mediatek.com
2017-08-10 16:27 ` Rob Herring
2017-08-10 16:27 ` Rob Herring
2017-08-11 2:53 ` Sean Wang
2017-08-11 2:53 ` Sean Wang
2017-08-11 2:53 ` Sean Wang
2017-08-11 14:31 ` Rob Herring
2017-08-11 14:31 ` Rob Herring
2017-08-02 17:05 ` [PATCH 2/2] tty: serial: 8250: Add MediaTek BTIF controller on MT7622 and MT7623 SoC sean.wang
2017-08-02 17:05 ` sean.wang
2017-08-02 17:05 ` sean.wang at mediatek.com
2017-08-02 17:14 ` [PATCH 0/2] serial: 8250: add support for MediaTek BTIF controller Andy Shevchenko
2017-08-02 17:14 ` Andy Shevchenko
[not found] ` <1501694063.29303.361.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-08-02 17:37 ` Sean Wang
2017-08-02 17:37 ` Sean Wang
2017-08-02 17:37 ` Sean Wang
2017-08-02 18:02 ` Andy Shevchenko [this message]
2017-08-02 18:02 ` Andy Shevchenko
2017-08-02 18:02 ` Andy Shevchenko
2017-08-03 3:18 ` Sean Wang
2017-08-03 3:18 ` Sean Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501696935.29303.367.camel@linux.intel.com \
--to=andriy.shevchenko-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=arnd.bergmann-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=hpeter-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org \
--cc=jslaby-IBi9RG/b67k@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=vigneshr-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.