From: Dario Faggioli <dario.faggioli@citrix.com>
To: Meng Xu <mengxu@cis.upenn.edu>, xen-devel@lists.xenproject.org
Cc: george.dunlap@eu.citrix.com, wei.liu2@citrix.com,
xumengpanda@gmail.com, ian.jackson@eu.citrix.com
Subject: Re: [PATCH RFC v1 1/3] xen:rtds: enable XL to set and get vcpu work conserving flag
Date: Thu, 3 Aug 2017 17:47:10 +0200 [thread overview]
Message-ID: <1501775230.28477.8.camel@citrix.com> (raw)
In-Reply-To: <1501612434-5803-2-git-send-email-mengxu@cis.upenn.edu>
[-- Attachment #1.1: Type: text/plain, Size: 886 bytes --]
On Tue, 2017-08-01 at 14:33 -0400, Meng Xu wrote:
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -360,6 +360,7 @@ typedef struct xen_domctl_sched_credit2 {
> typedef struct xen_domctl_sched_rtds {
> uint32_t period;
> uint32_t budget;
> + bool is_work_conserving;
>
I wonder whether it wouldn't be better (e.g., more future proof) to
have a 'uint32_T flags' field here too.
That way, if/when, in future, we want to introduce some other way of
tweaking the scheduler's behavior for this vCPU, we already have space
for specifying it...
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-03 15:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 18:33 [PATCH RFC v1 0/3] Enable XL to set and get per-VCPU work conserving flag for RTDS scheduler Meng Xu
2017-08-01 18:33 ` [PATCH RFC v1 1/3] xen:rtds: enable XL to set and get vcpu work conserving flag Meng Xu
2017-08-03 15:47 ` Dario Faggioli [this message]
2017-08-03 15:53 ` Meng Xu
2017-08-01 18:33 ` [PATCH RFC v1 2/3] libxl: enable per-VCPU work conserving flag for RTDS Meng Xu
2017-08-03 15:53 ` Dario Faggioli
2017-08-03 21:39 ` Meng Xu
2017-08-04 8:13 ` Dario Faggioli
2017-08-04 12:10 ` Wei Liu
2017-08-04 12:53 ` Dario Faggioli
2017-08-04 14:34 ` Wei Liu
2017-08-04 20:47 ` Dario Faggioli
2017-08-04 21:01 ` Meng Xu
2017-08-04 12:10 ` Wei Liu
2017-08-01 18:33 ` [PATCH RFC v1 3/3] xl: " Meng Xu
2017-08-03 16:03 ` Dario Faggioli
2017-08-03 22:02 ` Meng Xu
2017-08-04 9:01 ` Dario Faggioli
2017-08-04 20:56 ` Meng Xu
2017-08-01 19:08 ` [PATCH RFC v1 0/3] Enable XL to set and get per-VCPU work conserving flag for RTDS scheduler Meng Xu
2017-08-02 17:49 ` Dario Faggioli
2017-08-03 2:33 ` Meng Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501775230.28477.8.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=mengxu@cis.upenn.edu \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=xumengpanda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.