All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: dev@dpdk.org, david.marchand@redhat.com,
	honnappa.nagarahalli@arm.com, konstantin.v.ananyev@yandex.ru,
	mattias.ronnblom@ericsson.com, olivier.matz@6wind.com,
	andrew.rybchenko@oktetlabs.ru,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] clarify purpose of empty cache lines
Date: Wed, 11 Oct 2023 17:59:12 +0200	[thread overview]
Message-ID: <15019809.tv2OnDr8pf@thomas> (raw)
In-Reply-To: <ZPWfZ9ayYJe7CQro@bricha3-MOBL.ger.corp.intel.com>

04/09/2023 11:12, Bruce Richardson:
> On Mon, Sep 04, 2023 at 10:43:49AM +0200, Morten Brørup wrote:
> > This patch introduces the generic RTE_CACHE_GUARD macro into the EAL, and
> > replaces vaguely described empty cache lines in the rte_ring structure
> > with this macro.
> > 
> > Although the implementation of the rte_ring structure assumes that the
> > hardware speculatively prefetches 1 cache line, this number can be changed
> > at build time by modifying RTE_CACHE_GUARD_LINES in rte_config.h.
> > 
> > The background and the RFC was discussed in this thread:
> > http://inbox.dpdk.org/dev/98CBD80474FA8B44BF855DF32C47DC35D87B39@smartserver.smartshare.dk/
> > 
> > Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> > ---
> Seems fine to me.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.




  reply	other threads:[~2023-10-11 15:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04  8:43 [PATCH] clarify purpose of empty cache lines Morten Brørup
2023-09-04  9:12 ` Bruce Richardson
2023-10-11 15:59   ` Thomas Monjalon [this message]
2023-09-05  6:41 ` Morten Brørup
2023-10-11 23:43 ` Thomas Monjalon
2023-10-12  6:00   ` Morten Brørup
2023-10-12  6:07   ` Morten Brørup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15019809.tv2OnDr8pf@thomas \
    --to=thomas@monjalon.net \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=mb@smartsharesystems.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.