From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Mon, 07 Aug 2017 15:13:40 +0000 Subject: Re: [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_i Message-Id: <1502118820.2219.19.camel@perches.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geoff Levand , SF Markus Elfring , linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras Cc: LKML , kernel-janitors@vger.kernel.org On Mon, 2017-08-07 at 08:10 -0700, Geoff Levand wrote: > On 08/07/2017 03:52 AM, SF Markus Elfring wrote: > > Omit an extra message for a memory allocation failure in this function. > NACK > > When a user asks me for help I would certainly like to get > 'Could not allocate cache tags' as apposed to nothing, since > the return value of ps3vram_cache_init() is not checked. You still get a dump_stack on alloc failure. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xR1JW6YhtzDqjB for ; Tue, 8 Aug 2017 01:13:47 +1000 (AEST) Message-ID: <1502118820.2219.19.camel@perches.com> Subject: Re: [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init() From: Joe Perches To: Geoff Levand , SF Markus Elfring , linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras Cc: LKML , kernel-janitors@vger.kernel.org Date: Mon, 07 Aug 2017 08:13:40 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2017-08-07 at 08:10 -0700, Geoff Levand wrote: > On 08/07/2017 03:52 AM, SF Markus Elfring wrote: > > Omit an extra message for a memory allocation failure in this function. > NACK > > When a user asks me for help I would certainly like to get > 'Could not allocate cache tags' as apposed to nothing, since > the return value of ps3vram_cache_init() is not checked. You still get a dump_stack on alloc failure.