From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Donglin Peng <dolinux.peng@gmail.com>
Subject: Re: [PATCH] ASoC: compress: Remove duplicated code
Date: Mon, 07 Aug 2017 16:59:14 +0100 [thread overview]
Message-ID: <1502121554.4828.70.camel@loki> (raw)
In-Reply-To: <20170807154253.sfmi6mmt4lj2d44k@sirena.org.uk>
On Mon, 2017-08-07 at 16:42 +0100, Mark Brown wrote:
> On Mon, Aug 07, 2017 at 10:28:30AM -0500, Pierre-Louis Bossart wrote:
> > On 8/7/17 10:07 AM, Mark Brown wrote:
>
> > > Are you sure that this is the assignment that should be deleted, and if
> > > so why? Note that it's both conditionally and unconditionally assigned
> > > later on... Some words in the commit log about why this copy is removed
> > > would be helpful.
>
> > Thanks for the report. Yes, the logic escapes me as well, there were two
> > separate changes from Liam and Richard Fitzgerald and I can't figure out why
> > the reassignments of the variable new_name are required.
>
> I've got a feeling it was people not working and testing against
> mainline independently trying to fix similar issues and ending up
> colliding when things went upstream.
Yeah, probably Richard and I working on something similar in the past.
Liam
next prev parent reply other threads:[~2017-08-07 15:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1502111504-7996-1-git-send-email-pengdonglin137@163.com>
2017-08-07 13:18 ` [PATCH] ASoC: compress: Remove duplicated code Donglin Peng
2017-08-07 15:07 ` Mark Brown
2017-08-07 15:07 ` Mark Brown
2017-08-07 15:28 ` Pierre-Louis Bossart
2017-08-07 15:42 ` Mark Brown
2017-08-07 15:59 ` Liam Girdwood [this message]
2017-08-07 16:33 ` Donglin Peng
2017-08-07 12:56 Peng Donglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502121554.4828.70.camel@loki \
--to=liam.r.girdwood@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dolinux.peng@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rf@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.