Re: [PATCH 01/37] sh-pfc: r8a7740: Add SCIF pin groups and functions

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Morimoto-san,

On Monday 22 April 2013 18:25:22 Kuninori Morimoto wrote:
> Hi Laurent
> 
> Thank you for your hard work
> 
> > +/* - SCIFA0
> > ----------------------------------------------------------------- */
> > +static const unsigned int scifa0_data_pins[] = {
> > +	/* RXD, TXD */
> > +	197, 198,
> > +};
> 
> I guess these numbers mean PORT197, PORT198,
> but,this kind of "direct numbering" is difficult to read/understand
> for non-expert people IMO.
> But, it is easy to understand that it is "GPIO PORT something" if there is
> ...
> 
> #define SH_GPIO_PORT(nr)	(nr)
> 
> This is just my opinion, and I'm not sure other people.

On R-Car platforms with banked GPIOs I totally agreed that the RCAR_GP_PIN() 
macro improved readability. In this particular case were the datasheet uses 
port numbers directly I don't think there's a need for a macro, as developers 
who touch this code are expected to at least know what a port number is :-)

-- 
Regards,

Laurent Pinchart