From: Oliver Neukum <oneukum@suse.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>, gregkh@linuxfoundation.org
Cc: stern@rowland.harvard.edu, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter
Date: Tue, 08 Aug 2017 10:28:23 +0200 [thread overview]
Message-ID: <1502180903.17208.2.camel@suse.com> (raw)
In-Reply-To: <20170808063254.6487-1-kai.heng.feng@canonical.com>
Am Dienstag, den 08.08.2017, 14:32 +0800 schrieb Kai-Heng Feng:
> Moshi USB to Ethernet Adapter internally uses a Genesys Logic hub to
> connect to Realtek r8153.
>
> The Realtek r8153 ethernet does not work on the internal hub, no-lpm quirk
> can make it work.
>
> Since another r8153 dongle at my hand does not have the issue, so add
> the quirk to the hub instead.
But in the comment you say you add it to the device!
This makes no sense.
[..]
> + /* Moshi USB to Ethernet Adapter */
> + { USB_DEVICE(0x05e3, 0x0616), .driver_info = USB_QUIRK_NO_LPM },
> +
Now is this a hub or a device? If this is a Genesys Logic hub,
you need to say that clearly and state that it is an internal hub.
Regards
Oliver
next prev parent reply other threads:[~2017-08-08 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 6:32 [PATCH v2] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter Kai-Heng Feng
2017-08-08 8:28 ` Oliver Neukum [this message]
2017-08-08 9:10 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502180903.17208.2.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.