From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Don Brace <don.brace@microsemi.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
Meelis Roos <mroos@linux.ee>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
Hannes Reinecke <hare@suse.com>
Subject: [PATCH 4/6] hpsa: Ignore errors for unsupported LV_DEVICE_ID VPD page
Date: Tue, 8 Aug 2017 10:35:13 +0200 [thread overview]
Message-ID: <1502181315-102499-5-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1502181315-102499-1-git-send-email-hare@suse.de>
Older controller do not support the LV_DEVICE_ID VPD page, so
we shouldn't print out an error message here.
Signed-off-by: Hannes Reinecke <hare@suse.com>
---
drivers/scsi/hpsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 4ebf5d4..dbd5fbc 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -3814,7 +3814,7 @@ static int hpsa_update_device_info(struct ctlr_info *h,
memset(this_device->device_id, 0,
sizeof(this_device->device_id));
if (hpsa_get_device_id(h, scsi3addr, this_device->device_id, 8,
- sizeof(this_device->device_id)))
+ sizeof(this_device->device_id) < 0))
dev_err(&h->pdev->dev,
"hpsa%d: %s: can't get device id for host %d:C0:T%d:L%d\t%s\t%.16s\n",
h->ctlr, __func__,
--
1.8.5.6
next prev parent reply other threads:[~2017-08-08 8:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 8:35 [PATCH RESEND 0/6] hpsa: support legacy boards Hannes Reinecke
2017-08-08 8:35 ` [PATCH 1/6] hpsa: consolidate status variables Hannes Reinecke
2017-08-09 13:40 ` Christoph Hellwig
2017-08-14 10:02 ` Hannes Reinecke
2017-08-08 8:35 ` [PATCH 2/6] hpsa: add support for legacy boards Hannes Reinecke
2017-08-09 13:41 ` Christoph Hellwig
2017-08-09 15:08 ` Hannes Reinecke
2017-08-09 15:59 ` Christoph Hellwig
2017-08-09 13:45 ` Christoph Hellwig
2017-08-09 14:50 ` Hannes Reinecke
2017-08-08 8:35 ` [PATCH 3/6] hpsa: disable volume status check for older controller Hannes Reinecke
2017-08-09 13:42 ` Christoph Hellwig
2017-08-11 13:23 ` Tomas Henzl
2017-08-14 10:45 ` Hannes Reinecke
2017-08-08 8:35 ` Hannes Reinecke [this message]
2017-08-09 13:45 ` [PATCH 4/6] hpsa: Ignore errors for unsupported LV_DEVICE_ID VPD page Christoph Hellwig
2017-08-08 8:35 ` [PATCH 5/6] hpsa: do not print errors for unsupported report luns format Hannes Reinecke
2017-08-09 13:46 ` Christoph Hellwig
2017-08-09 14:52 ` Hannes Reinecke
2017-08-08 8:35 ` [PATCH 6/6] hpsa: handle unsupported devices more gracefully Hannes Reinecke
2017-08-09 13:48 ` Christoph Hellwig
2017-08-09 22:08 ` [PATCH RESEND 0/6] hpsa: support legacy boards Don Brace
2017-08-10 7:07 ` Hannes Reinecke
2017-08-10 7:09 ` Christoph Hellwig
2017-08-10 7:29 ` Hannes Reinecke
2017-08-10 14:06 ` James Bottomley
2017-08-10 14:11 ` Hannes Reinecke
2017-08-10 19:15 ` Don Brace
2017-08-11 6:43 ` Hannes Reinecke
2017-08-11 16:35 ` Don Brace
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502181315-102499-5-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=don.brace@microsemi.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.