All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
	"edubezval@gmail.com" <edubezval@gmail.com>,
	"arnd@arndb.de" <arnd@arndb.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] thermal: fix INTEL_SOC_DTS_IOSF_CORE dependencies
Date: Tue, 08 Aug 2017 17:15:08 +0800	[thread overview]
Message-ID: <1502183708.4296.25.camel@intel.com> (raw)
In-Reply-To: <1501356129.3479.1.camel@intel.com>

On Sat, 2017-07-29 at 13:22 -0600, Pandruvada, Srinivas wrote:
> On Fri, 2017-07-21 at 18:16 +0200, Arnd Bergmann wrote:
> > 
> > We get a Kconfig warning when selecting this without also enabling
> > CONFIG_PCI:
> > 
> > warning: (X86_INTEL_LPSS && INTEL_SOC_DTS_IOSF_CORE &&
> > SND_SST_IPC_ACPI && MMC_SDHCI_ACPI && PUNIT_ATOM_DEBUG) selects
> > IOSF_MBI which has unmet direct dependencies (PCI)
> > 
> > This adds a new depedency.
> > 
> > Fixes: 3a2419f865a6 ("Thermal: Intel SoC: DTS thermal use common
> > APIs")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com

Applied.

thanks,
rui
> >
> 
> > 
> > ---
> >  drivers/thermal/Kconfig | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > index b5b5facb8747..ac2a53823576 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -342,7 +342,7 @@ config X86_PKG_TEMP_THERMAL
> >  
> >  config INTEL_SOC_DTS_IOSF_CORE
> >  	tristate
> > -	depends on X86
> > +	depends on X86 && PCI
> >  	select IOSF_MBI
> >  	help
> >  	  This is becoming a common feature for Intel SoCs to
> > expose
> > the additional
> > @@ -352,7 +352,7 @@ config INTEL_SOC_DTS_IOSF_CORE
> >  
> >  config INTEL_SOC_DTS_THERMAL
> >  	tristate "Intel SoCs DTS thermal driver"
> > -	depends on X86
> > +	depends on X86 && PCI
> >  	select INTEL_SOC_DTS_IOSF_CORE
> >  	select THERMAL_WRITABLE_TRIPS
> >  	help

      reply	other threads:[~2017-08-08  9:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21 16:16 [PATCH] thermal: fix INTEL_SOC_DTS_IOSF_CORE dependencies Arnd Bergmann
2017-07-29 19:22 ` Pandruvada, Srinivas
2017-08-08  9:15   ` Zhang Rui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502183708.4296.25.camel@intel.com \
    --to=rui.zhang@intel.com \
    --cc=arnd@arndb.de \
    --cc=edubezval@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=srinivas.pandruvada@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.