From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Robert Yang <liezhi.yang@windriver.com>,
bitbake-devel@lists.openembedded.org
Subject: Re: [WIP][RFC PATCH 5/5] bitbake: main: make observe-only work without --bind
Date: Tue, 08 Aug 2017 13:50:22 +0100 [thread overview]
Message-ID: <1502196622.18633.246.camel@linuxfoundation.org> (raw)
In-Reply-To: <53074458ae150fc7544b02f5c3e37ff49257cb27.1502183410.git.liezhi.yang@windriver.com>
On Tue, 2017-08-08 at 02:12 -0700, Robert Yang wrote:
> The bitbake --server-only can work without --bind, so --observe-only
> should also
> can work without --bind or --remote-server.
>
> And also allow the connection all the time, otherwise --observe-only
> doesn't
> work.
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> bitbake/lib/bb/main.py | 4 ----
> bitbake/lib/bb/server/process.py | 8 ++------
> 2 files changed, 2 insertions(+), 10 deletions(-)
The other patches look ok but I worry a bit about this one since the
code isn't really set up to handle multiple potentially competing
connections right now. If something is an observer, we need to ensure
its marked as such and can't send control commands...
Cheers,
Richard
next prev parent reply other threads:[~2017-08-08 12:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 9:12 [WIP][RFC PATCH 0/5] fix for memres bitbake Robert Yang
2017-08-08 9:12 ` [WIP][RFC PATCH 1/5] btiabke: main.py: remove unneeded float() Robert Yang
2017-08-08 9:12 ` [WIP][RFC PATCH 2/5] bitbake: main: add log handler when status-only Robert Yang
2017-08-08 12:14 ` Richard Purdie
2017-08-08 14:33 ` Robert Yang
2017-08-08 9:12 ` [WIP][RFC PATCH 3/5] bitbake: process: fix disconnect when BB_SERVER_TIMEOUT Robert Yang
2017-08-08 9:12 ` [WIP][RFC PATCH 4/5] bitbake: main: handle BB_SERVER_TIMEOUT = -1 Robert Yang
2017-08-08 9:12 ` [WIP][RFC PATCH 5/5] bitbake: main: make observe-only work without --bind Robert Yang
2017-08-08 12:50 ` Richard Purdie [this message]
2017-08-08 14:21 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502196622.18633.246.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=liezhi.yang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.