Re: [RFC v2 07/12] x86: implement set value flow for MBA.

[Chao Peng <chao.p.peng@linux.intel.com>]

>      /* write_msr is used to write out feature MSR register. */
>      void (*write_msr)(unsigned int cos, uint32_t val, enum
> psr_val_type type);
> +
> +    /*
> +     * check_change_val is used to check if input val fulfills SDM
> requirement.
> +     * Change it to valid value if SDM allows.
> +     */
> +    bool (*check_change_val)(const struct feat_node *feat, unsigned
> long *val);

I understand you need check the value and also potentially change the
value in certain case, but the naming here sounds not so good.

check_value? accept_value? or any other better solutions?

>  } *feat_props[FEAT_TYPE_NUM];
>  
>  /*
>  
> +static bool cat_check_change_val(const struct feat_node *feat,
> +                                 unsigned long *cbm)

and keep this as cat_check_cbm(),

> 
> +static bool mba_check_change_val(const struct feat_node *feat,
> +                                 unsigned long *thrtl)

and this becomes mba_check_thrtl()?

Chao

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel