From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Michael Ellerman" <mpe@ellerman.id.au>,
"Cédric Le Goater" <clg@kaod.org>,
linuxppc-dev@lists.ozlabs.org
Cc: Paul Mackerras <paulus@samba.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 10/10] powerpc/xive: fix the size of the cpumask used in xive_find_target_in_mask()
Date: Wed, 09 Aug 2017 17:29:09 +1000 [thread overview]
Message-ID: <1502263749.2563.36.camel@kernel.crashing.org> (raw)
In-Reply-To: <874lthnrse.fsf@concordia.ellerman.id.au>
On Wed, 2017-08-09 at 17:06 +1000, Michael Ellerman wrote:
> /**
> * cpumask_weight - Count of bits in *srcp
> * @srcp: the cpumask to count bits (< nr_cpu_ids) in.
> */
> static inline unsigned int cpumask_weight(const struct cpumask *srcp)
> {
> return bitmap_weight(cpumask_bits(srcp), nr_cpumask_bits);
> }
>
>
> I don't know what the comment on srcp is trying to say. It's not true
> that it only counts nr_cpu_ids worth of bits.
Right, and that's what bit me. We should report that on lkml and maybe
propose a patch that crops the result...
Cheers,
Ben.
next prev parent reply other threads:[~2017-08-09 7:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 9:02 [PATCH 10/10] powerpc/xive: fix the size of the cpumask used in xive_find_target_in_mask() Cédric Le Goater
2017-08-09 7:06 ` Michael Ellerman
2017-08-09 7:29 ` Benjamin Herrenschmidt [this message]
2017-08-09 7:30 ` Cédric Le Goater
2017-08-24 5:49 ` Michael Ellerman
2017-08-24 7:37 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502263749.2563.36.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.