From: Jean Delvare <jdelvare@suse.de>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Linux I2C <linux-i2c@vger.kernel.org>, Wolfram Sang <wsa@the-dreams.de>
Subject: Re: i2c-tools 4.0
Date: Thu, 10 Aug 2017 11:29:27 +0200 [thread overview]
Message-ID: <1502357367.6201.9.camel@suse.de> (raw)
In-Reply-To: <alpine.LFD.2.20.1708100427530.31724@localhost.localdomain>
On jeu., 2017-08-10 at 04:30 -0400, Robert P. J. Day wrote:
> On Thu, 10 Aug 2017, Jean Delvare wrote:
> > Thanks for the report. I wonder why people always wait for
> > announcements of imminent releases to report bugs ;-) Bugs have to
> > be fixed anyway, before or after a release doesn't really make a
> > difference, as there were other releases before and there will be
> > other releases later. Distributions will cherry pick individual
> > commits for backport as needed.
>
> i actually did ask about this very issue last month:
>
> http://marc.info/?l=linux-i2c&m=150109384702585&w=2
You forgot to Cc me :(
> > Back to the bug itself, the fix will clearly slow down the writes
> > for some users. I'm not so worried as writing to EEPROMs isn't a
> > frequent operation and better safe than sorry. So I can apply it,
> > but for the long term I think this is calling for either a command
> > line parameter (to let the user decide of the sleep time) or a retry
> > loop (this is what the at24 kernel driver is doing.) If anyone wants
> > to provide a patch implementing either solution, I'll be happy to
> > review it.
>
> if the patch referred to above still applies cleanly, i can just
> submit that later today. i understand that it will slow down writes;
> on the other hand, without it, multi-byte writes simply won't work.
No need, I already applied a cleaned up version thereof:
https://git.kernel.org/pub/scm/utils/i2c-tools/i2c-tools.git/commit/?id=7c1260bd0ee73c392f8c2a5b32b4b7c118011255
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2017-08-10 9:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 13:34 i2c-tools 4.0 Jean Delvare
2017-08-07 21:06 ` Wolfram Sang
2017-08-08 17:59 ` Robert P. J. Day
2017-08-10 7:59 ` Jean Delvare
2017-08-10 8:30 ` Robert P. J. Day
2017-08-10 9:29 ` Jean Delvare [this message]
2017-08-10 18:19 ` Robert P. J. Day
2017-10-12 11:42 ` Ondřej Lysoněk
2017-10-19 15:00 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502357367.6201.9.camel@suse.de \
--to=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.