From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h (v2) Date: Thu, 10 Aug 2017 11:39:16 +0200 Message-ID: <1502357956.6201.10.camel@suse.de> References: <20160308133713.24e0b71a@endymion> <1457461957-23029-1-git-send-email-matthew.d.roper@intel.com> <20160317151820.28fe70da@endymion> <20170731103605.1810e281@endymion> <20170809161849.GA4496@mdroper-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB79389D9A for ; Thu, 10 Aug 2017 09:39:21 +0000 (UTC) In-Reply-To: <20170809161849.GA4496@mdroper-desk.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab List-Id: intel-gfx@lists.freedesktop.org T24gbWVyLiwgMjAxNy0wOC0wOSBhdCAwOToxOCAtMDcwMCwgTWF0dCBSb3BlciB3cm90ZToKPiBP biBNb24sIEp1bCAzMSwgMjAxNyBhdCAxMDozNjowNUFNICswMjAwLCBKZWFuIERlbHZhcmUgd3Jv dGU6Cj4gPiAKPiA+IEhpIE1hdHQsIE1hdXJvLAo+ID4gCj4gPiBPbiBUaHUsIDE3IE1hciAyMDE2 IDE1OjE4OjIwICswMTAwLCBKZWFuIERlbHZhcmUgd3JvdGU6Cj4gPiA+IAo+ID4gPiBPbiBUdWUs ICA4IE1hciAyMDE2IDEwOjMyOjM3IC0wODAwLCBNYXR0IFJvcGVyIHdyb3RlOgo+ID4gPiA+IAo+ ID4gPiA+IEEgY291cGxlIG9mIHRoZSBFREFDIGRyaXZlcnMgaGF2ZSBhIG5pY2UgbWVtZGV2X2Rt aV9lbnRyeSBzdHJ1Y3R1cmUgZm9yCj4gPiA+ID4gZGVjb2RpbmcgRE1JIG1lbW9yeSBkZXZpY2Ug ZW50cmllcy4gIE1vdmUgdGhlIHN0cnVjdHVyZSBkZWZpbml0aW9uIHRvCj4gPiA+ID4gZG1pLmgg c28gdGhhdCBpdCBjYW4gYmUgc2hhcmVkIGJldHdlZW4gdGhvc2UgZHJpdmVycyBhbmQgYWxzbyBv dGhlcgo+ID4gPiA+IHBhcnRzIG9mIHRoZSBrZXJuZWw7IHRoZSBpOTE1IGdyYXBoaWNzIGRyaXZl ciBpcyBnb2luZyB0byBuZWVkIHRvIHVzZQo+ID4gPiA+IHRoaXMgc3RydWN0dXJlIHNvb24gYXMg d2VsbC4gIEFzIHBhcnQgb2YgdGhpcyBtb3ZlIHdlIHJlbmFtZSB0aGUKPiA+ID4gPiBzdHJ1Y3R1 cmUgcy9tZW1kZXZfZG1pX2VudHJ5L2RtaV9lbnRyeV9tZW1kZXYvIHRvIGVuc3VyZSBpdCBoYXMg YSBwcm9wZXIKPiA+ID4gPiAnZG1pJyBwcmVmaXguCj4gPiA+ID4gCj4gPiA+ID4gdjI6Cj4gPiA+ ID4gIC0gUmVuYW1lIHN0cnVjdHVyZSB0byBkbWlfZW50cnlfbWVtZGV2LiAgKEplYW4pCj4gPiA+ ID4gIC0gVXNlIF9fcGFja2VkIGluc3RlYWQgb2YgX19hdHRyaWJ1dGVfXygoX19wYWNrZWRfXykp IGZvciBjb25zaXN0ZW5jeQo+ID4gPiA+ICAgIHdpdGggdGhlIHJlc3Qgb2YgdGhlIGRtaS5oIGhl YWRlci4gIChKZWFuKSAgCj4gPiA+IAo+ID4gPiBMb29rcyBiZXR0ZXIuICguLi4pCj4gPiAKPiA+ IFdoYXQgaGFwcGVuZWQgdG8gdGhpcyBwYXRjaD8gSSBuZXZlciByZWNlaXZlZCB2My4gSXMgaXQg c2lsbCBuZWVkZWQ/Cj4gCj4gV2UgZW5kZWQgdXAgZ29pbmcgYSBkaWZmZXJlbnQgZGlyZWN0aW9u IGluIHRoZSBncmFwaGljcyBkcml2ZXIgYW5kIHdvdW5kCj4gdXAgbm90IG5lZWRpbmcgYWNjZXNz IHRvIHRoaXMgc3RydWN0dXJlLiAgSWYgdGhlcmUncyBzdGlsbCBpbnRlcmVzdCBpbgo+IHRoZSBn ZW5lcmFsIHJlZmFjdG9yaW5nIGhlcmUsIGxldCBtZSBrbm93IGFuZCBJIGNhbiBpbmNvcnBvcmF0 ZSB5b3VyCj4gbGFzdCBmZWVkYmFjayBhbmQgcmVzcGluIGEgdjMuCgpObywgaWYgeW91IGRvbid0 IG5lZWQgaXQgYW55bW9yZSBJJ2xsIGp1c3QgZHJvcCBpdC4KClRoYW5rcywKLS0gCkplYW4gRGVs dmFyZQpTVVNFIEwzIFN1cHBvcnQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752358AbdHJJjW (ORCPT ); Thu, 10 Aug 2017 05:39:22 -0400 Received: from mx2.suse.de ([195.135.220.15]:54418 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752105AbdHJJjV (ORCPT ); Thu, 10 Aug 2017 05:39:21 -0400 Message-ID: <1502357956.6201.10.camel@suse.de> Subject: Re: [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h (v2) From: Jean Delvare To: Matt Roper Cc: intel-gfx@lists.freedesktop.org, Mauro Carvalho Chehab , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 10 Aug 2017 11:39:16 +0200 In-Reply-To: <20170809161849.GA4496@mdroper-desk.amr.corp.intel.com> References: <20160308133713.24e0b71a@endymion> <1457461957-23029-1-git-send-email-matthew.d.roper@intel.com> <20160317151820.28fe70da@endymion> <20170731103605.1810e281@endymion> <20170809161849.GA4496@mdroper-desk.amr.corp.intel.com> Organization: Suse Linux Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On mer., 2017-08-09 at 09:18 -0700, Matt Roper wrote: > On Mon, Jul 31, 2017 at 10:36:05AM +0200, Jean Delvare wrote: > > > > Hi Matt, Mauro, > > > > On Thu, 17 Mar 2016 15:18:20 +0100, Jean Delvare wrote: > > > > > > On Tue, 8 Mar 2016 10:32:37 -0800, Matt Roper wrote: > > > > > > > > A couple of the EDAC drivers have a nice memdev_dmi_entry structure for > > > > decoding DMI memory device entries. Move the structure definition to > > > > dmi.h so that it can be shared between those drivers and also other > > > > parts of the kernel; the i915 graphics driver is going to need to use > > > > this structure soon as well. As part of this move we rename the > > > > structure s/memdev_dmi_entry/dmi_entry_memdev/ to ensure it has a proper > > > > 'dmi' prefix. > > > > > > > > v2: > > > > - Rename structure to dmi_entry_memdev. (Jean) > > > > - Use __packed instead of __attribute__((__packed__)) for consistency > > > > with the rest of the dmi.h header. (Jean) > > > > > > Looks better. (...) > > > > What happened to this patch? I never received v3. Is it sill needed? > > We ended up going a different direction in the graphics driver and wound > up not needing access to this structure. If there's still interest in > the general refactoring here, let me know and I can incorporate your > last feedback and respin a v3. No, if you don't need it anymore I'll just drop it. Thanks, -- Jean Delvare SUSE L3 Support