From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Joe Perches <joe@perches.com>,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>,
davem@davemloft.net
Cc: netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com
Subject: Re: [net-next 03/12] e1000e: add check on e1e_wphy() return value
Date: Thu, 10 Aug 2017 20:54:24 -0700 [thread overview]
Message-ID: <1502423664.5735.8.camel@intel.com> (raw)
In-Reply-To: <1502420020.3099.1.camel@perches.com>
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
On Thu, 2017-08-10 at 19:53 -0700, Joe Perches wrote:
> On Thu, 2017-08-10 at 21:47 -0500, Gustavo A. R. Silva wrote:
> > Hello everybody,
> >
> > I'm a little confused. Is this patch causing any trouble?
>
> Not to me. I no longer have an e1000e.
>
> Given the commit message, this just seemed to be a patch
> that _might_ cause an issue if this code patch is actually
> untested.
>
> Compilation wise, it's obviously fine.
Fortunately, I have all patches submitted to me thoroughly tested. It
was a good catch, and we confirmed it does provide a valid fix.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-11 3:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 21:47 [net-next 00/12][pull request] 1GbE Intel Wired LAN Driver Updates 2017-08-08 Jeff Kirsher
2017-08-09 21:47 ` [net-next 01/12] igb: Fix error of RX network flow classification Jeff Kirsher
2017-08-09 21:47 ` [net-next 02/12] igb: protect TX timestamping from API misuse Jeff Kirsher
2017-08-09 21:47 ` [net-next 03/12] e1000e: add check on e1e_wphy() return value Jeff Kirsher
2017-08-10 17:56 ` Joe Perches
2017-08-11 2:47 ` Gustavo A. R. Silva
2017-08-11 2:53 ` Joe Perches
2017-08-11 3:54 ` Jeff Kirsher [this message]
2017-08-09 21:47 ` [net-next 04/12] igb: Remove incorrect "unexpected SYS WRAP" log message Jeff Kirsher
2017-08-09 21:47 ` [net-next 05/12] igb: add argument names to mailbox op function declarations Jeff Kirsher
2017-08-09 21:47 ` [net-next 06/12] igb: expose mailbox unlock method Jeff Kirsher
2017-08-09 21:47 ` [net-next 07/12] igb: do not drop PF mailbox lock after read of VF message Jeff Kirsher
2017-08-09 21:47 ` [net-next 08/12] e1000e: Initial Support for IceLake Jeff Kirsher
2017-08-09 21:47 ` [net-next 09/12] igbvf: add lock around mailbox ops Jeff Kirsher
2017-08-09 21:47 ` [net-next 10/12] igbvf: after mailbox write, wait for reply Jeff Kirsher
2017-08-09 21:47 ` [net-next 11/12] igbvf: convert msleep to mdelay in atomic context Jeff Kirsher
2017-08-14 10:17 ` David Laight
2017-08-15 19:32 ` Greg Edwards
2017-08-16 10:58 ` David Laight
2017-08-09 21:47 ` [net-next 12/12] igb: support BCM54616 PHY Jeff Kirsher
2017-08-09 23:49 ` [net-next 00/12][pull request] 1GbE Intel Wired LAN Driver Updates 2017-08-08 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502423664.5735.8.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=garsilva@embeddedor.com \
--cc=joe@perches.com \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.