From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Cc: peter.kjellerstedt@axis.com
Subject: [PATCH 2/6 v2] git: Do not install git cvsserver and git svn by default
Date: Tue, 15 Aug 2017 16:41:53 -0500 [thread overview]
Message-ID: <1502833317-48183-3-git-send-email-mark.hatle@windriver.com> (raw)
In-Reply-To: <1502833317-48183-1-git-send-email-mark.hatle@windriver.com>
From: Peter Kjellerstedt <pkj@axis.com>
These git commands require Perl modules that do not exist in OE-Core.
Add PACKAGECONFIGs to enable them. Be aware though that if you enable
them you must also provide the missing dependencies.
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
---
meta/recipes-devtools/git/git.inc | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/meta/recipes-devtools/git/git.inc b/meta/recipes-devtools/git/git.inc
index 4390b8d..9b4c128 100644
--- a/meta/recipes-devtools/git/git.inc
+++ b/meta/recipes-devtools/git/git.inc
@@ -13,6 +13,10 @@ S = "${WORKDIR}/git-${PV}"
LIC_FILES_CHKSUM = "file://COPYING;md5=7c0d7ef03a7eb04ce795b0f60e68e7e1"
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[cvsserver] = ""
+PACKAGECONFIG[svn] = ""
+
EXTRA_OECONF = "--with-perl=${STAGING_BINDIR_NATIVE}/perl-native/perl \
--without-tcltk \
"
@@ -54,6 +58,23 @@ perl_native_fixup () {
mkdir -p ${D}${libdir}
mv ${D}${exec_prefix}/lib/perl-native/perl ${D}${libdir}
rmdir -p ${D}${exec_prefix}/lib/perl-native || true
+
+ if [ ! "${@bb.utils.filter('PACKAGECONFIG', 'cvsserver', d)}" ]; then
+ # Only install the git cvsserver command if explicitly requested
+ # as it requires the DBI Perl module, which does not exist in
+ # OE-Core.
+ rm ${D}${libexecdir}/git-core/git-cvsserver \
+ ${D}${bindir}/git-cvsserver
+ fi
+
+ if [ ! "${@bb.utils.filter('PACKAGECONFIG', 'svn', d)}" ]; then
+ # Only install the git svn command and all Git::SVN Perl modules
+ # if explicitly requested as they require the SVN::Core Perl
+ # module, which does not exist in OE-Core.
+ rm -r ${D}${libexecdir}/git-core/git-svn \
+ ${D}${libdir}/perl/site_perl/*/Git/SVN*
+ sed -i -e '/SVN/d' ${D}${libdir}/perl/site_perl/*/auto/Git/.packlist
+ fi
}
REL_GIT_EXEC_PATH = "${@os.path.relpath(libexecdir, bindir)}/git-core"
--
1.8.3.1
next prev parent reply other threads:[~2017-08-15 21:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 21:41 [PATCH 0/6 v2] Fix RPM4 regressions based on Pyro Mark Hatle
2017-08-15 21:41 ` [PATCH 1/6 v2] rpm: Add dependencies on bash, perl and python3-core Mark Hatle
2017-08-15 21:41 ` Mark Hatle [this message]
2017-08-15 21:41 ` [PATCH 3/6 v2] texinfo: Avoid a problem with a dependency on perl(Locale::gettext_xs) Mark Hatle
2017-08-15 21:41 ` [PATCH 4/6 v2] package_rpm.bbclass: Filter out unwanted file deps for nativesdk packages Mark Hatle
2017-08-15 21:41 ` [PATCH 5/6 v2] package.bbclass: Restore functionality to detect RPM dependencies Mark Hatle
2017-08-15 21:41 ` [PATCH 6/6 v2] rpm: Disable perl dependency generation Mark Hatle
2017-08-16 5:19 ` [PATCH 0/6 v2] Fix RPM4 regressions based on Pyro akuster808
2017-08-16 13:43 ` Richard Purdie
2017-08-16 20:43 ` Peter Kjellerstedt
2017-08-16 13:34 ` Richard Purdie
2017-08-16 15:18 ` Mark Hatle
2017-08-16 15:37 ` Mark Hatle
2017-08-17 10:53 ` Alexander Kanavin
2017-08-17 13:01 ` Peter Kjellerstedt
2017-08-17 13:17 ` Alexander Kanavin
2017-08-17 14:41 ` Mark Hatle
2017-08-17 14:37 ` Mark Hatle
2017-08-16 15:32 ` ✗ patchtest: failure for Fix RPM4 regressions based on Pyro (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502833317-48183-3-git-send-email-mark.hatle@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.kjellerstedt@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.