From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leonard Crestez Subject: Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms Date: Wed, 16 Aug 2017 12:42:45 +0300 Message-ID: <1502876565.23210.15.camel@nxp.com> References: <1b93c94cb8b4914314e4f50304c3cb11c53d8b14.1500373914.git.viresh.kumar@linaro.org> <1500983686.30745.28.camel@nxp.com> <20170726060634.GY352@vireshk-i7> <1501174453.7957.30.camel@nxp.com> <20170728052843.GT352@vireshk-i7> <20170816063431.GB24299@vireshk-i7> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bn3nam01on0057.outbound.protection.outlook.com ([104.47.33.57]:18560 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751666AbdHPJmx (ORCPT ); Wed, 16 Aug 2017 05:42:53 -0400 In-Reply-To: <20170816063431.GB24299@vireshk-i7> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Viresh Kumar , Rafael Wysocki , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: linux-pm@vger.kernel.org, Vincent Guittot , linux@dominikbrodowski.net, linux-kernel@vger.kernel.org On Wed, 2017-08-16 at 12:04 +0530, Viresh Kumar wrote: > On 28-07-17, 10:58, Viresh Kumar wrote: > > > > At this point I really feel that this is a hardware specific problem > > and it was working by chance until now. And I am not sure if we > > shouldn't be stopping this patch from getting merged just because of > > that. > > > > At least you can teach your distribution to go increase the sampling > > rate from userspace to make it all work. > Its been 3 weeks since my last email on this thread and no reply yet > from any of the IMX maintainers. Can someone please help here ? > > @Shawn: Can you help debugging a bit here, to see what's get screwed > up due to this commit ? Its just that your platform isn't able to > change freq at 10 ms rate. > > @Rafael: I am not sure, but should we be stopping this patch because > some hardware isn't able to change freq at 10ms interval and is just > faking the transition delay to start with ? > > Maybe we get this merged again and the IMX guys can figure out what's > wrong on their platform and how to fix it ? I reported the initial issue but did not have the time to do a more thorough investigation, this is more complicated than it seems. I said this before but maybe it got lost: I don't think the odd behavior I noticed justifies keeping the patch from merging. -- Regards, Leonrd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752105AbdHPJm4 (ORCPT ); Wed, 16 Aug 2017 05:42:56 -0400 Received: from mail-bn3nam01on0057.outbound.protection.outlook.com ([104.47.33.57]:18560 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751666AbdHPJmx (ORCPT ); Wed, 16 Aug 2017 05:42:53 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; Message-ID: <1502876565.23210.15.camel@nxp.com> Subject: Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms From: Leonard Crestez To: Viresh Kumar , Rafael Wysocki , Shawn Guo , Sascha Hauer , Fabio Estevam CC: , Vincent Guittot , , Date: Wed, 16 Aug 2017 12:42:45 +0300 In-Reply-To: <20170816063431.GB24299@vireshk-i7> References: <1b93c94cb8b4914314e4f50304c3cb11c53d8b14.1500373914.git.viresh.kumar@linaro.org> <1500983686.30745.28.camel@nxp.com> <20170726060634.GY352@vireshk-i7> <1501174453.7957.30.camel@nxp.com> <20170728052843.GT352@vireshk-i7> <20170816063431.GB24299@vireshk-i7> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131473501716959030;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.158.2;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39860400002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(377424004)(189002)(24454002)(199003)(305945005)(2906002)(8656003)(230700001)(104016004)(85426001)(229853002)(356003)(8936002)(5820100001)(47776003)(50226002)(5660300001)(54906002)(50466002)(498600001)(69596002)(81166006)(93886004)(81156014)(53546010)(23676002)(626005)(53936002)(8676002)(76176999)(4326008)(50986999)(103116003)(36756003)(68736007)(2950100002)(6636002)(97736004)(86362001)(77096006)(106466001)(189998001)(33646002)(105606002)(6246003)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:CO2PR03MB2264;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11OLC016;1:nwI9rBdAtaXE9zHMQsOfeSRGGKbzbCJVjK+11Zho0pMeaGMb1BjrihXPR9WwOo72J4QlJA9bgmcEsccopTykzgKe2VPu+yiOmAhGSlxVP8Db4QfFZHG3PwplG650TIA+oPCCiloL3M3WSHJa89xmN4QqEP/+JZHjakyz5GPB2LR6QLvq10SSiduKZy78XynBNV9iFwR3f+zQAUoMUgrd2lWZlBO9e4ifcI3Z1kag86lVxlOXlf1wRVud0E6t33QIeDdjNd+ICYg0CEsSLNn1/0Jm9lPDVZDMd3MKr/N/PhJKHgtypy0ABBg1yorvQxQkSuv4SD3Klr0Rtl4ogpuiIGcVQuq+4Btc9tIlsgx789NKM4K2S16PI+R5gUHc4dSu5ElU2+Z/OfWYiU10i4c/0PrdmlzWXHlRmhXXYy+eBIGLXQzoSjdgAtvV3J33CWaqaN6dnOsK7pm6cGxhnPeGOg6BcunlY7nlAeUdi/HsuwmTWqqx9lg7K3TKyUWxry4gV4nwsZeQVzHu+vXKBwLzjOcDJJNrU2EAdN2M5q86TH3E+ycHP1wJNp0/5cao0J4ba32AXCFEagRQFrNjkmhtkJPYS1n5EhhoGn36EtKmnIXq1boLYdAuHUHryarURC4tqIYiKuoU5OZusDzYj4+XgpZQ7H0kkOtFvcGLnR+RWK72AeVAR+4Q0EUAWhgYF+c+2h8LxHsTwZ92F61c3Llav12FHguHSUpvucJT5wuYyfBYzgeQu30Q9lL1HxNn1jCWsc0BnJANUNzuFq2bvpDgj5mhhoAc2C6/p5Yj8OEXs6PBjRo21NSnv22PbIz6K27yOz3GHHAmuMX1JrUeQyC36gO2tdWiXqYaYdeR20J0sBA= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 78fd7d1c-1461-45c2-edd9-08d4e48b29ab X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603156)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CO2PR03MB2264; X-Microsoft-Exchange-Diagnostics: 1;CO2PR03MB2264;3:vJ6nw7bShctcSm6Gl0ucUaAn//bveKOsDHxT6X4FX9CNR5jEdtLFjtQdv7P6RdCIFnPDdUuRDGjJleCLX51vLPOboeKyRqm/2Co8ESW2dozZ47QDADmM+t3FW8Qu2N4YMDsnbKKslLpiXtQATkL2WmWFn1dTHjeaDZfk6gCTPCOIhJwdAwN4TRpy0el/m5Ji7zM0z9hxATyXDxvaT0mubrxMQZbeJUVHhQuLAnAPqOZdaEEK7Ndl/bLnhzGb80fGm5isC+HNrP484xLS0zeQw6Go983dAMoyfCz1IoBmD+ARXke94hCPTosJc56kz3HySUXVDcodLspfeq/6iBCZXhiyCAMkVoK+7qDR63mNTTA=;25:XUek6zmp0ZLYqmNdGcCSPY+lVI2XMzKr28G6rHybw4pfd4eiG6DwdFzN+9pp1qRu6qCZumMhY4Kq9heGuzgDmvDr8m3WEucUdTpXbgcbiu/vU02WVsrMGka+WfQ+FlmTChF885GLdOI47AlMFJcv+iVKae9/AotPvcPQJ3Hg4W7ATicLb6FaqiUsbMq75fpKhLi+ywQxHLFUyb7XCa/GchDfRwkltH3NcTe5hbgM6lKWBVjzJfCVWGPfbdd+gec0Lh3iafsbtrQrdS6Wp/K9odD8A+pIZtiBddA6LUE3cR5g/aADTS+DR7621MruHobr//GmZvnNP0ANPktaCmph3A== X-MS-TrafficTypeDiagnostic: CO2PR03MB2264: X-Microsoft-Exchange-Diagnostics: 1;CO2PR03MB2264;31:oqEcZIZTQCWmSN8WWYPOhB3kOzj8N6AVrvSjXqpag36zuKd1H1FnadwpqplkKgthwrABOgBMMVaEa+y4ixb7v5g4qtmTLbS+th371BDwaKLzRFAkDqXQLSE9B9vYOG4d+nxjExR26RvFk9yvbGQwAjWEF1fhloxMoUvxJb/ob7R35KlfgpgpC4oQTnTTHEIu3AJxln1uW5g8Q7YGv4e6NSMOHlweVIXyGxcCye1H9c8=;4:S2ZkRR1vnqEqUzvIek5BXpf4M7jfEkNgaO5SRCQNJObP2t0m0B4U0E+VTBwpx2OOOlNrkKhoucKioR6HYqHh6flf2OdxWCR6QWNQbozFbcEJmNEz/LPxfDwCpKTXhZEuI1YmT+S2b6gCrc4yfUcrV+5c4Ha8qfyTF0zhHkYo+grDfo5CLCoZLg+k3Ev4ERHbaSH9iiG9z8+eRgbJ0L2fVwXsaKHw6StbwQY0jvsFczLRIM4cvbSrWFu19DpyH0yA X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(8121501046)(5005006)(13016025)(13018025)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6096035)(20161123561025)(20161123563025)(20161123556025)(20161123565025)(20161123559100)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CO2PR03MB2264;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CO2PR03MB2264; X-Forefront-PRVS: 0401647B7F X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjAzTUIyMjY0OzIzOmFKejNHbmR6Vk5lS3V2QW1Db1NiSU5uUVpF?= =?utf-8?B?S0dpV1dDaGdER3BwWWVjQUdCcEJpclA3UEdxV1V3ZjF5Nkl5cU5aYmpiL0p5?= =?utf-8?B?VjlvSnBOUWIzS2ZrK2xpNXdMS3RIL1djdE1Jb0l2aytxdEpobW5ReTZjYU5k?= =?utf-8?B?dkY2U2laSXRIalNOM3NTWUFNUzRvdTVtTDJnN00zNnhPaHZ2eVpZMmRSMlk1?= =?utf-8?B?K3NWQ2tCNHRNTXRsbzhrR29aSnNRbm1pNXNURUZQNXFXWDJpMTFGZFpIdUFB?= =?utf-8?B?YUQxMDQvOUxPTy9OTXhnalgyc2dVeWJaTmR1T0ViK2laRG84YlBnTEppM0hU?= =?utf-8?B?SndmQi95ZVRUZkxVYjBOVWYyb1dkcUZWRXBqT1QrSXk0NSs0S0xtR29aaVo4?= =?utf-8?B?UWNyaDduUkhzK1hZc2c0cW8rVDdwWjdWZDIrS2M4QTV0UldRQ1NLb29hT1Ry?= =?utf-8?B?akhtU1ovSDZXVEhvZnBkMjVHSS9LdXllZm9ZcGkxOGdnZG55SzBQa3BOZ2Rx?= =?utf-8?B?SitmcHVTbzNUdjN4eGZXUEdtL21HNkhpQ1NDL1hTN3Z5RHZjbDBicTRxS080?= =?utf-8?B?OTc4cmlRTzlrU1Y2R1U0LzhMdG9udnYzVTF1eU5LYnpldEhHZUdVV1JIS0RQ?= =?utf-8?B?QzJ0RTFTTURHeDJ1MEJMK3hjeXN2TU10ZDArKzZVR1hQdnhMMGhqRzRKZysr?= =?utf-8?B?K2pRYWxjbE5jKy9jUS9IUWxINy9kc05iZmFWanJMLzdTZSsxV01xVGxaa0cw?= =?utf-8?B?UExiT0F2dXJ1NVZFRENMbVBNL1BPVnFiQ0ZWbHZHSzJLOTJGZ0gxdUlvV2x3?= =?utf-8?B?NnFPSUtDZy9pdGhJSUZRbkN2c3lrOXVXY2dUMVV1UVc2MWhmU002cmxBRmdV?= =?utf-8?B?aGVlS0lTMmNiSzBHS0FnZ3I4eUFaRHhtOXF6WjVnam5zOEpPaVo0ZHBsc2FN?= =?utf-8?B?MVlhQk11b1MwdXZTOHFwL3g1TmN2T0pXQ01sbjRxeEJMYW1wWGVVUlFQTU4y?= =?utf-8?B?WXpJbEhQWTNoM2xUOFRXeWxLVlVhTkZueVFNQmtxcml2Z3AwZFpVWDVQKzhV?= =?utf-8?B?QlRnYTR3dzB5KzdkQ1RvSEpxMzJmb1pNMGQwRTZMTjZwd0NoR1BTTFgwSU9p?= =?utf-8?B?a29MTG9aVU5HZUNkSkp0SENrMUVNVzFrWDRUWVhDSUVTRzhsSG9FY1U2ZlVR?= =?utf-8?B?UjZXekhSTjcvblJSTXVhTVJjbk1haUhDSGpOVFVCeUpOYVovTVZuSGZVa1Y5?= =?utf-8?B?RTNwRXM5SjJ6VTFuRmd1Q2dPS2owOWoxWktteUZXTFVFaW9KajhBbEhUODVG?= =?utf-8?B?MG0wZDdFb1BlTVNHN0g0bjBxMkpwZExLMXZMY3pTa2FiamtZMWdnNzlLTmpm?= =?utf-8?B?aVFmTnlmTGd0VURsOUZmZ2tLQStQTGlSZVFmVFhCM2RYSndQUmpvclNKV05L?= =?utf-8?B?SHA4d0FSdDRsanNpWWo3L0RZTjBlTEE5dnYrUnNqaHY0YVljeTd4cEUvRTVa?= =?utf-8?B?U0pGbVVSVmJBNlhqdzRaWFQwU2JoekN1N1ZIcUZSUDBMRkRuRzlyb3hlYSt4?= =?utf-8?B?UXg2WUhqTnFYMHVpazliQlJGTkJ5bG10WHoxalVibXhRcVpjb0c0LzRENGh5?= =?utf-8?B?YlkrL0tJVnZMS2VQTHN1Zi9iVW1zT2pSeG5lbzJlZGZJam1NSTRaNVN3bTNh?= =?utf-8?B?eC9lQ1FOZUNqVVZrNGEzRjlRWStQLzQ4bzdGWmg3SDRXK3pzUHF1b3dGamRH?= =?utf-8?B?UVp5T01EMUVOa0g3NzFndz09?= X-Microsoft-Exchange-Diagnostics: 1;CO2PR03MB2264;6:c5YUhLW/dEX49+35JobEfslaiOF4xOkFgE1c9wHoDYseuAAtLftumJYdJH9LL9Ta94S6RBlmzITFpC/segtm91UW1uZbhXCF1+ZczvkEJfqBUZiXV8TL0+BqtUs/B427oWvzsMalue0yWHbPjI5YNoRqMBKsn4cFwdON7/KOUlk6/j3UPJ088guI24n9JN3loqLuFHd6OaWU930iIcDNIpN7Q5oawpI8EfGnHDg2IBgsqEowTratRBi/sRUOfJk4xTXnUPyumt8FDFSKEP48zZZPI8KGRPgP/HiS3EAhDH9z5LUHCmdTd+z3SkCA2+WKzNPR9TruEHFmxqAovE01uw==;5:VIm5ZZKKyT91aDenjs3tIwIImGEyewd1iweTf6SkmRvXkRWITrqzAXCZ48+rK/VzlNGm0rhoPiR4W9pocdTS4AkuG5mosh27Hm2zkmAyeg6IxSL2LBIf8o3vgMVBnis/nCZQpyobbk4er1HmGBxRrA==;24:gbXIVTizYEUTMeg3lA/pAILn5J73Bfn9wAtrU4FTV0Cp0EuMYCK1lrJRYV9M+g4WI1rXqWxJXuT68a1cvqnxrSTm6B5jtbh+be5SHs9buxg=;7:giRywQi+6DGddNN8ChgV3qD3+dDVjaEbwC2/oRB7zV5++1OhNJxfm6TNwYqaZGXiyhDjVDlxv1vATiJxzINWQ8WUQRqi2XfnJSQPKI+dW89XowCNC0yKOAoXzsK5pbdK+8b5JblOpYPDRRuxPmnOnJb2SPU8xhnibz5tHYkSmRAJ/1gGFFzysu2dAbrXSV1+ELO6Z21Vf8r8m6WzKEZ/TvFQ9szYhum4EhALFD/+15g= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2017 09:42:51.5555 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2264 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-08-16 at 12:04 +0530, Viresh Kumar wrote: > On 28-07-17, 10:58, Viresh Kumar wrote: > > > > At this point I really feel that this is a hardware specific problem > > and it was working by chance until now. And I am not sure if we > > shouldn't be stopping this patch from getting merged just because of > > that. > > > > At least you can teach your distribution to go increase the sampling > > rate from userspace to make it all work. > Its been 3 weeks since my last email on this thread and no reply yet > from any of the IMX maintainers. Can someone please help here ? > > @Shawn: Can you help debugging a bit here, to see what's get screwed > up due to this commit ? Its just that your platform isn't able to > change freq at 10 ms rate. > > @Rafael: I am not sure, but should we be stopping this patch because > some hardware isn't able to change freq at 10ms interval and is just > faking the transition delay to start with ? > > Maybe we get this merged again and the IMX guys can figure out what's > wrong on their platform and how to fix it ? I reported the initial issue but did not have the time to do a more thorough investigation, this is more complicated than it seems. I said this before but maybe it got lost: I don't think the odd behavior I noticed justifies keeping the patch from merging. -- Regards, Leonrd