diff for duplicates of <1502884362.2586.32.camel@synopsys.com> diff --git a/a/1.txt b/N1/1.txt index 36d5123..7172e41 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,16 +1,16 @@ Hi Rob, -On Tue, 2017-08-15@14:26 -0500, Rob Herring wrote: +On Tue, 2017-08-15 at 14:26 -0500, Rob Herring wrote: > On Tue, Aug 15, 2017 at 12:21 PM, Eugeniy Paltsev > <Eugeniy.Paltsev@synopsys.com> wrote: > > [snip] > > @@ -282,7 +283,15 @@ int __init of_setup_earlycon(const struct > > earlycon_id *match, -> >?????????????????} -> >?????????} -> >? -> > +???????val = of_get_flat_dt_prop(node, "baud", NULL); ->? +> > } +> > } +> > +> > + val = of_get_flat_dt_prop(node, "baud", NULL); +> > No, we already have a defined way to set the baud, we don't need a > property in addition. Plus you didn't document it. @@ -22,23 +22,23 @@ The idea was to reuse "baud" property from serial node to set the earlycon baud: chosen { -????... -????stdout-path = &serial; + ... + stdout-path = &serial; }; -serial: uart at ... { -????... -????baud = <115200>; /* Get baud from here */ +serial: uart@... { + ... + baud = <115200>; /* Get baud from here */ }; -> > +???????if (val) -> > +???????????????early_console_dev.baud = be32_to_cpu(*val); +> > + if (val) +> > + early_console_dev.baud = be32_to_cpu(*val); > > + -> >?????????if (options) { -> > +???????????????err = kstrtoul(options, 10, &baud); -> > +???????????????if (!err) -> > +???????????????????????early_console_dev.baud = baud; ->? +> > if (options) { +> > + err = kstrtoul(options, 10, &baud); +> > + if (!err) +> > + early_console_dev.baud = baud; +> > This seems fine to do here, but then we should also parse the other > standard options here too. And we should make sure we're not doing it > twice. @@ -49,14 +49,14 @@ called from register_earlycon) But I can add other standard options parsing here (probably using -uart_parse_options + uart_set_options).? +uart_parse_options + uart_set_options). What do you think? > > + -> >?????????????????strlcpy(early_console_dev.options, options, -> >?????????????????????????sizeof(early_console_dev.options)); -> >?????????} +> > strlcpy(early_console_dev.options, options, +> > sizeof(early_console_dev.options)); +> > } > > -- > > 2.9.3 ---? -?Eugeniy Paltsev +-- + Eugeniy Paltsev diff --git a/a/content_digest b/N1/content_digest index 3f7d77b..f55deb9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,24 +1,30 @@ "ref\020170815172141.29115-1-Eugeniy.Paltsev@synopsys.com\0" "ref\0CAL_Jsq+=LQ0kXtBx7xXJEb0FtfqwQRZoUYtG0oDFnUj_VfoG1A@mail.gmail.com\0" - "From\0Eugeniy.Paltsev@synopsys.com (Eugeniy Paltsev)\0" - "Subject\0[PATCH] earlycon: initialise baud field of earlycon device structure\0" + "From\0Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>\0" + "Subject\0Re: [PATCH] earlycon: initialise baud field of earlycon device structure\0" "Date\0Wed, 16 Aug 2017 11:52:42 +0000\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0robherring2@gmail.com <robherring2@gmail.com>\0" + "Cc\0linux-serial@vger.kernel.org <linux-serial@vger.kernel.org>" + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + jslaby@suse.com <jslaby@suse.com> + Eugeniy.Paltsev@synopsys.com <Eugeniy.Paltsev@synopsys.com> + gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> + " linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org>\0" "\00:1\0" "b\0" "Hi Rob,\n" "\n" - "On Tue, 2017-08-15@14:26 -0500, Rob Herring wrote:\n" + "On Tue, 2017-08-15 at 14:26 -0500, Rob Herring wrote:\n" "> On Tue, Aug 15, 2017 at 12:21 PM, Eugeniy Paltsev\n" "> <Eugeniy.Paltsev@synopsys.com> wrote:\n" "> > [snip]\n" "> > @@ -282,7 +283,15 @@ int __init of_setup_earlycon(const struct\n" "> > earlycon_id *match,\n" - "> >?????????????????}\n" - "> >?????????}\n" - "> >?\n" - "> > +???????val = of_get_flat_dt_prop(node, \"baud\", NULL);\n" - ">?\n" + "> >\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" + "> >\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" + "> >\302\240\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240val = of_get_flat_dt_prop(node, \"baud\", NULL);\n" + ">\302\240\n" "> No, we already have a defined way to set the baud, we don't need a\n" "> property in addition. Plus you didn't document it.\n" "\n" @@ -30,23 +36,23 @@ "earlycon baud:\n" "\n" "chosen {\n" - "????...\n" - "????stdout-path = &serial;\n" + "\302\240\302\240\302\240\302\240...\n" + "\302\240\302\240\302\240\302\240stdout-path = &serial;\n" "};\n" "\n" - "serial: uart at ... {\n" - "????...\n" - "????baud = <115200>; /* Get baud from here */\n" + "serial: uart@... {\n" + "\302\240\302\240\302\240\302\240...\n" + "\302\240\302\240\302\240\302\240baud = <115200>; /* Get baud from here */\n" "};\n" "\n" - "> > +???????if (val)\n" - "> > +???????????????early_console_dev.baud = be32_to_cpu(*val);\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (val)\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240early_console_dev.baud = be32_to_cpu(*val);\n" "> > +\n" - "> >?????????if (options) {\n" - "> > +???????????????err = kstrtoul(options, 10, &baud);\n" - "> > +???????????????if (!err)\n" - "> > +???????????????????????early_console_dev.baud = baud;\n" - ">?\n" + "> >\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (options) {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240err = kstrtoul(options, 10, &baud);\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (!err)\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240early_console_dev.baud = baud;\n" + ">\302\240\n" "> This seems fine to do here, but then we should also parse the other\n" "> standard options here too. And we should make sure we're not doing it\n" "> twice.\n" @@ -57,16 +63,16 @@ "from register_earlycon)\n" "\n" "But I can add other standard options parsing here (probably using\n" - "uart_parse_options + uart_set_options).?\n" + "uart_parse_options + uart_set_options).\302\240\n" "What do you think?\n" "\n" "> > +\n" - "> >?????????????????strlcpy(early_console_dev.options, options,\n" - "> >?????????????????????????sizeof(early_console_dev.options));\n" - "> >?????????}\n" + "> >\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240strlcpy(early_console_dev.options, options,\n" + "> >\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240sizeof(early_console_dev.options));\n" + "> >\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" "> > --\n" "> > 2.9.3\n" - "--?\n" - ?Eugeniy Paltsev + "--\302\240\n" + "\302\240Eugeniy Paltsev" -d4000daa573480689707b0e7511ecd20f64da46559e3f944acd266ca40ef3bed +cf15ad2569745af30c054744d5dd8db816ba58e9c0731131bbfcf8129796ea88
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.