From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeniy.Paltsev@synopsys.com (Eugeniy Paltsev) Date: Wed, 16 Aug 2017 12:52:01 +0000 Subject: [PATCH v3 3/5] reset: stm32: use the reset-simple driver In-Reply-To: <20170816094701.30678-4-p.zabel@pengutronix.de> References: <20170816094701.30678-1-p.zabel@pengutronix.de> <20170816094701.30678-4-p.zabel@pengutronix.de> Message-ID: <1502887920.2586.35.camel@synopsys.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Philipp, On Wed, 2017-08-16 at 11:46 +0200, Philipp Zabel wrote: > The reset-simple driver can be used without changes. > > Signed-off-by: Philipp Zabel > [snip] > > --- a/drivers/reset/reset-simple.c > +++ b/drivers/reset/reset-simple.c > @@ -120,6 +120,7 @@ static const struct reset_simple_devdata > reset_simple_active_low = { > ? > ?static const struct of_device_id reset_simple_dt_ids[] = { > ? { .compatible = "altr,rst-mgr", .data = > &reset_simple_socfpga }, > + { .compatible = "st,stm32-rcc", }, > ? { .compatible = "allwinner,sun6i-a31-clock-reset", > ? .data = &reset_simple_active_low }, > ? { /* sentinel */ }, What about adding generic compatible strings for future use? I mean next: --------------------->8--------------------- static const struct of_device_id reset_simple_dt_ids[] = { { .compatible = "reset-simple-active-low", .data = &reset_simple_active_low }, { .compatible = "reset-simple-active-high", .data = &reset_simple_active_high }, /* ... */ { /* sentinel */ }, }; static const struct reset_simple_devdata reset_simple_active_high = { .active_low = false, }; static const struct reset_simple_devdata reset_simple_active_low = { .active_low = true, }; --------------------->8--------------------- -- ?Eugeniy Paltsev From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752113AbdHPMwJ (ORCPT ); Wed, 16 Aug 2017 08:52:09 -0400 Received: from smtprelay4.synopsys.com ([198.182.47.9]:46970 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751640AbdHPMwG (ORCPT ); Wed, 16 Aug 2017 08:52:06 -0400 From: Eugeniy Paltsev To: "p.zabel@pengutronix.de" CC: "linux-kernel@vger.kernel.org" , "alex.g@adaptrum.com" , "Eugeniy.Paltsev@synopsys.com" , "andre.przywara@arm.com" , "s.trumtrar@pengutronix.de" , "wens@csie.org" , "baoyou.xie@linaro.org" , "mcoquelin.stm32@gmail.com" , "dinguyen@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "alexandre.torgue@st.com" , "afaerber@suse.de" , "maxime.ripard@free-electrons.com" , "kernel@pengutronix.de" Subject: Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver Thread-Topic: [PATCH v3 3/5] reset: stm32: use the reset-simple driver Thread-Index: AQHTFnSzTmCsg40E+0m20G0KCGiLI6KGznYA Date: Wed, 16 Aug 2017 12:52:01 +0000 Message-ID: <1502887920.2586.35.camel@synopsys.com> References: <20170816094701.30678-1-p.zabel@pengutronix.de> <20170816094701.30678-4-p.zabel@pengutronix.de> In-Reply-To: <20170816094701.30678-4-p.zabel@pengutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.106] Content-Type: text/plain; charset="utf-8" Content-ID: <6EC7C9D403392646A3FAEA6B14F7A8E5@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7GCqFmr013382 Hi Philipp, On Wed, 2017-08-16 at 11:46 +0200, Philipp Zabel wrote: > The reset-simple driver can be used without changes. > > Signed-off-by: Philipp Zabel > [snip] > > --- a/drivers/reset/reset-simple.c > +++ b/drivers/reset/reset-simple.c > @@ -120,6 +120,7 @@ static const struct reset_simple_devdata > reset_simple_active_low = { >   >  static const struct of_device_id reset_simple_dt_ids[] = { >   { .compatible = "altr,rst-mgr", .data = > &reset_simple_socfpga }, > + { .compatible = "st,stm32-rcc", }, >   { .compatible = "allwinner,sun6i-a31-clock-reset", >   .data = &reset_simple_active_low }, >   { /* sentinel */ }, What about adding generic compatible strings for future use? I mean next: --------------------->8--------------------- static const struct of_device_id reset_simple_dt_ids[] = { { .compatible = "reset-simple-active-low", .data = &reset_simple_active_low }, { .compatible = "reset-simple-active-high", .data = &reset_simple_active_high }, /* ... */ { /* sentinel */ }, }; static const struct reset_simple_devdata reset_simple_active_high = { .active_low = false, }; static const struct reset_simple_devdata reset_simple_active_low = { .active_low = true, }; --------------------->8--------------------- --  Eugeniy Paltsev