diff for duplicates of <1502897189.2586.37.camel@synopsys.com> diff --git a/a/1.txt b/N1/1.txt index 57c2212..9fcc0ab 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,18 +1,18 @@ -On Wed, 2017-08-16@08:46 -0500, Rob Herring wrote: +On Wed, 2017-08-16 at 08:46 -0500, Rob Herring wrote: > On Wed, Aug 16, 2017 at 6:52 AM, Eugeniy Paltsev > <Eugeniy.Paltsev@synopsys.com> wrote: > > Hi Rob, > > -> > On Tue, 2017-08-15@14:26 -0500, Rob Herring wrote: +> > On Tue, 2017-08-15 at 14:26 -0500, Rob Herring wrote: > > > On Tue, Aug 15, 2017 at 12:21 PM, Eugeniy Paltsev > > > <Eugeniy.Paltsev@synopsys.com> wrote: > > > > [snip] > > > > @@ -282,7 +283,15 @@ int __init of_setup_earlycon(const struct > > > > earlycon_id *match, -> > > > ????????????????} -> > > > ????????} +> > > > } +> > > > } > > > > -> > > > +???????val = of_get_flat_dt_prop(node, "baud", NULL); +> > > > + val = of_get_flat_dt_prop(node, "baud", NULL); > > > > > > No, we already have a defined way to set the baud, we don't need > > > a @@ -27,13 +27,13 @@ On Wed, 2017-08-16@08:46 -0500, Rob Herring wrote: > > earlycon baud: > > > > chosen { -> > ????... -> > ????stdout-path = &serial; +> > ... +> > stdout-path = &serial; > > }; > > -> > serial: uart at ... { -> > ????... -> > ????baud = <115200>;???/* Get baud from here */ +> > serial: uart@... { +> > ... +> > baud = <115200>; /* Get baud from here */ > > "current-speed" is already defined for this purpose. If you want to > add that, that's fine. @@ -41,13 +41,13 @@ Ok, I'll add "current-speed". > > }; > > -> > > > +???????if (val) -> > > > +???????????????early_console_dev.baud = be32_to_cpu(*val); +> > > > + if (val) +> > > > + early_console_dev.baud = be32_to_cpu(*val); > > > > + -> > > > ????????if (options) { -> > > > +???????????????err = kstrtoul(options, 10, &baud); -> > > > +???????????????if (!err) -> > > > +???????????????????????early_console_dev.baud = baud; +> > > > if (options) { +> > > > + err = kstrtoul(options, 10, &baud); +> > > > + if (!err) +> > > > + early_console_dev.baud = baud; > > > > > > This seems fine to do here, but then we should also parse the > > > other @@ -75,4 +75,4 @@ Should I also add standard options parsing to register_earlycon? > Rob -- -?Eugeniy Paltsev + Eugeniy Paltsev diff --git a/a/content_digest b/N1/content_digest index 8cb2f1f..0b122f3 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,27 +2,33 @@ "ref\0CAL_Jsq+=LQ0kXtBx7xXJEb0FtfqwQRZoUYtG0oDFnUj_VfoG1A@mail.gmail.com\0" "ref\01502884362.2586.32.camel@synopsys.com\0" "ref\0CAL_JsqJaK=xgrzecf3PnPuNSzsnzdvuJ9NZ4uzs4u9Oc77sV2A@mail.gmail.com\0" - "From\0Eugeniy.Paltsev@synopsys.com (Eugeniy Paltsev)\0" - "Subject\0[PATCH] earlycon: initialise baud field of earlycon device structure\0" + "From\0Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>\0" + "Subject\0Re: [PATCH] earlycon: initialise baud field of earlycon device structure\0" "Date\0Wed, 16 Aug 2017 15:26:30 +0000\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0robherring2@gmail.com <robherring2@gmail.com>\0" + "Cc\0linux-serial@vger.kernel.org <linux-serial@vger.kernel.org>" + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + jslaby@suse.com <jslaby@suse.com> + Eugeniy.Paltsev@synopsys.com <Eugeniy.Paltsev@synopsys.com> + gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> + " linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org>\0" "\00:1\0" "b\0" - "On Wed, 2017-08-16@08:46 -0500, Rob Herring wrote:\n" + "On Wed, 2017-08-16 at 08:46 -0500, Rob Herring wrote:\n" "> On Wed, Aug 16, 2017 at 6:52 AM, Eugeniy Paltsev\n" "> <Eugeniy.Paltsev@synopsys.com> wrote:\n" "> > Hi Rob,\n" "> > \n" - "> > On Tue, 2017-08-15@14:26 -0500, Rob Herring wrote:\n" + "> > On Tue, 2017-08-15 at 14:26 -0500, Rob Herring wrote:\n" "> > > On Tue, Aug 15, 2017 at 12:21 PM, Eugeniy Paltsev\n" "> > > <Eugeniy.Paltsev@synopsys.com> wrote:\n" "> > > > [snip]\n" "> > > > @@ -282,7 +283,15 @@ int __init of_setup_earlycon(const struct\n" "> > > > earlycon_id *match,\n" - "> > > > ????????????????}\n" - "> > > > ????????}\n" + "> > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" + "> > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" "> > > > \n" - "> > > > +???????val = of_get_flat_dt_prop(node, \"baud\", NULL);\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240val = of_get_flat_dt_prop(node, \"baud\", NULL);\n" "> > > \n" "> > > No, we already have a defined way to set the baud, we don't need\n" "> > > a\n" @@ -37,13 +43,13 @@ "> > earlycon baud:\n" "> > \n" "> > chosen {\n" - "> > ????...\n" - "> > ????stdout-path = &serial;\n" + "> > \302\240\302\240\302\240\302\240...\n" + "> > \302\240\302\240\302\240\302\240stdout-path = &serial;\n" "> > };\n" "> > \n" - "> > serial: uart at ... {\n" - "> > ????...\n" - "> > ????baud = <115200>;???/* Get baud from here */\n" + "> > serial: uart@... {\n" + "> > \302\240\302\240\302\240\302\240...\n" + "> > \302\240\302\240\302\240\302\240baud = <115200>;\302\240\302\240\302\240/* Get baud from here */\n" "> \n" "> \"current-speed\" is already defined for this purpose. If you want to\n" "> add that, that's fine.\n" @@ -51,13 +57,13 @@ "\n" "> > };\n" "> > \n" - "> > > > +???????if (val)\n" - "> > > > +???????????????early_console_dev.baud = be32_to_cpu(*val);\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (val)\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240early_console_dev.baud = be32_to_cpu(*val);\n" "> > > > +\n" - "> > > > ????????if (options) {\n" - "> > > > +???????????????err = kstrtoul(options, 10, &baud);\n" - "> > > > +???????????????if (!err)\n" - "> > > > +???????????????????????early_console_dev.baud = baud;\n" + "> > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (options) {\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240err = kstrtoul(options, 10, &baud);\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (!err)\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240early_console_dev.baud = baud;\n" "> > > \n" "> > > This seems fine to do here, but then we should also parse the\n" "> > > other\n" @@ -85,6 +91,6 @@ "\n" "> Rob\n" "-- \n" - ?Eugeniy Paltsev + "\302\240Eugeniy Paltsev" -4d3f42d0f8f4695d51c2389f082ba69cfc6deb15097c324bdc8036e66bb06ca3 +ac074f243eea25a79989e2816e0de3ccb7f5d4c94b652839fd86fc3920e5b174
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.