From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Shiraz Saleem <shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] IB/core: Protect sysfs entry on ib_unregister_device
Date: Wed, 16 Aug 2017 11:48:42 -0400 [thread overview]
Message-ID: <1502898522.33760.14.camel@redhat.com> (raw)
In-Reply-To: <20170717190350.17360-1-shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Mon, 2017-07-17 at 14:03 -0500, Shiraz Saleem wrote:
> ib_unregister_device is not protecting removal of sysfs entries.
> A call to ib_register_device in that window can result in
> duplicate sysfs entry warning. Move mutex_unlock to after
> ib_device_unregister_sysfs to protect against sysfs entry creation.
>
> This issue is exposed during driver load/unload stress test.
>
> WARNING: CPU: 5 PID: 4445 at fs/sysfs/dir.c:31
> sysfs_warn_dup+0x5f/0x70
> sysfs: cannot create duplicate filename '/class/infiniband/i40iw0'
> Hardware name: Gigabyte Technology Co., Ltd. To be filled by
> O.E.M./Q87M-D2H
> BIOS F7 01/17/2014
> Workqueue: i40e i40e_service_task [i40e]
> Call Trace:
> dump_stack+0x67/0x98
> __warn+0xcc/0xf0
> warn_slowpath_fmt+0x4a/0x50
> ? kernfs_path_from_node+0x4b/0x60
> sysfs_warn_dup+0x5f/0x70
> sysfs_do_create_link_sd.isra.2+0xb7/0xc0
> sysfs_create_link+0x20/0x40
> device_add+0x28c/0x600
> ib_device_register_sysfs+0x58/0x170 [ib_core]
> ib_register_device+0x325/0x570 [ib_core]
> ? i40iw_register_rdma_device+0x1f4/0x400 [i40iw]
> ? kmem_cache_alloc_trace+0x143/0x330
> ? __raw_spin_lock_init+0x2d/0x50
> i40iw_register_rdma_device+0x2dc/0x400 [i40iw]
> i40iw_open+0x10a6/0x1950 [i40iw]
> ? i40iw_open+0xeab/0x1950 [i40iw]
> ? i40iw_make_cm_node+0x9c0/0x9c0 [i40iw]
> i40e_client_subtask+0xa4/0x110 [i40e]
> i40e_service_task+0xc2d/0x1320 [i40e]
> process_one_work+0x203/0x710
> ? process_one_work+0x16f/0x710
> worker_thread+0x126/0x4a0
> ? trace_hardirqs_on+0xd/0x10
> kthread+0x112/0x150
> ? process_one_work+0x710/0x710
> ? kthread_create_on_node+0x40/0x40
> ret_from_fork+0x2e/0x40
> ---[ end trace fd11b69e21ea7653 ]---
> Couldn't register device i40iw0 with driver model
>
> Signed-off-by: Shiraz Saleem <shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Sindhu Devale <sindhu.devale-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
This got missed for my previous pull request, sorry about that.
Applied for this one.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-08-16 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 19:03 [PATCH] IB/core: Protect sysfs entry on ib_unregister_device Shiraz Saleem
[not found] ` <20170717190350.17360-1-shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-08-16 15:48 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502898522.33760.14.camel@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.