From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "jthumshirn@suse.de" <jthumshirn@suse.de>,
"hch@lst.de" <hch@lst.de>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"brking@linux.vnet.ibm.com" <brking@linux.vnet.ibm.com>,
"abdhalee@linux.vnet.ibm.com" <abdhalee@linux.vnet.ibm.com>,
"hare@suse.com" <hare@suse.com>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>
Subject: Re: [PATCH] Revert "scsi-mq: Always unprepare before requeuing a request"
Date: Thu, 17 Aug 2017 01:29:13 +0000 [thread overview]
Message-ID: <1502933351.14158.3.camel@wdc.com> (raw)
In-Reply-To: <yq18tijow0o.fsf@oracle.com>
On Wed, 2017-08-16 at 20:52 -0400, Martin K. Petersen wrote:
> Damien,
>
> > Actually, we can keep that commit as it makes the sq case cleaner
> > anyway. But we need something else to prevent deadlock in the mq
> > case...
>
> OK, put it back.
>
> Please send a lockout patch. We can always zap it if we find out what
> went wrong with Bart's patch and queue a "real" fix.
Hello Martin,
I'm 99% sure there is nothing wrong with my patch but that my patch uncovered
a bug in the ipr driver (drivers/scsi/ipr). See also "WARNING: CPU: 15 PID: 0
at block/blk-mq.c:1111 __blk_mq_run_hw_queue+0x1d8/0x1f0F"
(https://marc.info/?l=linux-block&m=150290686719644).
Bart.
next prev parent reply other threads:[~2017-08-17 1:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 17:43 [PATCH] Revert "scsi-mq: Always unprepare before requeuing a request" Bart Van Assche
2017-08-17 0:11 ` Martin K. Petersen
2017-08-17 0:41 ` Damien Le Moal
2017-08-17 0:45 ` Damien Le Moal
2017-08-17 0:52 ` Martin K. Petersen
2017-08-17 1:29 ` Bart Van Assche [this message]
2017-08-17 2:00 ` Martin K. Petersen
2017-08-17 2:00 ` Martin K. Petersen
2017-08-17 2:41 ` Bart Van Assche
2017-08-17 2:51 ` Martin K. Petersen
2017-08-17 2:51 ` Martin K. Petersen
2017-08-17 15:29 ` Bart Van Assche
2017-08-17 16:45 ` Martin K. Petersen
2017-08-17 16:45 ` Martin K. Petersen
2017-08-17 17:40 ` Brian King
2017-08-17 17:48 ` Martin K. Petersen
2017-08-17 17:48 ` Martin K. Petersen
2017-08-18 12:06 ` Michael Ellerman
2017-08-18 12:06 ` Michael Ellerman
2017-08-17 0:46 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502933351.14158.3.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=abdhalee@linux.vnet.ibm.com \
--cc=brking@linux.vnet.ibm.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.