From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gaetan Rivet Subject: [PATCH] net/failsafe: safer subdev iterator Date: Thu, 17 Aug 2017 17:52:09 +0200 Message-ID: <1502985129-7461-1-git-send-email-gaetan.rivet@6wind.com> Cc: Gaetan Rivet To: dev@dpdk.org Return-path: Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id 17997915D for ; Thu, 17 Aug 2017 17:52:25 +0200 (CEST) Received: by mail-wr0-f177.google.com with SMTP id f8so2976948wrf.3 for ; Thu, 17 Aug 2017 08:52:25 -0700 (PDT) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The sub_device iterator macro should follow the general gist of the tailq API for an easier understanding and safer use. Once the loop has finished, the iterator should be set to NULL. If no sub_device was iterated upon, the iterator should still be NULL. Signed-off-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_private.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h index 0361cf4..6fa8de5 100644 --- a/drivers/net/failsafe/failsafe_private.h +++ b/drivers/net/failsafe/failsafe_private.h @@ -222,6 +222,7 @@ extern int mac_from_arg; */ #define FOREACH_SUBDEV_STATE(s, i, dev, state) \ for (i = fs_find_next((dev), 0, state); \ + ((s = NULL) == NULL) && \ i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]); \ i = fs_find_next((dev), i + 1, state)) -- 2.1.4