From: Mike Galbraith <efault@gmx.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [patch-rt] hotplug, hrtimer: Migrate expired/deferred timers during cpu offline
Date: Thu, 17 Aug 2017 20:43:37 +0200 [thread overview]
Message-ID: <1502995417.16063.0.camel@gmx.de> (raw)
In-Reply-To: <20170817171720.jz2ok332bpxcjzme@linutronix.de>
On Thu, 2017-08-17 at 19:17 +0200, Sebastian Andrzej Siewior wrote:
> On 2017-08-17 18:50:42 [+0200], To Mike Galbraith wrote:
> > __remove_hrtimer() shouldn't be required because it has been done
> > already. It should be enough to just list_splice() one list to the
> > other and raise the softirq afterwards.
>
> Mike, can you check this please:
Done, works.
> diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
> index 55839ff2bba6..4b9264e0d363 100644
> --- a/kernel/time/hrtimer.c
> +++ b/kernel/time/hrtimer.c
> @@ -1802,6 +1802,11 @@ static void migrate_hrtimer_list(struct hrtimer_clock_base *old_base,
> */
> enqueue_hrtimer(timer, new_base);
> }
> +#ifdef CONFIG_PREEMPT_RT_BASE
> + list_splice_tail(&old_base->expired, &new_base->expired);
> + if (!list_empty(&new_base->expired))
> + raise_softirq_irqoff(HRTIMER_SOFTIRQ);
> +#endif
> }
>
> int hrtimers_dead_cpu(unsigned int scpu)
next prev parent reply other threads:[~2017-08-17 18:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 17:38 [ANNOUNCE] v4.11.12-rt9 Sebastian Andrzej Siewior
2017-08-05 6:13 ` Mike Galbraith
2017-08-05 6:13 ` Mike Galbraith
2017-08-05 14:57 ` Mike Galbraith
2017-08-07 7:33 ` Sebastian Andrzej Siewior
2017-08-07 8:22 ` Mike Galbraith
2017-08-08 10:00 ` Mike Galbraith
2017-08-11 7:55 ` [patch-rt] hotplug, hrtimer: Migrate expired/deferred timers during cpu offline Mike Galbraith
2017-08-11 8:15 ` Mike Galbraith
2017-08-14 7:59 ` Mike Galbraith
2017-08-17 16:50 ` Sebastian Andrzej Siewior
2017-08-17 17:17 ` Sebastian Andrzej Siewior
2017-08-17 17:26 ` Mike Galbraith
2017-08-17 17:37 ` Mike Galbraith
2017-08-17 18:43 ` Mike Galbraith [this message]
2017-08-07 7:52 ` [ANNOUNCE] v4.11.12-rt9 Sebastian Andrzej Siewior
2017-08-07 8:38 ` Mike Galbraith
2017-08-09 12:04 ` [patch-rt] locking, rwlock-rt: do not save state multiple times in __write_rt_lock() Mike Galbraith
2017-08-18 9:06 ` Sebastian Andrzej Siewior
2017-08-07 9:10 ` [ANNOUNCE] v4.11.12-rt9 Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502995417.16063.0.camel@gmx.de \
--to=efault@gmx.de \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.