From: Martin Wilck <mwilck@suse.com>
To: dm-devel@redhat.com
Subject: Re: [PATCH 2/3] multipath-tools: libdmmp: Improve timeout mechanism
Date: Thu, 17 Aug 2017 23:29:56 +0200 [thread overview]
Message-ID: <1503005396.7232.11.camel@suse.com> (raw)
In-Reply-To: <20170816123409.16535-2-fge@redhat.com>
On Wed, 2017-08-16 at 20:34 +0800, Gris Ge wrote:
> Issue:
> libdmmp return error of timeout before user requested timeout was
> met.
> This happens when multipathd daemon is starting with a lot(1k+)
> mpaths.
>
> Root cause:
> The multipath has two timeout settings:
> 1. 'uxsock_timeout' in multipath.conf
> 2. libmpathcmd timeout argument.
> And the first is not controllable in current libdmmp code.
>
> Fix:
> * Only keep 1 timeout setting in libdmmp:
> dmmp_context_timeout_set()/dmmp_context_timeout_get().
> * libdmmp will keep reply until meet user requested timeout.
Maybe I'm missing something here, but if you just retry the timed-out
command, isn't it likely that you'll hit the uxsock_timeout again and
again?
Best,
Martin
--
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2017-08-17 21:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 12:34 [PATCH 1/3] multipath-tools: Remove the limitation of IPC command reply length Gris Ge
2017-08-16 12:34 ` [PATCH 2/3] multipath-tools: libdmmp: Improve timeout mechanism Gris Ge
2017-08-16 12:34 ` [PATCH 3/3] multipath-tools: libdmmp: New function to flush and reconfig Gris Ge
2017-08-17 21:29 ` Martin Wilck [this message]
2017-08-28 12:58 ` [PATCH 2/3] multipath-tools: libdmmp: Improve timeout mechanism Gris Ge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503005396.7232.11.camel@suse.com \
--to=mwilck@suse.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.