From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] db: Add --tag parameter to libtool invocation
Date: Fri, 18 Aug 2017 16:17:16 +0100 [thread overview]
Message-ID: <1503069436.32591.13.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAMKF1sqGPrBZ8ods47N3Vkt8jBECbhKEQpfeEDQh80L7MtLMyQ@mail.gmail.com>
On Fri, 2017-08-18 at 07:29 -0700, Khem Raj wrote:
> On Fri, Aug 18, 2017 at 2:52 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> >
> > On Tue, 2017-08-15 at 20:33 -0700, Khem Raj wrote:
> > >
> > > Fixes errors like
> > > libtool: compile: unable to infer tagged configuration
> > > libtool: compile: specify a tag with `--tag'
> > The patch seems to do a bit more than this?
> >
> Yes, now it can regenerate configure files like OE does normally.
> This
> change is needed
> for --tag param to work properly with libtool since it uses the cross
> libtool that is copies over from OE by do_configure in normal cases.
Can you update the commit message to mention that please?
I tend to get worried when patches do things in the commit which aren't
mentioned at all in the commit message!
Cheers,
Richard
prev parent reply other threads:[~2017-08-18 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 3:33 [PATCH] db: Add --tag parameter to libtool invocation Khem Raj
2017-08-18 9:52 ` Richard Purdie
2017-08-18 14:29 ` Khem Raj
2017-08-18 15:17 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503069436.32591.13.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.