All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Ledford <dledford@redhat.com>
To: Bjorn Helgaas <helgaas@kernel.org>, Greg KH <gregkh@linuxfoundation.org>
Cc: Faisal Latif <faisal.latif@intel.com>,
	Sean Hefty <sean.hefty@intel.com>,
	 Hal Rosenstock <hal.rosenstock@gmail.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: PCI/IB: add support for pci driver attribute groups
Date: Fri, 18 Aug 2017 11:44:26 -0400	[thread overview]
Message-ID: <1503071066.2598.15.camel@redhat.com> (raw)
In-Reply-To: <20170801214046.GB26498@bhelgaas-glaptop.roam.corp.google.com>

On Tue, 2017-08-01 at 16:40 -0500, Bjorn Helgaas wrote:
> On Wed, Jul 19, 2017 at 03:01:06PM +0200, Greg KH wrote:
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > 
> > Some drivers (specifically the nes IB driver), want to create a lot
> > of
> > sysfs driver attributes.  Instead of open-coding the creation and
> > removal of these files (and getting it wrong btw), it's a better
> > idea to
> > let the driver core handle all of this logic for us.
> > 
> > So add a new field to the pci driver structure, **groups, that
> > allows
> > pci drivers to specify an attribute group list it wishes to have
> > created
> > when it is registered with the driver core.
> > 
> > Big bonus is now the driver doesn't race with userspace when the
> > sysfs
> > files are created vs. when the kobject is announced, so any
> > script/tool
> > that actually wanted to use these files will not have to poll
> > waiting
> > for them to show up.
> > 
> > Cc: Faisal Latif <faisal.latif@intel.com>
> > Cc: Doug Ledford <dledford@redhat.com>
> > Cc: Sean Hefty <sean.hefty@intel.com>
> > Cc: Hal Rosenstock <hal.rosenstock@gmail.com>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> 
> If you want me to take this let me know; otherwise I'll assume Doug
> will
> merge it.

I've picked it up for for-next.  Thanks.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

      reply	other threads:[~2017-08-18 15:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-19 13:01 PCI/IB: add support for pci driver attribute groups Greg KH
2017-07-19 13:01 ` Greg KH
2017-07-19 15:22 ` Latif, Faisal
2017-08-01 21:40 ` Bjorn Helgaas
2017-08-18 15:44   ` Doug Ledford [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1503071066.2598.15.camel@redhat.com \
    --to=dledford@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=faisal.latif@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hal.rosenstock@gmail.com \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sean.hefty@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.