diff for duplicates of <1503071631.44656.4.camel@primarydata.com> diff --git a/a/1.txt b/N1/1.txt index 30d2973..7ed7943 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -24,4 +24,4 @@ dG9iaihzdHJ1Y3QgeGRyX3N0cmVhbSAqeGRyLA0KPiAgCV9fYmUzMiAqcDsNCj4gIA0KPiAgCXAg PSB4ZHJfaW5saW5lX2RlY29kZSh4ZHIsIDQpOw0KPiAtCWlmICh1bmxpa2VseShwID09IE5VTEwp KQ0KPiArCWlmICh1bmxpa2VseSghcCkpDQoNCk9oIFNUT1Agd2l0aCB0aGUgY2hlY2twYXRjaCB3 YW5rZmVzdCENCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRh -aW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg= +aW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg== diff --git a/a/content_digest b/N1/content_digest index cedac2c..ec9b679 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -41,6 +41,6 @@ "PSB4ZHJfaW5saW5lX2RlY29kZSh4ZHIsIDQpOw0KPiAtCWlmICh1bmxpa2VseShwID09IE5VTEwp\n" "KQ0KPiArCWlmICh1bmxpa2VseSghcCkpDQoNCk9oIFNUT1Agd2l0aCB0aGUgY2hlY2twYXRjaCB3\n" "YW5rZmVzdCENCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRh\n" - aW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg= + aW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg== -05a8b7cac31cced2a8a744c7cfa649adaf3f8f70ab1f04236636e870dc6ffcaf +2c404353ba42a42924f9e595bae3307966fdaac33f42a3044d78e70897595d04
diff --git a/a/1.txt b/N2/1.txt index 30d2973..a926026 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,27 +1,47 @@ -T24gVGh1LCAyMDE3LTA4LTE3IGF0IDE2OjM0ICswMjAwLCBTRiBNYXJrdXMgRWxmcmluZyB3cm90 -ZToNCj4gRnJvbTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0 -Pg0KPiBEYXRlOiBUaHUsIDE3IEF1ZyAyMDE3IDE2OjAwOjE4ICswMjAwDQo+IE1JTUUtVmVyc2lv -bjogMS4wDQo+IENvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOA0KPiBDb250 -ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0DQo+IA0KPiBUaGUgc2NyaXB0IOKAnGNoZWNrcGF0 -Y2gucGzigJ0gcG9pbnRlZCBpbmZvcm1hdGlvbiBvdXQgbGlrZSB0aGUNCj4gZm9sbG93aW5nLg0K -PiANCj4gQ29tcGFyaXNvbiB0byBOVUxMIGNvdWxkIGJlIHdyaXR0ZW4g4oCmDQo+IA0KPiBUaHVz -IGZpeCB0aGUgYWZmZWN0ZWQgc291cmNlIGNvZGUgcGxhY2VzLg0KPiANCj4gU2lnbmVkLW9mZi1i -eTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0Pg0KPiAtLS0N -Cj4gIGZzL2xvY2tkL2NsbnQ0eGRyLmMgfCAxMiArKysrKystLS0tLS0NCj4gIGZzL2xvY2tkL2Ns -bnRsb2NrLmMgfCAxMCArKysrKy0tLS0tDQo+ICBmcy9sb2NrZC9jbG50cHJvYy5jIHwgMTIgKysr -KysrLS0tLS0tDQo+ICBmcy9sb2NrZC9jbG50eGRyLmMgIHwgMTIgKysrKysrLS0tLS0tDQo+ICBm -cy9sb2NrZC9ob3N0LmMgICAgIHwgMjIgKysrKysrKysrKystLS0tLS0tLS0tLQ0KPiAgZnMvbG9j -a2QvbW9uLmMgICAgICB8IDE2ICsrKysrKysrLS0tLS0tLS0NCj4gIGZzL2xvY2tkL3N2Yy5jICAg -ICAgfCAgNCArKy0tDQo+ICBmcy9sb2NrZC9zdmM0cHJvYy5jIHwgIDYgKysrLS0tDQo+ICBmcy9s -b2NrZC9zdmNsb2NrLmMgIHwgMTQgKysrKysrKy0tLS0tLS0NCj4gIGZzL2xvY2tkL3N2Y3Byb2Mu -YyAgfCAgNiArKystLS0NCj4gIGZzL2xvY2tkL3N2Y3NoYXJlLmMgfCAgMiArLQ0KPiAgZnMvbG9j -a2Qvc3Zjc3Vicy5jICB8ICAzICstLQ0KPiAgMTIgZmlsZXMgY2hhbmdlZCwgNTkgaW5zZXJ0aW9u -cygrKSwgNjAgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZnMvbG9ja2QvY2xudDR4 -ZHIuYyBiL2ZzL2xvY2tkL2NsbnQ0eGRyLmMNCj4gaW5kZXggYzM0OWZjMGY5YjgwLi5lYzY0NzNk -MTk0ZmQgMTAwNjQ0DQo+IC0tLSBhL2ZzL2xvY2tkL2NsbnQ0eGRyLmMNCj4gKysrIGIvZnMvbG9j -a2QvY2xudDR4ZHIuYw0KPiBAQCAtMTMxLDcgKzEzMSw3IEBAIHN0YXRpYyBpbnQgZGVjb2RlX25l -dG9iaihzdHJ1Y3QgeGRyX3N0cmVhbSAqeGRyLA0KPiAgCV9fYmUzMiAqcDsNCj4gIA0KPiAgCXAg -PSB4ZHJfaW5saW5lX2RlY29kZSh4ZHIsIDQpOw0KPiAtCWlmICh1bmxpa2VseShwID09IE5VTEwp -KQ0KPiArCWlmICh1bmxpa2VseSghcCkpDQoNCk9oIFNUT1Agd2l0aCB0aGUgY2hlY2twYXRjaCB3 -YW5rZmVzdCENCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRh -aW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg= +On Thu, 2017-08-17 at 16:34 +0200, SF Markus Elfring wrote: +> From: Markus Elfring <elfring@users.sourceforge.net> +> Date: Thu, 17 Aug 2017 16:00:18 +0200 +> MIME-Version: 1.0 +> Content-Type: text/plain; charset=UTF-8 +> Content-Transfer-Encoding: 8bit +> +> The script “checkpatch.pl” pointed information out like the +> following. +> +> Comparison to NULL could be written … +> +> Thus fix the affected source code places. +> +> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> +> --- +> fs/lockd/clnt4xdr.c | 12 ++++++------ +> fs/lockd/clntlock.c | 10 +++++----- +> fs/lockd/clntproc.c | 12 ++++++------ +> fs/lockd/clntxdr.c | 12 ++++++------ +> fs/lockd/host.c | 22 +++++++++++----------- +> fs/lockd/mon.c | 16 ++++++++-------- +> fs/lockd/svc.c | 4 ++-- +> fs/lockd/svc4proc.c | 6 +++--- +> fs/lockd/svclock.c | 14 +++++++------- +> fs/lockd/svcproc.c | 6 +++--- +> fs/lockd/svcshare.c | 2 +- +> fs/lockd/svcsubs.c | 3 +-- +> 12 files changed, 59 insertions(+), 60 deletions(-) +> +> diff --git a/fs/lockd/clnt4xdr.c b/fs/lockd/clnt4xdr.c +> index c349fc0f9b80..ec6473d194fd 100644 +> --- a/fs/lockd/clnt4xdr.c +> +++ b/fs/lockd/clnt4xdr.c +> @@ -131,7 +131,7 @@ static int decode_netobj(struct xdr_stream *xdr, +> __be32 *p; +> +> p = xdr_inline_decode(xdr, 4); +> - if (unlikely(p == NULL)) +> + if (unlikely(!p)) + +Oh STOP with the checkpatch wankfest! + +-- +Trond Myklebust +Linux NFS client maintainer, PrimaryData +trond.myklebust@primarydata.com diff --git a/a/content_digest b/N2/content_digest index cedac2c..d067bbf 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -15,32 +15,52 @@ " kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gVGh1LCAyMDE3LTA4LTE3IGF0IDE2OjM0ICswMjAwLCBTRiBNYXJrdXMgRWxmcmluZyB3cm90\n" - "ZToNCj4gRnJvbTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0\n" - "Pg0KPiBEYXRlOiBUaHUsIDE3IEF1ZyAyMDE3IDE2OjAwOjE4ICswMjAwDQo+IE1JTUUtVmVyc2lv\n" - "bjogMS4wDQo+IENvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOA0KPiBDb250\n" - "ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0DQo+IA0KPiBUaGUgc2NyaXB0IOKAnGNoZWNrcGF0\n" - "Y2gucGzigJ0gcG9pbnRlZCBpbmZvcm1hdGlvbiBvdXQgbGlrZSB0aGUNCj4gZm9sbG93aW5nLg0K\n" - "PiANCj4gQ29tcGFyaXNvbiB0byBOVUxMIGNvdWxkIGJlIHdyaXR0ZW4g4oCmDQo+IA0KPiBUaHVz\n" - "IGZpeCB0aGUgYWZmZWN0ZWQgc291cmNlIGNvZGUgcGxhY2VzLg0KPiANCj4gU2lnbmVkLW9mZi1i\n" - "eTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0Pg0KPiAtLS0N\n" - "Cj4gIGZzL2xvY2tkL2NsbnQ0eGRyLmMgfCAxMiArKysrKystLS0tLS0NCj4gIGZzL2xvY2tkL2Ns\n" - "bnRsb2NrLmMgfCAxMCArKysrKy0tLS0tDQo+ICBmcy9sb2NrZC9jbG50cHJvYy5jIHwgMTIgKysr\n" - "KysrLS0tLS0tDQo+ICBmcy9sb2NrZC9jbG50eGRyLmMgIHwgMTIgKysrKysrLS0tLS0tDQo+ICBm\n" - "cy9sb2NrZC9ob3N0LmMgICAgIHwgMjIgKysrKysrKysrKystLS0tLS0tLS0tLQ0KPiAgZnMvbG9j\n" - "a2QvbW9uLmMgICAgICB8IDE2ICsrKysrKysrLS0tLS0tLS0NCj4gIGZzL2xvY2tkL3N2Yy5jICAg\n" - "ICAgfCAgNCArKy0tDQo+ICBmcy9sb2NrZC9zdmM0cHJvYy5jIHwgIDYgKysrLS0tDQo+ICBmcy9s\n" - "b2NrZC9zdmNsb2NrLmMgIHwgMTQgKysrKysrKy0tLS0tLS0NCj4gIGZzL2xvY2tkL3N2Y3Byb2Mu\n" - "YyAgfCAgNiArKystLS0NCj4gIGZzL2xvY2tkL3N2Y3NoYXJlLmMgfCAgMiArLQ0KPiAgZnMvbG9j\n" - "a2Qvc3Zjc3Vicy5jICB8ICAzICstLQ0KPiAgMTIgZmlsZXMgY2hhbmdlZCwgNTkgaW5zZXJ0aW9u\n" - "cygrKSwgNjAgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZnMvbG9ja2QvY2xudDR4\n" - "ZHIuYyBiL2ZzL2xvY2tkL2NsbnQ0eGRyLmMNCj4gaW5kZXggYzM0OWZjMGY5YjgwLi5lYzY0NzNk\n" - "MTk0ZmQgMTAwNjQ0DQo+IC0tLSBhL2ZzL2xvY2tkL2NsbnQ0eGRyLmMNCj4gKysrIGIvZnMvbG9j\n" - "a2QvY2xudDR4ZHIuYw0KPiBAQCAtMTMxLDcgKzEzMSw3IEBAIHN0YXRpYyBpbnQgZGVjb2RlX25l\n" - "dG9iaihzdHJ1Y3QgeGRyX3N0cmVhbSAqeGRyLA0KPiAgCV9fYmUzMiAqcDsNCj4gIA0KPiAgCXAg\n" - "PSB4ZHJfaW5saW5lX2RlY29kZSh4ZHIsIDQpOw0KPiAtCWlmICh1bmxpa2VseShwID09IE5VTEwp\n" - "KQ0KPiArCWlmICh1bmxpa2VseSghcCkpDQoNCk9oIFNUT1Agd2l0aCB0aGUgY2hlY2twYXRjaCB3\n" - "YW5rZmVzdCENCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRh\n" - aW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg= + "On Thu, 2017-08-17 at 16:34 +0200, SF Markus Elfring wrote:\n" + "> From: Markus Elfring <elfring@users.sourceforge.net>\n" + "> Date: Thu, 17 Aug 2017 16:00:18 +0200\n" + "> MIME-Version: 1.0\n" + "> Content-Type: text/plain; charset=UTF-8\n" + "> Content-Transfer-Encoding: 8bit\n" + "> \n" + "> The script \342\200\234checkpatch.pl\342\200\235 pointed information out like the\n" + "> following.\n" + "> \n" + "> Comparison to NULL could be written \342\200\246\n" + "> \n" + "> Thus fix the affected source code places.\n" + "> \n" + "> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>\n" + "> ---\n" + "> fs/lockd/clnt4xdr.c | 12 ++++++------\n" + "> fs/lockd/clntlock.c | 10 +++++-----\n" + "> fs/lockd/clntproc.c | 12 ++++++------\n" + "> fs/lockd/clntxdr.c | 12 ++++++------\n" + "> fs/lockd/host.c | 22 +++++++++++-----------\n" + "> fs/lockd/mon.c | 16 ++++++++--------\n" + "> fs/lockd/svc.c | 4 ++--\n" + "> fs/lockd/svc4proc.c | 6 +++---\n" + "> fs/lockd/svclock.c | 14 +++++++-------\n" + "> fs/lockd/svcproc.c | 6 +++---\n" + "> fs/lockd/svcshare.c | 2 +-\n" + "> fs/lockd/svcsubs.c | 3 +--\n" + "> 12 files changed, 59 insertions(+), 60 deletions(-)\n" + "> \n" + "> diff --git a/fs/lockd/clnt4xdr.c b/fs/lockd/clnt4xdr.c\n" + "> index c349fc0f9b80..ec6473d194fd 100644\n" + "> --- a/fs/lockd/clnt4xdr.c\n" + "> +++ b/fs/lockd/clnt4xdr.c\n" + "> @@ -131,7 +131,7 @@ static int decode_netobj(struct xdr_stream *xdr,\n" + "> \t__be32 *p;\n" + "> \n" + "> \tp = xdr_inline_decode(xdr, 4);\n" + "> -\tif (unlikely(p == NULL))\n" + "> +\tif (unlikely(!p))\n" + "\n" + "Oh STOP with the checkpatch wankfest!\n" + "\n" + "-- \n" + "Trond Myklebust\n" + "Linux NFS client maintainer, PrimaryData\n" + trond.myklebust@primarydata.com -05a8b7cac31cced2a8a744c7cfa649adaf3f8f70ab1f04236636e870dc6ffcaf +7671a989bc714e51f0d9bac393e4f295bed072b2b495b36804779edeb380b89c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.