From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trond Myklebust Date: Fri, 18 Aug 2017 15:53:53 +0000 Subject: Re: [PATCH 2/2] lockd: Adjust 61 checks for null pointers Message-Id: <1503071631.44656.4.camel@primarydata.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "colin.king@canonical.com" , "bfields@fieldses.org" , hch , "linux-nfs@vger.kernel.org" , "jlayton@poochiereds.net" , "elfring@users.sourceforge.net" , bcodding redhat , "anna.schumaker@netapp.com" Cc: "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" T24gVGh1LCAyMDE3LTA4LTE3IGF0IDE2OjM0ICswMjAwLCBTRiBNYXJrdXMgRWxmcmluZyB3cm90 ZToNCj4gRnJvbTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0 Pg0KPiBEYXRlOiBUaHUsIDE3IEF1ZyAyMDE3IDE2OjAwOjE4ICswMjAwDQo+IE1JTUUtVmVyc2lv bjogMS4wDQo+IENvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOA0KPiBDb250 ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0DQo+IA0KPiBUaGUgc2NyaXB0IOKAnGNoZWNrcGF0 Y2gucGzigJ0gcG9pbnRlZCBpbmZvcm1hdGlvbiBvdXQgbGlrZSB0aGUNCj4gZm9sbG93aW5nLg0K PiANCj4gQ29tcGFyaXNvbiB0byBOVUxMIGNvdWxkIGJlIHdyaXR0ZW4g4oCmDQo+IA0KPiBUaHVz IGZpeCB0aGUgYWZmZWN0ZWQgc291cmNlIGNvZGUgcGxhY2VzLg0KPiANCj4gU2lnbmVkLW9mZi1i eTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0Pg0KPiAtLS0N Cj4gIGZzL2xvY2tkL2NsbnQ0eGRyLmMgfCAxMiArKysrKystLS0tLS0NCj4gIGZzL2xvY2tkL2Ns bnRsb2NrLmMgfCAxMCArKysrKy0tLS0tDQo+ICBmcy9sb2NrZC9jbG50cHJvYy5jIHwgMTIgKysr KysrLS0tLS0tDQo+ICBmcy9sb2NrZC9jbG50eGRyLmMgIHwgMTIgKysrKysrLS0tLS0tDQo+ICBm cy9sb2NrZC9ob3N0LmMgICAgIHwgMjIgKysrKysrKysrKystLS0tLS0tLS0tLQ0KPiAgZnMvbG9j a2QvbW9uLmMgICAgICB8IDE2ICsrKysrKysrLS0tLS0tLS0NCj4gIGZzL2xvY2tkL3N2Yy5jICAg ICAgfCAgNCArKy0tDQo+ICBmcy9sb2NrZC9zdmM0cHJvYy5jIHwgIDYgKysrLS0tDQo+ICBmcy9s b2NrZC9zdmNsb2NrLmMgIHwgMTQgKysrKysrKy0tLS0tLS0NCj4gIGZzL2xvY2tkL3N2Y3Byb2Mu YyAgfCAgNiArKystLS0NCj4gIGZzL2xvY2tkL3N2Y3NoYXJlLmMgfCAgMiArLQ0KPiAgZnMvbG9j a2Qvc3Zjc3Vicy5jICB8ICAzICstLQ0KPiAgMTIgZmlsZXMgY2hhbmdlZCwgNTkgaW5zZXJ0aW9u cygrKSwgNjAgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZnMvbG9ja2QvY2xudDR4 ZHIuYyBiL2ZzL2xvY2tkL2NsbnQ0eGRyLmMNCj4gaW5kZXggYzM0OWZjMGY5YjgwLi5lYzY0NzNk MTk0ZmQgMTAwNjQ0DQo+IC0tLSBhL2ZzL2xvY2tkL2NsbnQ0eGRyLmMNCj4gKysrIGIvZnMvbG9j a2QvY2xudDR4ZHIuYw0KPiBAQCAtMTMxLDcgKzEzMSw3IEBAIHN0YXRpYyBpbnQgZGVjb2RlX25l dG9iaihzdHJ1Y3QgeGRyX3N0cmVhbSAqeGRyLA0KPiAgCV9fYmUzMiAqcDsNCj4gIA0KPiAgCXAg PSB4ZHJfaW5saW5lX2RlY29kZSh4ZHIsIDQpOw0KPiAtCWlmICh1bmxpa2VseShwID09IE5VTEwp KQ0KPiArCWlmICh1bmxpa2VseSghcCkpDQoNCk9oIFNUT1Agd2l0aCB0aGUgY2hlY2twYXRjaCB3 YW5rZmVzdCENCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRh aW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-194.mimecast.com ([63.128.21.194]:22880 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045AbdHRPyA (ORCPT ); Fri, 18 Aug 2017 11:54:00 -0400 From: Trond Myklebust To: "colin.king@canonical.com" , "bfields@fieldses.org" , hch , "linux-nfs@vger.kernel.org" , "jlayton@poochiereds.net" , "elfring@users.sourceforge.net" , "bcodding redhat" , "anna.schumaker@netapp.com" CC: "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH 2/2] lockd: Adjust 61 checks for null pointers Date: Fri, 18 Aug 2017 15:53:53 +0000 Message-ID: <1503071631.44656.4.camel@primarydata.com> References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gVGh1LCAyMDE3LTA4LTE3IGF0IDE2OjM0ICswMjAwLCBTRiBNYXJrdXMgRWxmcmluZyB3cm90 ZToNCj4gRnJvbTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0 Pg0KPiBEYXRlOiBUaHUsIDE3IEF1ZyAyMDE3IDE2OjAwOjE4ICswMjAwDQo+IE1JTUUtVmVyc2lv bjogMS4wDQo+IENvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOA0KPiBDb250 ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0DQo+IA0KPiBUaGUgc2NyaXB0IOKAnGNoZWNrcGF0 Y2gucGzigJ0gcG9pbnRlZCBpbmZvcm1hdGlvbiBvdXQgbGlrZSB0aGUNCj4gZm9sbG93aW5nLg0K PiANCj4gQ29tcGFyaXNvbiB0byBOVUxMIGNvdWxkIGJlIHdyaXR0ZW4g4oCmDQo+IA0KPiBUaHVz IGZpeCB0aGUgYWZmZWN0ZWQgc291cmNlIGNvZGUgcGxhY2VzLg0KPiANCj4gU2lnbmVkLW9mZi1i eTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0Pg0KPiAtLS0N Cj4gIGZzL2xvY2tkL2NsbnQ0eGRyLmMgfCAxMiArKysrKystLS0tLS0NCj4gIGZzL2xvY2tkL2Ns bnRsb2NrLmMgfCAxMCArKysrKy0tLS0tDQo+ICBmcy9sb2NrZC9jbG50cHJvYy5jIHwgMTIgKysr KysrLS0tLS0tDQo+ICBmcy9sb2NrZC9jbG50eGRyLmMgIHwgMTIgKysrKysrLS0tLS0tDQo+ICBm cy9sb2NrZC9ob3N0LmMgICAgIHwgMjIgKysrKysrKysrKystLS0tLS0tLS0tLQ0KPiAgZnMvbG9j a2QvbW9uLmMgICAgICB8IDE2ICsrKysrKysrLS0tLS0tLS0NCj4gIGZzL2xvY2tkL3N2Yy5jICAg ICAgfCAgNCArKy0tDQo+ICBmcy9sb2NrZC9zdmM0cHJvYy5jIHwgIDYgKysrLS0tDQo+ICBmcy9s b2NrZC9zdmNsb2NrLmMgIHwgMTQgKysrKysrKy0tLS0tLS0NCj4gIGZzL2xvY2tkL3N2Y3Byb2Mu YyAgfCAgNiArKystLS0NCj4gIGZzL2xvY2tkL3N2Y3NoYXJlLmMgfCAgMiArLQ0KPiAgZnMvbG9j a2Qvc3Zjc3Vicy5jICB8ICAzICstLQ0KPiAgMTIgZmlsZXMgY2hhbmdlZCwgNTkgaW5zZXJ0aW9u cygrKSwgNjAgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZnMvbG9ja2QvY2xudDR4 ZHIuYyBiL2ZzL2xvY2tkL2NsbnQ0eGRyLmMNCj4gaW5kZXggYzM0OWZjMGY5YjgwLi5lYzY0NzNk MTk0ZmQgMTAwNjQ0DQo+IC0tLSBhL2ZzL2xvY2tkL2NsbnQ0eGRyLmMNCj4gKysrIGIvZnMvbG9j a2QvY2xudDR4ZHIuYw0KPiBAQCAtMTMxLDcgKzEzMSw3IEBAIHN0YXRpYyBpbnQgZGVjb2RlX25l dG9iaihzdHJ1Y3QgeGRyX3N0cmVhbSAqeGRyLA0KPiAgCV9fYmUzMiAqcDsNCj4gIA0KPiAgCXAg PSB4ZHJfaW5saW5lX2RlY29kZSh4ZHIsIDQpOw0KPiAtCWlmICh1bmxpa2VseShwID09IE5VTEwp KQ0KPiArCWlmICh1bmxpa2VseSghcCkpDQoNCk9oIFNUT1Agd2l0aCB0aGUgY2hlY2twYXRjaCB3 YW5rZmVzdCENCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRh aW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752195AbdHRPyD (ORCPT ); Fri, 18 Aug 2017 11:54:03 -0400 Received: from us-smtp-delivery-194.mimecast.com ([63.128.21.194]:28464 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbdHRPyA (ORCPT ); Fri, 18 Aug 2017 11:54:00 -0400 From: Trond Myklebust To: "colin.king@canonical.com" , "bfields@fieldses.org" , hch , "linux-nfs@vger.kernel.org" , "jlayton@poochiereds.net" , "elfring@users.sourceforge.net" , "bcodding redhat" , "anna.schumaker@netapp.com" CC: "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH 2/2] lockd: Adjust 61 checks for null pointers Thread-Topic: [PATCH 2/2] lockd: Adjust 61 checks for null pointers Thread-Index: AQHTF2YF++dZWgTmXU+S65P4KqaMFaKKRZOA Date: Fri, 18 Aug 2017 15:53:53 +0000 Message-ID: <1503071631.44656.4.camel@primarydata.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [68.49.162.121] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR11MB0011;20:T+UP0ijgHfxGwQ626eN5mTg1afl9lt4AMgoaOidw8JJtFxHgGj+WtA+0qbz0kGfFJcnX2NGbnp1Jl5nlUbdUpM+P4tmf5f+ufSK+79lKGxVQb3jTNsb0N59sSZ5N7L8Smw18YKAowHVYFPeFw+plVbGG+FgncTKgP+RaepISeSw= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ld-processed: 03193ed6-8726-4bb3-a832-18ab0d28adb7,ExtAddr x-ms-office365-filtering-correlation-id: e07798b2-b2de-4189-7afa-08d4e65153ce x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(2017082002075)(300000503095)(300135400095)(2017052603031)(201703131423075)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DM5PR11MB0011; x-ms-traffictypediagnostic: DM5PR11MB0011: x-exchange-antispam-report-test: UriScan:(42262312472803); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123560025)(20161123564025)(20161123555025)(2016111802025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6043046)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR11MB0011;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR11MB0011; x-forefront-prvs: 040359335D x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39830400002)(189002)(377424004)(199003)(24454002)(106356001)(2906002)(105586002)(14454004)(6116002)(102836003)(3846002)(575784001)(7736002)(305945005)(33646002)(86362001)(68736007)(81156014)(25786009)(478600001)(81166006)(7416002)(97736004)(6246003)(2501003)(8676002)(101416001)(3280700002)(229853002)(2201001)(2900100001)(6486002)(50986999)(54356999)(103116003)(6436002)(3660700001)(6512007)(99286003)(8936002)(54906002)(2950100002)(4326008)(76176999)(6506006)(53936002)(5660300001)(36756003)(77096006)(189998001)(66066001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR11MB0011;H:DM5PR11MB0075.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <17E7BDBF12F16F4E86FDF592FC5C0E4E@namprd11.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: primarydata.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2017 15:53:53.8394 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 03193ed6-8726-4bb3-a832-18ab0d28adb7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB0011 X-MC-Unique: mZm3j-vOPUSLsrGKF6ReHA-1 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7IFs8ri012226 On Thu, 2017-08-17 at 16:34 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 17 Aug 2017 16:00:18 +0200 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The script “checkpatch.pl” pointed information out like the > following. > > Comparison to NULL could be written … > > Thus fix the affected source code places. > > Signed-off-by: Markus Elfring > --- > fs/lockd/clnt4xdr.c | 12 ++++++------ > fs/lockd/clntlock.c | 10 +++++----- > fs/lockd/clntproc.c | 12 ++++++------ > fs/lockd/clntxdr.c | 12 ++++++------ > fs/lockd/host.c | 22 +++++++++++----------- > fs/lockd/mon.c | 16 ++++++++-------- > fs/lockd/svc.c | 4 ++-- > fs/lockd/svc4proc.c | 6 +++--- > fs/lockd/svclock.c | 14 +++++++------- > fs/lockd/svcproc.c | 6 +++--- > fs/lockd/svcshare.c | 2 +- > fs/lockd/svcsubs.c | 3 +-- > 12 files changed, 59 insertions(+), 60 deletions(-) > > diff --git a/fs/lockd/clnt4xdr.c b/fs/lockd/clnt4xdr.c > index c349fc0f9b80..ec6473d194fd 100644 > --- a/fs/lockd/clnt4xdr.c > +++ b/fs/lockd/clnt4xdr.c > @@ -131,7 +131,7 @@ static int decode_netobj(struct xdr_stream *xdr, > __be32 *p; > > p = xdr_inline_decode(xdr, 4); > - if (unlikely(p == NULL)) > + if (unlikely(!p)) Oh STOP with the checkpatch wankfest! -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@primarydata.com