diff for duplicates of <1503072249.4719.22.camel@redhat.com> diff --git a/a/1.txt b/N1/1.txt index 2129c30..9c752bd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -37,7 +37,7 @@ On Fri, 2017-08-18 at 15:53 +0000, Trond Myklebust wrote: > > __be32 *p; > > > > p = xdr_inline_decode(xdr, 4); -> > - if (unlikely(p = NULL)) +> > - if (unlikely(p == NULL)) > > + if (unlikely(!p)) > > Oh STOP with the checkpatch wankfest! diff --git a/a/content_digest b/N1/content_digest index 3f96377..f7b140a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\01503071631.44656.4.camel@primarydata.com\0" "From\0Jeff Layton <jlayton@redhat.com>\0" "Subject\0Re: [PATCH 2/2] lockd: Adjust 61 checks for null pointers\0" - "Date\0Fri, 18 Aug 2017 16:04:09 +0000\0" + "Date\0Fri, 18 Aug 2017 12:04:09 -0400\0" "To\0Trond Myklebust <trondmy@primarydata.com>" colin.king@canonical.com <colin.king@canonical.com> bfields@fieldses.org <bfields@fieldses.org> @@ -55,7 +55,7 @@ "> > \t__be32 *p;\n" "> > \n" "> > \tp = xdr_inline_decode(xdr, 4);\n" - "> > -\tif (unlikely(p = NULL))\n" + "> > -\tif (unlikely(p == NULL))\n" "> > +\tif (unlikely(!p))\n" "> \n" "> Oh STOP with the checkpatch wankfest!\n" @@ -75,4 +75,4 @@ "-- \n" Jeff Layton <jlayton@redhat.com> -f164dfd834b25d00f6165cdc8d575b10a94ad748f8d1130ce3768bbf25703928 +dc4e14aebfd7fe0f0077b3e38cee6b140b5b2c8cfaee20fa6de75eda510d4b64
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.