From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Rishabh Hardas <rishabhhardas@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, rjosephwright@gmail.com,
linux@Wolf-Entwicklungen.de, colin.king@canonical.com
Subject: Re: [PATCH v2 1/4] staging: pi433: Style fix - Correct long lines
Date: Sat, 19 Aug 2017 21:47:28 -0700 [thread overview]
Message-ID: <1503204448.6933.1.camel@perches.com> (raw)
In-Reply-To: <20170816073106.vyhezn7f2recdarp@mwanda>
On Wed, 2017-08-16 at 10:31 +0300, Dan Carpenter wrote:
> On Wed, Aug 16, 2017 at 10:53:18AM +0530, Rishabh Hardas wrote:
> > @@ -143,10 +142,13 @@ struct pi433_rx_cfg {
> >
> > #define PI433_IOC_MAGIC 'r'
> >
> > -#define PI433_IOC_RD_TX_CFG _IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)])
> > -#define PI433_IOC_WR_TX_CFG _IOW(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR, char[sizeof(struct pi433_tx_cfg)])
> > -
> > -#define PI433_IOC_RD_RX_CFG _IOR(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR, char[sizeof(struct pi433_rx_cfg)])
> > -#define PI433_IOC_WR_RX_CFG _IOW(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR, char[sizeof(struct pi433_rx_cfg)])
> > +#define PI433_IOC_RD_TX_CFG _IOR(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR,\
> > + char[sizeof(struct pi433_tx_cfg)])
> > +#define PI433_IOC_WR_TX_CFG _IOW(PI433_IOC_MAGIC, PI433_TX_CFG_IOCTL_NR,\
> > + char[sizeof(struct pi433_tx_cfg)])
> > +#define PI433_IOC_RD_RX_CFG _IOR(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR,\
> > + char[sizeof(struct pi433_rx_cfg)])
> > +#define PI433_IOC_WR_RX_CFG _IOW(PI433_IOC_MAGIC, PI433_RX_CFG_IOCTL_NR,\
> > + char[sizeof(struct pi433_rx_cfg)])
>
>
> These don't help readability. The original was better.
The original wasn't any good either.
It'd be better to avoid the macros altogether
as almost all are use-once.
next prev parent reply other threads:[~2017-08-20 4:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 11:50 [PATCH v2 0/4] staging: pi433: Rename camel case and other style issues Rishabh Hardas
2017-08-03 11:50 ` [PATCH v2 1/4] staging: pi433: Style fix - Correct long lines Rishabh Hardas
2017-08-15 0:42 ` Greg KH
2017-08-16 7:31 ` Dan Carpenter
2017-08-20 4:47 ` Joe Perches [this message]
2017-08-22 9:27 ` Rishabh Hardas
2017-08-22 10:03 ` Dan Carpenter
2017-08-22 10:29 ` Marcus Wolf
2017-08-22 10:43 ` Dan Carpenter
2017-08-03 11:50 ` [PATCH v2 2/4] staging: pi433: Change Comments Rishabh Hardas
2017-08-16 7:35 ` Dan Carpenter
2017-08-03 11:50 ` [PATCH v2 3/4] staging: pi433: Renaming Enums Rishabh Hardas
2017-08-16 7:34 ` Dan Carpenter
2017-08-03 11:50 ` [PATCH v2 4/4] staging: pi433: Remove camel case variable names Rishabh Hardas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503204448.6933.1.camel@perches.com \
--to=joe@perches.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@Wolf-Entwicklungen.de \
--cc=rishabhhardas@gmail.com \
--cc=rjosephwright@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.