From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeniy.Paltsev@synopsys.com (Eugeniy Paltsev) Date: Wed, 23 Aug 2017 11:24:15 +0000 Subject: [PATCH 4/5] ARC: AXS103: DTS: Set cpu frequency explicitly via dts In-Reply-To: <4685c3d5-7a2f-78cd-a11b-2eda0de2dd35@synopsys.com> References: <20170814161213.17522-1-Eugeniy.Paltsev@synopsys.com> <20170814161213.17522-5-Eugeniy.Paltsev@synopsys.com> <4685c3d5-7a2f-78cd-a11b-2eda0de2dd35@synopsys.com> List-ID: Message-ID: <1503487454.2586.58.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org On Tue, 2017-08-22@14:40 -0700, Vineet Gupta wrote: > On 08/14/2017 09:12 AM, Eugeniy Paltsev wrote: > > Set cpu frequency explicitly via "cpu-freq" param in cpu 0 node > > in device tree. > > > > We add "cpu-freq" only to cpu 0 as all cpus are clocking from same > > clock source (same pll in our case). > > > > We override cpus node in skeleton as we don't need this change for > > nsim. > > Given that you added a generic feature as part of 1/5 - do other > platforms? > abilis/nps need corresponding fixups as this one ! Actually no. If cpu 0 node don't have "cpu-freq" property we simply print cpu frequency and don't try to change it. So we can left other dts untouched. > > > > Signed-off-by: Eugeniy Paltsev > > --- > > ? arch/arc/boot/dts/axc003.dtsi?????| 13 +++++++++++++ > > ? arch/arc/boot/dts/axc003_idu.dtsi | 35 > > +++++++++++++++++++++++++++++++++++ > > ? 2 files changed, 48 insertions(+) > > > > diff --git a/arch/arc/boot/dts/axc003.dtsi > > b/arch/arc/boot/dts/axc003.dtsi > > index dca7e39..7c7411c 100644 > > --- a/arch/arc/boot/dts/axc003.dtsi > > +++ b/arch/arc/boot/dts/axc003.dtsi > > @@ -17,6 +17,19 @@ > > ?? #address-cells = <2>; > > ?? #size-cells = <2>; > > ?? > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + cpu at 0 { > > + device_type = "cpu"; > > + compatible = "snps,archs38"; > > + reg = <0>; > > + cpu-freq = <100000000>; > > + clocks = <&core_clk>; > > + }; > > + }; > > + > > ?? cpu_card { > > ?? compatible = "simple-bus"; > > ?? #address-cells = <1>; > > diff --git a/arch/arc/boot/dts/axc003_idu.dtsi > > b/arch/arc/boot/dts/axc003_idu.dtsi > > index 5b56bef..44bc01e 100644 > > --- a/arch/arc/boot/dts/axc003_idu.dtsi > > +++ b/arch/arc/boot/dts/axc003_idu.dtsi > > @@ -17,6 +17,41 @@ > > ?? #address-cells = <2>; > > ?? #size-cells = <2>; > > ?? > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + /* > > + ?* "cpu-freq" was added only to cpu 0 as all cpus > > are clocking > > + ?* from same clock source (same pll (core_clk) in > > our case). > > + ?*/ > > + cpu at 0 { > > + device_type = "cpu"; > > + compatible = "snps,archs38"; > > + reg = <0>; > > + cpu-freq = <100000000>; > > + clocks = <&core_clk>; > > + }; > > + cpu at 1 { > > + device_type = "cpu"; > > + compatible = "snps,archs38"; > > + reg = <1>; > > + clocks = <&core_clk>; > > + }; > > + cpu at 2 { > > + device_type = "cpu"; > > + compatible = "snps,archs38"; > > + reg = <2>; > > + clocks = <&core_clk>; > > + }; > > + cpu at 3 { > > + device_type = "cpu"; > > + compatible = "snps,archs38"; > > + reg = <3>; > > + clocks = <&core_clk>; > > + }; > > + }; > > + > > ?? cpu_card { > > ?? compatible = "simple-bus"; > > ?? #address-cells = <1>; > > -- ?Eugeniy Paltsev From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeniy Paltsev Subject: Re: [PATCH 4/5] ARC: AXS103: DTS: Set cpu frequency explicitly via dts Date: Wed, 23 Aug 2017 11:24:15 +0000 Message-ID: <1503487454.2586.58.camel@synopsys.com> References: <20170814161213.17522-1-Eugeniy.Paltsev@synopsys.com> <20170814161213.17522-5-Eugeniy.Paltsev@synopsys.com> <4685c3d5-7a2f-78cd-a11b-2eda0de2dd35@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4685c3d5-7a2f-78cd-a11b-2eda0de2dd35-HKixBCOQz3hWk0Htik3J/w@public.gmane.org> Content-Language: en-US Content-ID: <0FCCF0542B240B4EA68F16282A2C369C-z7JfP6tgrtVBCHUSTMH8dZqQE7yCjDx5@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vineet Gupta , "linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "mark.rutland-5wv7dgnIgG8@public.gmane.org" , Alexey Brodkin , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org T24gVHVlLCAyMDE3LTA4LTIyIGF0IDE0OjQwIC0wNzAwLCBWaW5lZXQgR3VwdGEgd3JvdGU6DQo+ IE9uIDA4LzE0LzIwMTcgMDk6MTIgQU0sIEV1Z2VuaXkgUGFsdHNldiB3cm90ZToNCj4gPiBTZXQg Y3B1IGZyZXF1ZW5jeSBleHBsaWNpdGx5IHZpYSAiY3B1LWZyZXEiIHBhcmFtIGluIGNwdSAwIG5v ZGUNCj4gPiBpbiBkZXZpY2UgdHJlZS4NCj4gPiANCj4gPiBXZSBhZGQgImNwdS1mcmVxIiBvbmx5 IHRvIGNwdSAwIGFzIGFsbCBjcHVzIGFyZSBjbG9ja2luZyBmcm9tIHNhbWUNCj4gPiBjbG9jayBz b3VyY2UgKHNhbWUgcGxsIGluIG91ciBjYXNlKS4NCj4gPiANCj4gPiBXZSBvdmVycmlkZSBjcHVz IG5vZGUgaW4gc2tlbGV0b24gYXMgd2UgZG9uJ3QgbmVlZCB0aGlzIGNoYW5nZSBmb3INCj4gPiBu c2ltLg0KPiANCj4gR2l2ZW4gdGhhdCB5b3UgYWRkZWQgYSBnZW5lcmljIGZlYXR1cmUgYXMgcGFy dCBvZiAxLzUgLSBkbyBvdGhlcg0KPiBwbGF0Zm9ybXPCoA0KPiBhYmlsaXMvbnBzIG5lZWQgY29y cmVzcG9uZGluZyBmaXh1cHMgYXMgdGhpcyBvbmUgIQ0KDQpBY3R1YWxseSBuby4NCklmIGNwdSAw IG5vZGUgZG9uJ3QgaGF2ZSAiY3B1LWZyZXEiIHByb3BlcnR5IHdlIHNpbXBseSBwcmludCBjcHUN CmZyZXF1ZW5jeSBhbmQgZG9uJ3QgdHJ5IHRvIGNoYW5nZSBpdC4NClNvIHdlIGNhbiBsZWZ0IG90 aGVyIGR0cyB1bnRvdWNoZWQuIA0KDQo+ID4gDQo+ID4gU2lnbmVkLW9mZi1ieTogRXVnZW5peSBQ YWx0c2V2IDxFdWdlbml5LlBhbHRzZXZAc3lub3BzeXMuY29tPg0KPiA+IC0tLQ0KPiA+IMKgIGFy Y2gvYXJjL2Jvb3QvZHRzL2F4YzAwMy5kdHNpwqDCoMKgwqDCoHwgMTMgKysrKysrKysrKysrKw0K PiA+IMKgIGFyY2gvYXJjL2Jvb3QvZHRzL2F4YzAwM19pZHUuZHRzaSB8IDM1DQo+ID4gKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gPiDCoCAyIGZpbGVzIGNoYW5nZWQsIDQ4 IGluc2VydGlvbnMoKykNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcmMvYm9vdC9kdHMv YXhjMDAzLmR0c2kNCj4gPiBiL2FyY2gvYXJjL2Jvb3QvZHRzL2F4YzAwMy5kdHNpDQo+ID4gaW5k ZXggZGNhN2UzOS4uN2M3NDExYyAxMDA2NDQNCj4gPiAtLS0gYS9hcmNoL2FyYy9ib290L2R0cy9h eGMwMDMuZHRzaQ0KPiA+ICsrKyBiL2FyY2gvYXJjL2Jvb3QvZHRzL2F4YzAwMy5kdHNpDQo+ID4g QEAgLTE3LDYgKzE3LDE5IEBADQo+ID4gwqDCoAkjYWRkcmVzcy1jZWxscyA9IDwyPjsNCj4gPiDC oMKgCSNzaXplLWNlbGxzID0gPDI+Ow0KPiA+IMKgwqANCj4gPiArCWNwdXMgew0KPiA+ICsJCSNh ZGRyZXNzLWNlbGxzID0gPDE+Ow0KPiA+ICsJCSNzaXplLWNlbGxzID0gPDA+Ow0KPiA+ICsNCj4g PiArCQljcHVAMCB7DQo+ID4gKwkJCWRldmljZV90eXBlID0gImNwdSI7DQo+ID4gKwkJCWNvbXBh dGlibGUgPSAic25wcyxhcmNoczM4IjsNCj4gPiArCQkJcmVnID0gPDA+Ow0KPiA+ICsJCQljcHUt ZnJlcSA9IDwxMDAwMDAwMDA+Ow0KPiA+ICsJCQljbG9ja3MgPSA8JmNvcmVfY2xrPjsNCj4gPiAr CQl9Ow0KPiA+ICsJfTsNCj4gPiArDQo+ID4gwqDCoAljcHVfY2FyZCB7DQo+ID4gwqDCoAkJY29t cGF0aWJsZSA9ICJzaW1wbGUtYnVzIjsNCj4gPiDCoMKgCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsN Cj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcmMvYm9vdC9kdHMvYXhjMDAzX2lkdS5kdHNpDQo+ID4g Yi9hcmNoL2FyYy9ib290L2R0cy9heGMwMDNfaWR1LmR0c2kNCj4gPiBpbmRleCA1YjU2YmVmLi40 NGJjMDFlIDEwMDY0NA0KPiA+IC0tLSBhL2FyY2gvYXJjL2Jvb3QvZHRzL2F4YzAwM19pZHUuZHRz aQ0KPiA+ICsrKyBiL2FyY2gvYXJjL2Jvb3QvZHRzL2F4YzAwM19pZHUuZHRzaQ0KPiA+IEBAIC0x Nyw2ICsxNyw0MSBAQA0KPiA+IMKgwqAJI2FkZHJlc3MtY2VsbHMgPSA8Mj47DQo+ID4gwqDCoAkj c2l6ZS1jZWxscyA9IDwyPjsNCj4gPiDCoMKgDQo+ID4gKwljcHVzIHsNCj4gPiArCQkjYWRkcmVz cy1jZWxscyA9IDwxPjsNCj4gPiArCQkjc2l6ZS1jZWxscyA9IDwwPjsNCj4gPiArDQo+ID4gKwkJ LyoNCj4gPiArCQnCoCogImNwdS1mcmVxIiB3YXMgYWRkZWQgb25seSB0byBjcHUgMCBhcyBhbGwg Y3B1cw0KPiA+IGFyZSBjbG9ja2luZw0KPiA+ICsJCcKgKiBmcm9tIHNhbWUgY2xvY2sgc291cmNl IChzYW1lIHBsbCAoY29yZV9jbGspIGluDQo+ID4gb3VyIGNhc2UpLg0KPiA+ICsJCcKgKi8NCj4g PiArCQljcHVAMCB7DQo+ID4gKwkJCWRldmljZV90eXBlID0gImNwdSI7DQo+ID4gKwkJCWNvbXBh dGlibGUgPSAic25wcyxhcmNoczM4IjsNCj4gPiArCQkJcmVnID0gPDA+Ow0KPiA+ICsJCQljcHUt ZnJlcSA9IDwxMDAwMDAwMDA+Ow0KPiA+ICsJCQljbG9ja3MgPSA8JmNvcmVfY2xrPjsNCj4gPiAr CQl9Ow0KPiA+ICsJCWNwdUAxIHsNCj4gPiArCQkJZGV2aWNlX3R5cGUgPSAiY3B1IjsNCj4gPiAr CQkJY29tcGF0aWJsZSA9ICJzbnBzLGFyY2hzMzgiOw0KPiA+ICsJCQlyZWcgPSA8MT47DQo+ID4g KwkJCWNsb2NrcyA9IDwmY29yZV9jbGs+Ow0KPiA+ICsJCX07DQo+ID4gKwkJY3B1QDIgew0KPiA+ ICsJCQlkZXZpY2VfdHlwZSA9ICJjcHUiOw0KPiA+ICsJCQljb21wYXRpYmxlID0gInNucHMsYXJj aHMzOCI7DQo+ID4gKwkJCXJlZyA9IDwyPjsNCj4gPiArCQkJY2xvY2tzID0gPCZjb3JlX2Nsaz47 DQo+ID4gKwkJfTsNCj4gPiArCQljcHVAMyB7DQo+ID4gKwkJCWRldmljZV90eXBlID0gImNwdSI7 DQo+ID4gKwkJCWNvbXBhdGlibGUgPSAic25wcyxhcmNoczM4IjsNCj4gPiArCQkJcmVnID0gPDM+ Ow0KPiA+ICsJCQljbG9ja3MgPSA8JmNvcmVfY2xrPjsNCj4gPiArCQl9Ow0KPiA+ICsJfTsNCj4g PiArDQo+ID4gwqDCoAljcHVfY2FyZCB7DQo+ID4gwqDCoAkJY29tcGF0aWJsZSA9ICJzaW1wbGUt YnVzIjsNCj4gPiDCoMKgCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsNCj4gDQo+IA0KLS0gDQrCoEV1 Z2VuaXkgUGFsdHNldg== -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753931AbdHWLYV (ORCPT ); Wed, 23 Aug 2017 07:24:21 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:54195 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753760AbdHWLYT (ORCPT ); Wed, 23 Aug 2017 07:24:19 -0400 From: Eugeniy Paltsev To: Vineet Gupta , "linux-snps-arc@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" , "mark.rutland@arm.com" , Alexey Brodkin , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH 4/5] ARC: AXS103: DTS: Set cpu frequency explicitly via dts Thread-Topic: [PATCH 4/5] ARC: AXS103: DTS: Set cpu frequency explicitly via dts Thread-Index: AQHTFRgj1b8p3G9ImU2lvTxOKFI3q6KQ0u0AgADmDgA= Date: Wed, 23 Aug 2017 11:24:15 +0000 Message-ID: <1503487454.2586.58.camel@synopsys.com> References: <20170814161213.17522-1-Eugeniy.Paltsev@synopsys.com> <20170814161213.17522-5-Eugeniy.Paltsev@synopsys.com> <4685c3d5-7a2f-78cd-a11b-2eda0de2dd35@synopsys.com> In-Reply-To: <4685c3d5-7a2f-78cd-a11b-2eda0de2dd35@synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.106] Content-Type: text/plain; charset="utf-8" Content-ID: <0FCCF0542B240B4EA68F16282A2C369C@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7NBOQ4h006772 On Tue, 2017-08-22 at 14:40 -0700, Vineet Gupta wrote: > On 08/14/2017 09:12 AM, Eugeniy Paltsev wrote: > > Set cpu frequency explicitly via "cpu-freq" param in cpu 0 node > > in device tree. > > > > We add "cpu-freq" only to cpu 0 as all cpus are clocking from same > > clock source (same pll in our case). > > > > We override cpus node in skeleton as we don't need this change for > > nsim. > > Given that you added a generic feature as part of 1/5 - do other > platforms  > abilis/nps need corresponding fixups as this one ! Actually no. If cpu 0 node don't have "cpu-freq" property we simply print cpu frequency and don't try to change it. So we can left other dts untouched. > > > > Signed-off-by: Eugeniy Paltsev > > --- > >   arch/arc/boot/dts/axc003.dtsi     | 13 +++++++++++++ > >   arch/arc/boot/dts/axc003_idu.dtsi | 35 > > +++++++++++++++++++++++++++++++++++ > >   2 files changed, 48 insertions(+) > > > > diff --git a/arch/arc/boot/dts/axc003.dtsi > > b/arch/arc/boot/dts/axc003.dtsi > > index dca7e39..7c7411c 100644 > > --- a/arch/arc/boot/dts/axc003.dtsi > > +++ b/arch/arc/boot/dts/axc003.dtsi > > @@ -17,6 +17,19 @@ > >    #address-cells = <2>; > >    #size-cells = <2>; > >    > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + cpu@0 { > > + device_type = "cpu"; > > + compatible = "snps,archs38"; > > + reg = <0>; > > + cpu-freq = <100000000>; > > + clocks = <&core_clk>; > > + }; > > + }; > > + > >    cpu_card { > >    compatible = "simple-bus"; > >    #address-cells = <1>; > > diff --git a/arch/arc/boot/dts/axc003_idu.dtsi > > b/arch/arc/boot/dts/axc003_idu.dtsi > > index 5b56bef..44bc01e 100644 > > --- a/arch/arc/boot/dts/axc003_idu.dtsi > > +++ b/arch/arc/boot/dts/axc003_idu.dtsi > > @@ -17,6 +17,41 @@ > >    #address-cells = <2>; > >    #size-cells = <2>; > >    > > + cpus { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + /* > > +  * "cpu-freq" was added only to cpu 0 as all cpus > > are clocking > > +  * from same clock source (same pll (core_clk) in > > our case). > > +  */ > > + cpu@0 { > > + device_type = "cpu"; > > + compatible = "snps,archs38"; > > + reg = <0>; > > + cpu-freq = <100000000>; > > + clocks = <&core_clk>; > > + }; > > + cpu@1 { > > + device_type = "cpu"; > > + compatible = "snps,archs38"; > > + reg = <1>; > > + clocks = <&core_clk>; > > + }; > > + cpu@2 { > > + device_type = "cpu"; > > + compatible = "snps,archs38"; > > + reg = <2>; > > + clocks = <&core_clk>; > > + }; > > + cpu@3 { > > + device_type = "cpu"; > > + compatible = "snps,archs38"; > > + reg = <3>; > > + clocks = <&core_clk>; > > + }; > > + }; > > + > >    cpu_card { > >    compatible = "simple-bus"; > >    #address-cells = <1>; > > --  Eugeniy Paltsev