From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeniy.Paltsev@synopsys.com (Eugeniy Paltsev) Date: Wed, 23 Aug 2017 12:18:40 +0000 Subject: [PATCH 3/5] ARC: AXS103: DTS: Add core pll node to manage cpu frequency In-Reply-To: <9624a76d-a31f-10fc-aec5-5ffa1d437c3d@synopsys.com> References: <20170814161213.17522-1-Eugeniy.Paltsev@synopsys.com> <20170814161213.17522-4-Eugeniy.Paltsev@synopsys.com> <9624a76d-a31f-10fc-aec5-5ffa1d437c3d@synopsys.com> List-ID: Message-ID: <1503490719.15555.1.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org On Tue, 2017-08-22@13:45 -0700, Vineet Gupta wrote: > On 08/14/2017 09:12 AM, Eugeniy Paltsev wrote: > > Add core pll node (core_clk) to manage cpu frequency. > > core_clk represents pll itself. > > input_clk represents clock signal source (basically xtal) which > > comes to pll input. > > > > Signed-off-by: Eugeniy Paltsev > > --- > > ? arch/arc/boot/dts/axc003.dtsi?????| 11 +++++++++-- > > ? arch/arc/boot/dts/axc003_idu.dtsi | 11 +++++++++-- > > ? 2 files changed, 18 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arc/boot/dts/axc003.dtsi > > b/arch/arc/boot/dts/axc003.dtsi > > index cc9239e..dca7e39 100644 > > --- a/arch/arc/boot/dts/axc003.dtsi > > +++ b/arch/arc/boot/dts/axc003.dtsi > > @@ -24,10 +24,17 @@ > > ?? > > ?? ranges = <0x00000000 0x0 0xf0000000 0x10000000>; > > ?? > > - core_clk: core_clk { > > + input_clk: input-clk { > > ?? #clock-cells = <0>; > > ?? compatible = "fixed-clock"; > > - clock-frequency = <90000000>; > > + clock-frequency = <33333333>; > > + }; > > + > > + core_clk: core-clk at 80 { > > + compatible = "snps,axs10x-arc-pll-clock"; > > + reg = <0x80 0x10>, <0x100 0x10>; > > + #clock-cells = <0>; > > + clocks = <&input_clk>; > > ?? }; > > ?? > > ?? core_intc: archs-intc at cpu { > > diff --git a/arch/arc/boot/dts/axc003_idu.dtsi > > b/arch/arc/boot/dts/axc003_idu.dtsi > > index 4ebb2170..5b56bef 100644 > > --- a/arch/arc/boot/dts/axc003_idu.dtsi > > +++ b/arch/arc/boot/dts/axc003_idu.dtsi > > @@ -24,10 +24,17 @@ > > ?? > > ?? ranges = <0x00000000 0x0 0xf0000000 0x10000000>; > > ?? > > - core_clk: core_clk { > > + input_clk: input-clk { > > ?? #clock-cells = <0>; > > ?? compatible = "fixed-clock"; > > - clock-frequency = <100000000>; > > + clock-frequency = <33333333>; > > + }; > > + > > + core_clk: core-clk at 80 { > > + compatible = "snps,axs10x-arc-pll-clock"; > > + reg = <0x80 0x10>, <0x100 0x10>; > > + #clock-cells = <0>; > > + clocks = <&input_clk>; > > ?? }; > > ?? > > ?? core_intc: archs-intc at cpu { > > > Do we have a bisectability issue here - isn't system broken > temporarily at 2/5 -? > and only 3/5 makes it work again - if so we need to squash them > together ! Could you please be more specific about this bisectability issue as I can't see it here. If we apply 2/5 and don't apply 3/5 we simply won't change frequency after linux boot. We won't increase frequency so I can't see any problem here here. --- The only problem I can see is in 4/5: I should use cpu-freq = <90000000>; instead of cpu-freq = <100000000>; in arch/arc/boot/dts/axc003.dtsi So diff should be like --------------->8----------- +???????cpus { +???????????????#address-cells = <1>; +???????????????#size-cells = <0>; + +???????????????cpu at 0 { +???????????????????????device_type = "cpu"; +???????????????????????compatible = "snps,archs38"; +???????????????????????reg = <0>; +???????????????????????cpu-freq = <90000000>; +???????????????????????clocks = <&core_clk>; +???????????????}; +???????}; + --------------->8----------- Should I send you v2 respin or you'll fix that up locally? > -Vineet -- ?Eugeniy Paltsev From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeniy Paltsev Subject: Re: [PATCH 3/5] ARC: AXS103: DTS: Add core pll node to manage cpu frequency Date: Wed, 23 Aug 2017 12:18:40 +0000 Message-ID: <1503490719.15555.1.camel@synopsys.com> References: <20170814161213.17522-1-Eugeniy.Paltsev@synopsys.com> <20170814161213.17522-4-Eugeniy.Paltsev@synopsys.com> <9624a76d-a31f-10fc-aec5-5ffa1d437c3d@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <9624a76d-a31f-10fc-aec5-5ffa1d437c3d-HKixBCOQz3hWk0Htik3J/w@public.gmane.org> Content-Language: en-US Content-ID: <437D91E90BE2B2498C3B8E39AC61F0BC-z7JfP6tgrtVBCHUSTMH8dZqQE7yCjDx5@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vineet Gupta , "linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "mark.rutland-5wv7dgnIgG8@public.gmane.org" , Alexey Brodkin , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org T24gVHVlLCAyMDE3LTA4LTIyIGF0IDEzOjQ1IC0wNzAwLCBWaW5lZXQgR3VwdGEgd3JvdGU6DQo+ IE9uIDA4LzE0LzIwMTcgMDk6MTIgQU0sIEV1Z2VuaXkgUGFsdHNldiB3cm90ZToNCj4gPiBBZGQg Y29yZSBwbGwgbm9kZSAoY29yZV9jbGspIHRvIG1hbmFnZSBjcHUgZnJlcXVlbmN5Lg0KPiA+IGNv cmVfY2xrIHJlcHJlc2VudHMgcGxsIGl0c2VsZi4NCj4gPiBpbnB1dF9jbGsgcmVwcmVzZW50cyBj bG9jayBzaWduYWwgc291cmNlIChiYXNpY2FsbHkgeHRhbCkgd2hpY2gNCj4gPiBjb21lcyB0byBw bGwgaW5wdXQuDQo+ID4gDQo+ID4gU2lnbmVkLW9mZi1ieTogRXVnZW5peSBQYWx0c2V2IDxFdWdl bml5LlBhbHRzZXZAc3lub3BzeXMuY29tPg0KPiA+IC0tLQ0KPiA+IMKgIGFyY2gvYXJjL2Jvb3Qv ZHRzL2F4YzAwMy5kdHNpwqDCoMKgwqDCoHwgMTEgKysrKysrKysrLS0NCj4gPiDCoCBhcmNoL2Fy Yy9ib290L2R0cy9heGMwMDNfaWR1LmR0c2kgfCAxMSArKysrKysrKystLQ0KPiA+IMKgIDIgZmls ZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkNCj4gPiANCj4gPiBk aWZmIC0tZ2l0IGEvYXJjaC9hcmMvYm9vdC9kdHMvYXhjMDAzLmR0c2kNCj4gPiBiL2FyY2gvYXJj L2Jvb3QvZHRzL2F4YzAwMy5kdHNpDQo+ID4gaW5kZXggY2M5MjM5ZS4uZGNhN2UzOSAxMDA2NDQN Cj4gPiAtLS0gYS9hcmNoL2FyYy9ib290L2R0cy9heGMwMDMuZHRzaQ0KPiA+ICsrKyBiL2FyY2gv YXJjL2Jvb3QvZHRzL2F4YzAwMy5kdHNpDQo+ID4gQEAgLTI0LDEwICsyNCwxNyBAQA0KPiA+IMKg wqANCj4gPiDCoMKgCQlyYW5nZXMgPSA8MHgwMDAwMDAwMCAweDAgMHhmMDAwMDAwMCAweDEwMDAw MDAwPjsNCj4gPiDCoMKgDQo+ID4gLQkJY29yZV9jbGs6IGNvcmVfY2xrIHsNCj4gPiArCQlpbnB1 dF9jbGs6IGlucHV0LWNsayB7DQo+ID4gwqDCoAkJCSNjbG9jay1jZWxscyA9IDwwPjsNCj4gPiDC oMKgCQkJY29tcGF0aWJsZSA9ICJmaXhlZC1jbG9jayI7DQo+ID4gLQkJCWNsb2NrLWZyZXF1ZW5j eSA9IDw5MDAwMDAwMD47DQo+ID4gKwkJCWNsb2NrLWZyZXF1ZW5jeSA9IDwzMzMzMzMzMz47DQo+ ID4gKwkJfTsNCj4gPiArDQo+ID4gKwkJY29yZV9jbGs6IGNvcmUtY2xrQDgwIHsNCj4gPiArCQkJ Y29tcGF0aWJsZSA9ICJzbnBzLGF4czEweC1hcmMtcGxsLWNsb2NrIjsNCj4gPiArCQkJcmVnID0g PDB4ODAgMHgxMD4sIDwweDEwMCAweDEwPjsNCj4gPiArCQkJI2Nsb2NrLWNlbGxzID0gPDA+Ow0K PiA+ICsJCQljbG9ja3MgPSA8JmlucHV0X2Nsaz47DQo+ID4gwqDCoAkJfTsNCj4gPiDCoMKgDQo+ ID4gwqDCoAkJY29yZV9pbnRjOiBhcmNocy1pbnRjQGNwdSB7DQo+ID4gZGlmZiAtLWdpdCBhL2Fy Y2gvYXJjL2Jvb3QvZHRzL2F4YzAwM19pZHUuZHRzaQ0KPiA+IGIvYXJjaC9hcmMvYm9vdC9kdHMv YXhjMDAzX2lkdS5kdHNpDQo+ID4gaW5kZXggNGViYjIxNzAuLjViNTZiZWYgMTAwNjQ0DQo+ID4g LS0tIGEvYXJjaC9hcmMvYm9vdC9kdHMvYXhjMDAzX2lkdS5kdHNpDQo+ID4gKysrIGIvYXJjaC9h cmMvYm9vdC9kdHMvYXhjMDAzX2lkdS5kdHNpDQo+ID4gQEAgLTI0LDEwICsyNCwxNyBAQA0KPiA+ IMKgwqANCj4gPiDCoMKgCQlyYW5nZXMgPSA8MHgwMDAwMDAwMCAweDAgMHhmMDAwMDAwMCAweDEw MDAwMDAwPjsNCj4gPiDCoMKgDQo+ID4gLQkJY29yZV9jbGs6IGNvcmVfY2xrIHsNCj4gPiArCQlp bnB1dF9jbGs6IGlucHV0LWNsayB7DQo+ID4gwqDCoAkJCSNjbG9jay1jZWxscyA9IDwwPjsNCj4g PiDCoMKgCQkJY29tcGF0aWJsZSA9ICJmaXhlZC1jbG9jayI7DQo+ID4gLQkJCWNsb2NrLWZyZXF1 ZW5jeSA9IDwxMDAwMDAwMDA+Ow0KPiA+ICsJCQljbG9jay1mcmVxdWVuY3kgPSA8MzMzMzMzMzM+ Ow0KPiA+ICsJCX07DQo+ID4gKw0KPiA+ICsJCWNvcmVfY2xrOiBjb3JlLWNsa0A4MCB7DQo+ID4g KwkJCWNvbXBhdGlibGUgPSAic25wcyxheHMxMHgtYXJjLXBsbC1jbG9jayI7DQo+ID4gKwkJCXJl ZyA9IDwweDgwIDB4MTA+LCA8MHgxMDAgMHgxMD47DQo+ID4gKwkJCSNjbG9jay1jZWxscyA9IDww PjsNCj4gPiArCQkJY2xvY2tzID0gPCZpbnB1dF9jbGs+Ow0KPiA+IMKgwqAJCX07DQo+ID4gwqDC oA0KPiA+IMKgwqAJCWNvcmVfaW50YzogYXJjaHMtaW50Y0BjcHUgew0KPiANCj4gDQo+IERvIHdl IGhhdmUgYSBiaXNlY3RhYmlsaXR5IGlzc3VlIGhlcmUgLSBpc24ndCBzeXN0ZW0gYnJva2VuDQo+ IHRlbXBvcmFyaWx5IGF0IDIvNSAtwqANCj4gYW5kIG9ubHkgMy81IG1ha2VzIGl0IHdvcmsgYWdh aW4gLSBpZiBzbyB3ZSBuZWVkIHRvIHNxdWFzaCB0aGVtDQo+IHRvZ2V0aGVyICENCg0KQ291bGQg eW91IHBsZWFzZSBiZSBtb3JlIHNwZWNpZmljIGFib3V0IHRoaXMgYmlzZWN0YWJpbGl0eSBpc3N1 ZSBhcyBJDQpjYW4ndCBzZWUgaXQgaGVyZS4NCg0KSWYgd2UgYXBwbHkgMi81IGFuZCBkb24ndCBh cHBseSAzLzUgd2Ugc2ltcGx5IHdvbid0IGNoYW5nZSBmcmVxdWVuY3kNCmFmdGVyIGxpbnV4IGJv b3QuIFdlIHdvbid0IGluY3JlYXNlIGZyZXF1ZW5jeSBzbyBJIGNhbid0IHNlZSBhbnkNCnByb2Js ZW0gaGVyZSBoZXJlLg0KDQoNCg0KLS0tDQpUaGUgb25seSBwcm9ibGVtIEkgY2FuIHNlZSBpcyBp biA0LzU6DQpJIHNob3VsZCB1c2UNCmNwdS1mcmVxID0gPDkwMDAwMDAwPjsNCmluc3RlYWQgb2YN CmNwdS1mcmVxID0gPDEwMDAwMDAwMD47DQppbiBhcmNoL2FyYy9ib290L2R0cy9heGMwMDMuZHRz aQ0KU28gZGlmZiBzaG91bGQgYmUgbGlrZQ0KLS0tLS0tLS0tLS0tLS0tPjgtLS0tLS0tLS0tLQ0K K8KgwqDCoMKgwqDCoMKgY3B1cyB7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgI2Fk ZHJlc3MtY2VsbHMgPSA8MT47DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgI3NpemUt Y2VsbHMgPSA8MD47DQorDQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgY3B1QDAgew0K K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBkZXZpY2VfdHlw ZSA9ICJjcHUiOw0KK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqBjb21wYXRpYmxlID0gInNucHMsYXJjaHMzOCI7DQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJlZyA9IDwwPjsNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgY3B1LWZyZXEgPSA8OTAwMDAwMDA+Ow0KK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBjbG9ja3MgPSA8JmNvcmVfY2xr PjsNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB9Ow0KK8KgwqDCoMKgwqDCoMKgfTsN CisNCi0tLS0tLS0tLS0tLS0tLT44LS0tLS0tLS0tLS0NCg0KU2hvdWxkIEkgc2VuZCB5b3UgdjIg cmVzcGluIG9yIHlvdSdsbCBmaXggdGhhdCB1cCBsb2NhbGx5Pw0KIA0KPiAtVmluZWV0DQotLSAN CsKgRXVnZW5peSBQYWx0c2V2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754100AbdHWMSr (ORCPT ); Wed, 23 Aug 2017 08:18:47 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:54930 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754016AbdHWMSo (ORCPT ); Wed, 23 Aug 2017 08:18:44 -0400 From: Eugeniy Paltsev To: Vineet Gupta , "linux-snps-arc@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" , "mark.rutland@arm.com" , Alexey Brodkin , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH 3/5] ARC: AXS103: DTS: Add core pll node to manage cpu frequency Thread-Topic: [PATCH 3/5] ARC: AXS103: DTS: Add core pll node to manage cpu frequency Thread-Index: AQHTFRghHM/ABW86yUqiqDXNu0E396KQw3UAgAEEuoA= Date: Wed, 23 Aug 2017 12:18:40 +0000 Message-ID: <1503490719.15555.1.camel@synopsys.com> References: <20170814161213.17522-1-Eugeniy.Paltsev@synopsys.com> <20170814161213.17522-4-Eugeniy.Paltsev@synopsys.com> <9624a76d-a31f-10fc-aec5-5ffa1d437c3d@synopsys.com> In-Reply-To: <9624a76d-a31f-10fc-aec5-5ffa1d437c3d@synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.106] Content-Type: text/plain; charset="utf-8" Content-ID: <437D91E90BE2B2498C3B8E39AC61F0BC@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7NCJ4ct010393 On Tue, 2017-08-22 at 13:45 -0700, Vineet Gupta wrote: > On 08/14/2017 09:12 AM, Eugeniy Paltsev wrote: > > Add core pll node (core_clk) to manage cpu frequency. > > core_clk represents pll itself. > > input_clk represents clock signal source (basically xtal) which > > comes to pll input. > > > > Signed-off-by: Eugeniy Paltsev > > --- > >   arch/arc/boot/dts/axc003.dtsi     | 11 +++++++++-- > >   arch/arc/boot/dts/axc003_idu.dtsi | 11 +++++++++-- > >   2 files changed, 18 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arc/boot/dts/axc003.dtsi > > b/arch/arc/boot/dts/axc003.dtsi > > index cc9239e..dca7e39 100644 > > --- a/arch/arc/boot/dts/axc003.dtsi > > +++ b/arch/arc/boot/dts/axc003.dtsi > > @@ -24,10 +24,17 @@ > >    > >    ranges = <0x00000000 0x0 0xf0000000 0x10000000>; > >    > > - core_clk: core_clk { > > + input_clk: input-clk { > >    #clock-cells = <0>; > >    compatible = "fixed-clock"; > > - clock-frequency = <90000000>; > > + clock-frequency = <33333333>; > > + }; > > + > > + core_clk: core-clk@80 { > > + compatible = "snps,axs10x-arc-pll-clock"; > > + reg = <0x80 0x10>, <0x100 0x10>; > > + #clock-cells = <0>; > > + clocks = <&input_clk>; > >    }; > >    > >    core_intc: archs-intc@cpu { > > diff --git a/arch/arc/boot/dts/axc003_idu.dtsi > > b/arch/arc/boot/dts/axc003_idu.dtsi > > index 4ebb2170..5b56bef 100644 > > --- a/arch/arc/boot/dts/axc003_idu.dtsi > > +++ b/arch/arc/boot/dts/axc003_idu.dtsi > > @@ -24,10 +24,17 @@ > >    > >    ranges = <0x00000000 0x0 0xf0000000 0x10000000>; > >    > > - core_clk: core_clk { > > + input_clk: input-clk { > >    #clock-cells = <0>; > >    compatible = "fixed-clock"; > > - clock-frequency = <100000000>; > > + clock-frequency = <33333333>; > > + }; > > + > > + core_clk: core-clk@80 { > > + compatible = "snps,axs10x-arc-pll-clock"; > > + reg = <0x80 0x10>, <0x100 0x10>; > > + #clock-cells = <0>; > > + clocks = <&input_clk>; > >    }; > >    > >    core_intc: archs-intc@cpu { > > > Do we have a bisectability issue here - isn't system broken > temporarily at 2/5 -  > and only 3/5 makes it work again - if so we need to squash them > together ! Could you please be more specific about this bisectability issue as I can't see it here. If we apply 2/5 and don't apply 3/5 we simply won't change frequency after linux boot. We won't increase frequency so I can't see any problem here here. --- The only problem I can see is in 4/5: I should use cpu-freq = <90000000>; instead of cpu-freq = <100000000>; in arch/arc/boot/dts/axc003.dtsi So diff should be like --------------->8----------- +       cpus { +               #address-cells = <1>; +               #size-cells = <0>; + +               cpu@0 { +                       device_type = "cpu"; +                       compatible = "snps,archs38"; +                       reg = <0>; +                       cpu-freq = <90000000>; +                       clocks = <&core_clk>; +               }; +       }; + --------------->8----------- Should I send you v2 respin or you'll fix that up locally? > -Vineet --  Eugeniy Paltsev