From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rogozhkin, Dmitry V" Subject: Re: [RFC v2 3/3] drm/i915/pmu: deny perf driver level sampling of i915 PMU Date: Wed, 23 Aug 2017 23:43:13 +0000 Message-ID: <1503502868.6588.11.camel@intel.com> References: <1503501963-24136-1-git-send-email-dmitry.v.rogozhkin@intel.com> <1503501963-24136-4-git-send-email-dmitry.v.rogozhkin@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 268F86E65F for ; Wed, 23 Aug 2017 23:43:15 +0000 (UTC) In-Reply-To: <1503501963-24136-4-git-send-email-dmitry.v.rogozhkin@intel.com> Content-Language: en-US Content-ID: <5F714FF54768454898E8B90B8E617F2B@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "intel-gfx@lists.freedesktop.org" , "chris@chris-wilson.co.uk" Cc: "peterz@infradead.org" List-Id: intel-gfx@lists.freedesktop.org SGkgQ2hyaXMsDQoNCldoeSB3ZSBoYWQgZXZlbnQtPmh3LT5ocnRpbWVyIGluIGk5MTUgUE1VPyBX YXMgdGhlcmUgYW55IHBhcnRpY3VsYXINCnJlYXNvbj8gWW91IGhhZCBzb21lIHVzZSBjYXNlIHdo aWNoIGRpZCBub3Qgd29yaz8NCg0KQWNjb3JkaW5nIHRvIFBldGVyIHdlIHNob3VsZCBub3QgZXhw b3NlIHRoZSB0aW1lciBvdXQgb2Ygb3VyIHBtdSwgYW5kIEkNCmRvIG5vdCBzZWUgdGhlIHJlYXNv biB3aHkgd2UgbmVlZCBpdCBhdCB0aGUgZmlyc3QgcGxhY2UuIFNvLCBJIHdlbnQNCmZvcndhcmQg YW5kIHdpcGVkIGl0IG91dCBhbmQgcHJvaGliaXRlZCBldmVudHMgdG8gYmUgaW50aWFsaXplZCB3 aXRoIHRoZQ0Kc2FtcGxpbmdfcGVyaW9kLiBJIGRvbid0IHNlZSB3aGF0IHdpbGwgYmUgYnJva2Vu LiBGcm9tIG15IHBlcnNwZWN0aXZlDQpub3RoaW5nIGJlY2F1c2UgaW50ZXJuYWwgc2FtcGxpbmcg dGltZXIgc3RpbGwgcmVtYWlucy4NCg0KQ291bGQgeW91LCBwbGVhc2UsIGNvbW1lbnQ/DQoNCkRt aXRyeS4NCg0KT24gV2VkLCAyMDE3LTA4LTIzIGF0IDA4OjI2IC0wNzAwLCBEbWl0cnkgUm9nb3po a2luIHdyb3RlOg0KPiBUaGlzIHBhdGNoIHNob3VsZCBwcm9iYWJseSBiZSBzcXVhc2hlZCB3aXRo IFR2cnRrbydzIFBNVSBlbmFibGluZyBwYXRjaC4uLg0KPiANCj4gQXMgcGVyIGRpc2N1c3Npb24g d2l0aCBQZXRlciwgaTkxNSBQTVUgaXMgYW4gZXhhbXBsZSBvZiB1bmNvcmUgUE1VIHdoaWNoDQo+ IGFyZSBwcm9oaWJpdGVkIHRvIHN1cHBvcnQgcGVyZiBkcml2ZXIgbGV2ZWwgc2FtcGxpbmcuIFRo aXMgcGF0Y2ggcmVtb3Zlcw0KPiBocnRpbWVyIHdoaWNoIHdlIGV4cG9zZSB0byBwZXJmIGNvcmUg YW5kIGRlbmllcyBldmVudHMgY3JlYXRpb24gd2l0aA0KPiBub24temVybyBldmVudC0+YXR0ci5z YW1wbGluZ19wZXJpb2QuDQo+IA0KPiBNaW5kIHRoYXQgdGhpcyBwYXRjaCBkb2VzIF9ub3RfIHJl bW92ZSBpOTE1IFBNVSBfaW50ZXJuYWxfIHNhbXBsaW5nIHRpbWVyLg0KPiBTbywgc2FtcGxpbmcg bWV0cmljcyBhcmUgc3RpbGwgZ2F0aGVyZWQsIGJ1dCBjYW4gYmUgYWNjZXNzZWQgb25seSBieQ0K PiBleHBsaWNpdCByZXF1ZXN0IHRvIGdldCBtZXRyaWMgY291bnRlciwgaS5lLiBieSBzeXNfcmVh ZCgpLg0KPiANCj4gQ2hhbmdlLUlkOiBJMzNmMzQ1ZjY3OWYwYTVhOGVjYzk4NjdmOWU3YzFiZmIz NTdlNzA4ZA0KPiBTaWduZWQtb2ZmLWJ5OiBEbWl0cnkgUm9nb3poa2luIDxkbWl0cnkudi5yb2dv emhraW5AaW50ZWwuY29tPg0KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGlu dGVsLmNvbT4NCj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPg0K PiBDYzogUGV0ZXIgWmlqbHN0cmEgPHBldGVyekBpbmZyYWRlYWQub3JnPg0KPiAtLS0NCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11LmMgfCA4OSArKy0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwg ODUgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9wbXUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11LmMNCj4gaW5kZXggYzU1 MWQ2NC4uMzExYWVlYiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9w bXUuYw0KPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5jDQo+IEBAIC0yMzks NTAgKzIzOSw2IEBAIHN0YXRpYyBpbnQgZW5naW5lX2V2ZW50X2luaXQoc3RydWN0IHBlcmZfZXZl bnQgKmV2ZW50KQ0KPiAgCXJldHVybiAwOw0KPiAgfQ0KPiAgDQo+IC1zdGF0aWMgREVGSU5FX1BF Ul9DUFUoc3RydWN0IHB0X3JlZ3MsIGk5MTVfcG11X3B0X3JlZ3MpOw0KPiAtDQo+IC1zdGF0aWMg ZW51bSBocnRpbWVyX3Jlc3RhcnQgaHJ0aW1lcl9zYW1wbGUoc3RydWN0IGhydGltZXIgKmhydGlt ZXIpDQo+IC17DQo+IC0Jc3RydWN0IHB0X3JlZ3MgKnJlZ3MgPSB0aGlzX2NwdV9wdHIoJmk5MTVf cG11X3B0X3JlZ3MpOw0KPiAtCXN0cnVjdCBwZXJmX3NhbXBsZV9kYXRhIGRhdGE7DQo+IC0Jc3Ry dWN0IHBlcmZfZXZlbnQgKmV2ZW50Ow0KPiAtCXU2NCBwZXJpb2Q7DQo+IC0NCj4gLQlldmVudCA9 IGNvbnRhaW5lcl9vZihocnRpbWVyLCBzdHJ1Y3QgcGVyZl9ldmVudCwgaHcuaHJ0aW1lcik7DQo+ IC0JaWYgKGV2ZW50LT5zdGF0ZSAhPSBQRVJGX0VWRU5UX1NUQVRFX0FDVElWRSkNCj4gLQkJcmV0 dXJuIEhSVElNRVJfTk9SRVNUQVJUOw0KPiAtDQo+IC0JZXZlbnQtPnBtdS0+cmVhZChldmVudCk7 DQo+IC0NCj4gLQlwZXJmX3NhbXBsZV9kYXRhX2luaXQoJmRhdGEsIDAsIGV2ZW50LT5ody5sYXN0 X3BlcmlvZCk7DQo+IC0JcGVyZl9ldmVudF9vdmVyZmxvdyhldmVudCwgJmRhdGEsIHJlZ3MpOw0K PiAtDQo+IC0JcGVyaW9kID0gbWF4X3QodTY0LCAxMDAwMCwgZXZlbnQtPmh3LnNhbXBsZV9wZXJp b2QpOw0KPiAtCWhydGltZXJfZm9yd2FyZF9ub3coaHJ0aW1lciwgbnNfdG9fa3RpbWUocGVyaW9k KSk7DQo+IC0JcmV0dXJuIEhSVElNRVJfUkVTVEFSVDsNCj4gLX0NCj4gLQ0KPiAtc3RhdGljIHZv aWQgaW5pdF9ocnRpbWVyKHN0cnVjdCBwZXJmX2V2ZW50ICpldmVudCkNCj4gLXsNCj4gLQlzdHJ1 Y3QgaHdfcGVyZl9ldmVudCAqaHdjID0gJmV2ZW50LT5odzsNCj4gLQ0KPiAtCWlmICghaXNfc2Ft cGxpbmdfZXZlbnQoZXZlbnQpKQ0KPiAtCQlyZXR1cm47DQo+IC0NCj4gLQlocnRpbWVyX2luaXQo Jmh3Yy0+aHJ0aW1lciwgQ0xPQ0tfTU9OT1RPTklDLCBIUlRJTUVSX01PREVfUkVMKTsNCj4gLQlo d2MtPmhydGltZXIuZnVuY3Rpb24gPSBocnRpbWVyX3NhbXBsZTsNCj4gLQ0KPiAtCWlmIChldmVu dC0+YXR0ci5mcmVxKSB7DQo+IC0JCWxvbmcgZnJlcSA9IGV2ZW50LT5hdHRyLnNhbXBsZV9mcmVx Ow0KPiAtDQo+IC0JCWV2ZW50LT5hdHRyLnNhbXBsZV9wZXJpb2QgPSBOU0VDX1BFUl9TRUMgLyBm cmVxOw0KPiAtCQlod2MtPnNhbXBsZV9wZXJpb2QgPSBldmVudC0+YXR0ci5zYW1wbGVfcGVyaW9k Ow0KPiAtCQlsb2NhbDY0X3NldCgmaHdjLT5wZXJpb2RfbGVmdCwgaHdjLT5zYW1wbGVfcGVyaW9k KTsNCj4gLQkJaHdjLT5sYXN0X3BlcmlvZCA9IGh3Yy0+c2FtcGxlX3BlcmlvZDsNCj4gLQkJZXZl bnQtPmF0dHIuZnJlcSA9IDA7DQo+IC0JfQ0KPiAtfQ0KPiAtDQo+ICBzdGF0aWMgaW50IGk5MTVf cG11X2V2ZW50X2luaXQoc3RydWN0IHBlcmZfZXZlbnQgKmV2ZW50KQ0KPiAgew0KPiAgCXN0cnVj dCBkcm1faTkxNV9wcml2YXRlICppOTE1ID0NCj4gQEAgLTI5Myw2ICsyNDksMTAgQEAgc3RhdGlj IGludCBpOTE1X3BtdV9ldmVudF9pbml0KHN0cnVjdCBwZXJmX2V2ZW50ICpldmVudCkNCj4gIAlp ZiAoZXZlbnQtPmF0dHIudHlwZSAhPSBldmVudC0+cG11LT50eXBlKQ0KPiAgCQlyZXR1cm4gLUVO T0VOVDsNCj4gIA0KPiArCS8qIHVuc3VwcG9ydGVkIG1vZGVzIGFuZCBmaWx0ZXJzICovDQo+ICsJ aWYgKGV2ZW50LT5hdHRyLnNhbXBsZV9wZXJpb2QpIC8qIG5vIHNhbXBsaW5nICovDQo+ICsJCXJl dHVybiAtRUlOVkFMOw0KPiArDQo+ICAJaWYgKGhhc19icmFuY2hfc3RhY2soZXZlbnQpKQ0KPiAg CQlyZXR1cm4gLUVPUE5PVFNVUFA7DQo+ICANCj4gQEAgLTMyOCw0NiArMjg4LDkgQEAgc3RhdGlj IGludCBpOTE1X3BtdV9ldmVudF9pbml0KHN0cnVjdCBwZXJmX2V2ZW50ICpldmVudCkNCj4gIAlp ZiAoIWV2ZW50LT5wYXJlbnQpDQo+ICAJCWV2ZW50LT5kZXN0cm95ID0gaTkxNV9wbXVfZXZlbnRf ZGVzdHJveTsNCj4gIA0KPiAtCWluaXRfaHJ0aW1lcihldmVudCk7DQo+IC0NCj4gIAlyZXR1cm4g MDsNCj4gIH0NCj4gIA0KPiAtc3RhdGljIHZvaWQgaTkxNV9wbXVfdGltZXJfc3RhcnQoc3RydWN0 IHBlcmZfZXZlbnQgKmV2ZW50KQ0KPiAtew0KPiAtCXN0cnVjdCBod19wZXJmX2V2ZW50ICpod2Mg PSAmZXZlbnQtPmh3Ow0KPiAtCXM2NCBwZXJpb2Q7DQo+IC0NCj4gLQlpZiAoIWlzX3NhbXBsaW5n X2V2ZW50KGV2ZW50KSkNCj4gLQkJcmV0dXJuOw0KPiAtDQo+IC0JcGVyaW9kID0gbG9jYWw2NF9y ZWFkKCZod2MtPnBlcmlvZF9sZWZ0KTsNCj4gLQlpZiAocGVyaW9kKSB7DQo+IC0JCWlmIChwZXJp b2QgPCAwKQ0KPiAtCQkJcGVyaW9kID0gMTAwMDA7DQo+IC0NCj4gLQkJbG9jYWw2NF9zZXQoJmh3 Yy0+cGVyaW9kX2xlZnQsIDApOw0KPiAtCX0gZWxzZSB7DQo+IC0JCXBlcmlvZCA9IG1heF90KHU2 NCwgMTAwMDAsIGh3Yy0+c2FtcGxlX3BlcmlvZCk7DQo+IC0JfQ0KPiAtDQo+IC0JaHJ0aW1lcl9z dGFydF9yYW5nZV9ucygmaHdjLT5ocnRpbWVyLA0KPiAtCQkJICAgICAgIG5zX3RvX2t0aW1lKHBl cmlvZCksIDAsDQo+IC0JCQkgICAgICAgSFJUSU1FUl9NT0RFX1JFTF9QSU5ORUQpOw0KPiAtfQ0K PiAtDQo+IC1zdGF0aWMgdm9pZCBpOTE1X3BtdV90aW1lcl9jYW5jZWwoc3RydWN0IHBlcmZfZXZl bnQgKmV2ZW50KQ0KPiAtew0KPiAtCXN0cnVjdCBod19wZXJmX2V2ZW50ICpod2MgPSAmZXZlbnQt Pmh3Ow0KPiAtDQo+IC0JaWYgKCFpc19zYW1wbGluZ19ldmVudChldmVudCkpDQo+IC0JCXJldHVy bjsNCj4gLQ0KPiAtCWxvY2FsNjRfc2V0KCZod2MtPnBlcmlvZF9sZWZ0LA0KPiAtCQkgICAga3Rp bWVfdG9fbnMoaHJ0aW1lcl9nZXRfcmVtYWluaW5nKCZod2MtPmhydGltZXIpKSk7DQo+IC0JaHJ0 aW1lcl9jYW5jZWwoJmh3Yy0+aHJ0aW1lcik7DQo+IC19DQo+IC0NCj4gIHN0YXRpYyBib29sIGVu Z2luZV9uZWVkc19idXN5X3N0YXRzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkNCj4g IHsNCj4gIAlyZXR1cm4gc3VwcG9ydHNfYnVzeV9zdGF0cygpICYmDQo+IEBAIC00OTMsOCArNDE2 LDYgQEAgc3RhdGljIHZvaWQgaTkxNV9wbXVfZW5hYmxlKHN0cnVjdCBwZXJmX2V2ZW50ICpldmVu dCkNCj4gIAl9DQo+ICANCj4gIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZpOTE1LT5wbXUubG9j aywgZmxhZ3MpOw0KPiAtDQo+IC0JaTkxNV9wbXVfdGltZXJfc3RhcnQoZXZlbnQpOw0KPiAgfQ0K PiAgDQo+ICBzdGF0aWMgdm9pZCBpOTE1X3BtdV9kaXNhYmxlKHN0cnVjdCBwZXJmX2V2ZW50ICpl dmVudCkNCj4gQEAgLTUzNCw4ICs0NTUsNiBAQCBzdGF0aWMgdm9pZCBpOTE1X3BtdV9kaXNhYmxl KHN0cnVjdCBwZXJmX2V2ZW50ICpldmVudCkNCj4gIAlpOTE1LT5wbXUudGltZXJfZW5hYmxlZCAm PSBwbXVfbmVlZHNfdGltZXIoaTkxNSwgdHJ1ZSk7DQo+ICANCj4gIAlzcGluX3VubG9ja19pcnFy ZXN0b3JlKCZpOTE1LT5wbXUubG9jaywgZmxhZ3MpOw0KPiAtDQo+IC0JaTkxNV9wbXVfdGltZXJf Y2FuY2VsKGV2ZW50KTsNCj4gIH0NCj4gIA0KPiAgc3RhdGljIHZvaWQgaTkxNV9wbXVfZXZlbnRf c3RhcnQoc3RydWN0IHBlcmZfZXZlbnQgKmV2ZW50LCBpbnQgZmxhZ3MpDQoNCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=