From: Bastien Nocera <hadess@hadess.net>
To: Roderick Colenbrander <roderick@gaikai.com>
Cc: linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Jiri Kosina <jikos@kernel.org>,
Roderick Colenbrander <roderick.colenbrander@sony.com>
Subject: Re: [PATCH v2 0/3] Input/HID: joydev fixes for motion sensors
Date: Thu, 24 Aug 2017 02:08:25 +0200 [thread overview]
Message-ID: <1503533305.23013.8.camel@hadess.net> (raw)
In-Reply-To: <CANndSK=mBvBekPTGnKBzMcg7xw5X5bLpNioTZSLFgsEeU6+KeA@mail.gmail.com>
On Wed, 2017-08-23 at 16:57 -0700, Roderick Colenbrander wrote:
> On Wed, Aug 23, 2017 at 2:04 AM, Bastien Nocera <hadess@hadess.net>
> wrote:
> >
<snip>
> > I'm not sure I fully understand the problem you're trying to solve.
> >
> > Is it "old software which relies on joydev is too basic to allow
> > selecting the correct joystick device"? Or "some system components
> > are
> > picking up the joypad's accelerometer like it inferred the screen's
> > positioning"?
> >
>
> The problem is more like the first. Joydev is too basic to allow
> applications to determine they are dealing with a motion sensor
> device
> (axes are just numbers from its perspective). Due to recent hid-sony
> restructure, its motion sensors are now picked up by joydev as it
> passes joydev its heuristics.
>
> We felt that no motion sensors should probably get picked up by the
> legacy joydev interface as it caused issues for legacy applications
> (and users reported issues to me). Originally we proposed filtering
> in
> joydev based on just 'INPUT_PROP_ACCELEROMETER' as it has similar
> filters to filter out touchpad device and others. Discussion on that
> patch led to the composite device discussion as Dmitry felt that the
> ability to use a standalone motion sensor device as a joystick could
> potentially make sense.
In which case a INPUT_PROP_JOYDEV_IGNORE property would be much much
more descriptive of what you want to achieve with this patchset, and
avoids confusion.
I think that INPUT_PROP_COMPOSITE might have its place (and it would be
useful to have supported in toolkits, or wayland compositors), but not
for this purpose.
I'd say repurpose the whole patchset around INPUT_PROP_JOYDEV_IGNORE
and we can look into a more complete INPUT_PROP_COMPOSITE with ioctl()
and co.
Cheers
next prev parent reply other threads:[~2017-08-24 0:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 2:01 [PATCH v2 0/3] Input/HID: joydev fixes for motion sensors Roderick Colenbrander
2017-08-18 2:01 ` [PATCH 1/3] Input: Add new property INPUT_PROP_COMPOSITE Roderick Colenbrander
2017-08-18 3:24 ` Peter Hutterer
2017-08-22 23:34 ` Colenbrander, Roelof
2017-08-23 5:54 ` Peter Hutterer
2017-08-18 2:01 ` [PATCH 2/3] HID: sony: Set INPUT_PROP_COMPOSITE flag on sub devices Roderick Colenbrander
2017-08-23 8:50 ` Bastien Nocera
2017-08-23 23:46 ` Roderick Colenbrander
2017-08-18 2:01 ` [PATCH 3/3] Input: joydev - ignore accelerometer devices Roderick Colenbrander
2017-08-23 8:45 ` Bastien Nocera
2017-08-24 0:01 ` Roderick Colenbrander
2017-08-23 9:04 ` [PATCH v2 0/3] Input/HID: joydev fixes for motion sensors Bastien Nocera
2017-08-23 23:57 ` Roderick Colenbrander
2017-08-24 0:08 ` Bastien Nocera [this message]
2017-08-24 0:59 ` Roderick Colenbrander
2017-08-23 9:08 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503533305.23013.8.camel@hadess.net \
--to=hadess@hadess.net \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=roderick.colenbrander@sony.com \
--cc=roderick@gaikai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.