From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Date: Thu, 24 Aug 2017 10:39:09 +0300 Message-ID: <1503560349.25945.72.camel@linux.intel.com> References: <1503453106-5564-1-git-send-email-trini@konsulko.com> <1503498573.25945.69.camel@linux.intel.com> <20170823173912.GN17193@bill-the-cat> <20170824000525.GY17193@bill-the-cat> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by alsa0.perex.cz (Postfix) with ESMTP id A380D266C5E for ; Thu, 24 Aug 2017 09:42:02 +0200 (CEST) In-Reply-To: <20170824000525.GY17193@bill-the-cat> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Tom Rini Cc: Oder Chiou , alsa-devel@alsa-project.org, Liam Girdwood , linux-kernel@vger.kernel.org, Takashi Iwai , Mark Brown , Bard Liao , Linus Torvalds List-Id: alsa-devel@alsa-project.org T24gV2VkLCAyMDE3LTA4LTIzIGF0IDIwOjA1IC0wNDAwLCBUb20gUmluaSB3cm90ZToKPiBPbiBX ZWQsIEF1ZyAyMywgMjAxNyBhdCAwMTozOToxMlBNIC0wNDAwLCBUb20gUmluaSB3cm90ZToKPiA+ IE9uIFdlZCwgQXVnIDIzLCAyMDE3IGF0IDA1OjI5OjMzUE0gKzAzMDAsIEFuZHkgU2hldmNoZW5r byB3cm90ZToKPiA+IAo+ID4gPiBPbiBUdWUsIDIwMTctMDgtMjIgYXQgMjE6NTEgLTA0MDAsIFRv bSBSaW5pIHdyb3RlOgo+ID4gPiA+IE5vdCBhbGwgZGV2aWNlcyB3aXRoIEFDUEkgYW5kIHRoaXMg Y29tYmluYXRpb24gb2Ygc291bmQgZGV2aWNlcwo+ID4gPiA+IHdpbGwKPiA+ID4gPiBoYXZlIHRo ZSByZXF1aXJlZCBpbmZvcm1hdGlvbiBwcm92aWRlZCB2aWEgQUNQSS7CoMKgUmVpbnRyb2R1Y2UK PiA+ID4gPiB0aGUgSTJDCj4gPiA+ID4gZGV2aWNlIElEIHRvIHJlc3RvcmUgc291bmQgZnVuY3Rp b25hbGl0eSBvbiBvbiB0aGUgQ2hyb21lYm9vawo+ID4gPiA+ICdTYW11cycKPiA+ID4gPiBtb2Rl bC4KPiA+ID4gPiBUaGlzIGlzIGEgcmVncmVzc2lvbiBmcm9tIHY0LjEyIG9uIG15IGxhcHRvcCAo YSBDaHJvbWVib29rCj4gPiA+ID4gJ1NhbXVzJwo+ID4gPiA+IHRoYXQncyBub3QgcnVubmluZyBD aHJvbWVPUykuwqDCoE15IGZhdWx0IGZvciBnZXR0aW5nIG91dCBvZiB0aGUKPiA+ID4gPiBoYWJp dAo+ID4gPiA+IG9mCj4gPiA+ID4gdHJ5aW5nIC1yYzEgd2hlbiBpdCBjb21lcyBvdXQgYW5kIG5v dCBzcG90dGluZyB0aGlzIHNvb25lci7CoMKgSSdtCj4gPiA+ID4gbm90Cj4gPiA+ID4gMTAwJSBz dXJlIGlmIHRoaXMgZml4IGlzIGNvcnJlY3QgZm9yIGFsbCBjYXNlcyBhcyBJJ20gb25seSBhYmxl Cj4gPiA+ID4gdG8KPiA+ID4gPiB0ZXN0Cj4gPiA+ID4gbXkgaGFyZHdhcmUgaGVyZSwgYW5kIHRo aXMgZG9lcyBmaXggbXkgbGFwdG9wLgo+ID4gPiAKPiA+ID4gQXJlIHlvdSBzdXJlIHRoZSBjb21t aXQgZGRjOWU2OWI5ZGMyICgiQVNvQzogcnQ1Njc3OiBIaWRlIHBsYXRmb3JtCj4gPiA+IGRhdGEK PiA+ID4gaW4gdGhlIG1vZHVsZSBzb3VyY2VzIikgZG9lcyBub3QgZml4IHlvdXIgaXNzdWU/Cj4g PiAKPiA+IEFzIHRoYXQncyBub3QgaW4gbWFzdGVyIHlldCBJIGNhbid0IHRlbGwuwqDCoENhbiB5 b3UgZ2l2ZSBtZSBhIHBvaW50ZXIKPiA+IHRvCj4gPiBzb21ld2hlcmU/CgpJdCdzIGluIEFTb0Mg bmV4dCBhdCBsZWFzdC4KCj4gPiDCoMKgVGhhbmtzIQo+IAo+IE9LLCBteSBiYWQsIGl0IGhhcyBh IGRpZmZlcmVudCBoYXNoIHVwc3RyZWFtLCBidXQgbm8sIHRoYXQgY2hhbmdlCj4gZG9lc24ndCBm aXggdGhpbmdzIGFzIEkgc2VlIHRoZSBwcm9ibGVtIG9uIHRvcCBvZiBMaW51cycKPiB0cmVlLsKg wqBUaGFua3MhCgpJbnRlcmVzdGluZy4uLgoKVGhlIG9ubHkgYnVnIHNvIGZhciBJIHNhdyBpcyB0 aGUgZm9sbG93aW5nIG9uZQoKaHR0cHM6Ly9idWd6aWxsYS5rZXJuZWwub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTYzOTcKCi4uLmFuZCBhYm92ZSBjb21taXQgZml4ZXMgaXQuCgpDYW4geW91IHBsYWNl IHNvbWV3aGVyZSB0aGUgYnVuZGxlIG9mIHRoZSBmb2xsb3dpbmc6CgoxLiBPdXRwdXQgZmlsZSAo dGFibGVzLmRhdCkgb2YKCSUgYWNwaWR1bXAgLW8gdGFibGVzLmRhdAoyLiBPdXRwdXQgb2YKCSUg Y2F0IC9wcm9jL2ludGVycnVwdHMKMy4gT3V0cHV0IG9mCgklIGxzcGNpIC12diAteHgKNC4gT3V0 cHV0IG9mCgklIGdyZXAgLUggMTUgL3N5cy9idXMvYWNwaS9kZXZpY2VzLyovc3RhdHVzCgo/Cgot LSAKQW5keSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5jb20+Cklu dGVsIEZpbmxhbmQgT3kKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KQWxzYS1kZXZlbCBtYWlsaW5nIGxpc3QKQWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3Jn Cmh0dHA6Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751276AbdHXHmC (ORCPT ); Thu, 24 Aug 2017 03:42:02 -0400 Received: from mga04.intel.com ([192.55.52.120]:22614 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124AbdHXHmB (ORCPT ); Thu, 24 Aug 2017 03:42:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,420,1498546800"; d="scan'208";a="893618665" Message-ID: <1503560349.25945.72.camel@linux.intel.com> Subject: Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs From: Andy Shevchenko To: Tom Rini Cc: linux-kernel@vger.kernel.org, Bard Liao , Oder Chiou , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Mark Brown , Linus Torvalds Date: Thu, 24 Aug 2017 10:39:09 +0300 In-Reply-To: <20170824000525.GY17193@bill-the-cat> References: <1503453106-5564-1-git-send-email-trini@konsulko.com> <1503498573.25945.69.camel@linux.intel.com> <20170823173912.GN17193@bill-the-cat> <20170824000525.GY17193@bill-the-cat> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-08-23 at 20:05 -0400, Tom Rini wrote: > On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote: > > On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote: > > > > > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote: > > > > Not all devices with ACPI and this combination of sound devices > > > > will > > > > have the required information provided via ACPI.  Reintroduce > > > > the I2C > > > > device ID to restore sound functionality on on the Chromebook > > > > 'Samus' > > > > model. > > > > This is a regression from v4.12 on my laptop (a Chromebook > > > > 'Samus' > > > > that's not running ChromeOS).  My fault for getting out of the > > > > habit > > > > of > > > > trying -rc1 when it comes out and not spotting this sooner.  I'm > > > > not > > > > 100% sure if this fix is correct for all cases as I'm only able > > > > to > > > > test > > > > my hardware here, and this does fix my laptop. > > > > > > Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform > > > data > > > in the module sources") does not fix your issue? > > > > As that's not in master yet I can't tell.  Can you give me a pointer > > to > > somewhere? It's in ASoC next at least. > >   Thanks! > > OK, my bad, it has a different hash upstream, but no, that change > doesn't fix things as I see the problem on top of Linus' > tree.  Thanks! Interesting... The only bug so far I saw is the following one https://bugzilla.kernel.org/show_bug.cgi?id=196397 ...and above commit fixes it. Can you place somewhere the bundle of the following: 1. Output file (tables.dat) of % acpidump -o tables.dat 2. Output of % cat /proc/interrupts 3. Output of % lspci -vv -xx 4. Output of % grep -H 15 /sys/bus/acpi/devices/*/status ? -- Andy Shevchenko Intel Finland Oy