From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH 01/23] mm/shmem: introduce shmem_file_setup_with_mnt Date: Tue, 29 Aug 2017 17:09:53 +0300 Message-ID: <1504015793.5001.58.camel@linux.intel.com> References: <20170821183503.12246-1-matthew.auld@intel.com> <20170821183503.12246-2-matthew.auld@intel.com> <1503480688.6276.4.camel@linux.intel.com> <20170823153456.b3c50e1ec109fd69f672b348@linux-foundation.org> <20170825134914.50a2433a5f28ba6ac0ec708d@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id D66EA6E3C8 for ; Tue, 29 Aug 2017 14:10:11 +0000 (UTC) In-Reply-To: <20170825134914.50a2433a5f28ba6ac0ec708d@linux-foundation.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Andrew Morton , Matthew Auld , Chris Wilson Cc: Dave Hansen , Intel Graphics Development , Hugh Dickins , linux-mm@kvack.org, Matthew Auld , "Kirill A . Shutemov" List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMDE3LTA4LTI1IGF0IDEzOjQ5IC0wNzAwLCBBbmRyZXcgTW9ydG9uIHdyb3RlOgo+ IE9uIFRodSwgMjQgQXVnIDIwMTcgMTM6MDQ6MDkgKzAxMDAgTWF0dGhldyBBdWxkIDxtYXR0aGV3 LndpbGxpYW0uYXVsZEBnbWFpbC5jb20+IHdyb3RlOgo+IAo+ID4gT24gMjMgQXVndXN0IDIwMTcg YXQgMjM6MzQsIEFuZHJldyBNb3J0b24gPGFrcG1AbGludXgtZm91bmRhdGlvbi5vcmc+IHdyb3Rl Ogo+ID4gPiBPbiBXZWQsIDIzIEF1ZyAyMDE3IDEyOjMxOjI4ICswMzAwIEpvb25hcyBMYWh0aW5l biA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPiA+IAo+ID4gPiA+ IFRoaXMgcGF0Y2ggaGFzIGJlZW4gZmxvYXRpbmcgYXJvdW5kIGZvciBhIHdoaWxlIG5vdyBBY2tl ZCBhbmQgd2l0aG91dAo+ID4gPiA+IGZ1cnRoZXIgY29tbWVudHMuIEl0IGlzIGJsb2NraW5nIHVz IGZyb20gbWVyZ2luZyBodWdlIHBhZ2Ugc3VwcG9ydCB0bwo+ID4gPiA+IGRybS9pOTE1Lgo+ID4g PiA+IAo+ID4gPiA+IFdvdWxkIHlvdSBtaW5kIG1lcmdpbmcgaXQsIG9yIHByb2RkaW5nIHRoZSBy aWdodCBwZW9wbGUgdG8gZ2V0IGl0IGluPwo+ID4gPiA+IAo+ID4gPiA+IFJlZ2FyZHMsIEpvb25h cwo+ID4gPiA+IAo+ID4gPiA+IE9uIE1vbiwgMjAxNy0wOC0yMSBhdCAxOTozNCArMDEwMCwgTWF0 dGhldyBBdWxkIHdyb3RlOgo+ID4gPiA+ID4gV2UgYXJlIHBsYW5uaW5nIHRvIHVzZSBvdXIgb3du IHRtcGZzIG1udCBpbiBpOTE1IGluIHBsYWNlIG9mIHRoZQo+ID4gPiA+ID4gc2htX21udCwgc3Vj aCB0aGF0IHdlIGNhbiBjb250cm9sIHRoZSBtb3VudCBvcHRpb25zLCBpbiBwYXJ0aWN1bGFyCj4g PiA+ID4gPiBodWdlPSwgd2hpY2ggd2UgcmVxdWlyZSB0byBzdXBwb3J0IGh1Z2UtZ3R0LXBhZ2Vz LiBTbyByYXRoZXIgdGhhbiByb2xsCj4gPiA+ID4gPiBvdXIgb3duIHZlcnNpb24gb2YgX19zaG1l bV9maWxlX3NldHVwLCBpdCB3b3VsZCBiZSBwcmVmZXJyZWQgaWYgd2UgY291bGQKPiA+ID4gPiA+ IGp1c3QgZ2l2ZSBzaG1lbSBvdXIgbW50LCBhbmQgbGV0IGl0IGRvIHRoZSByZXN0Lgo+ID4gPiAK PiA+ID4gaG0sIGl0J3MgYSBiaXQgb2RkLiAgSSdtIGhhdmluZyB0cm91YmxlIGxvY2F0aW5nIHRo ZSBjb2RlIHdoaWNoIGhhbmRsZXMKPiA+ID4gaHVnZT13aXRoaW5fc2l6ZSAoYW5kIGFueSBvdGhl ciBvcHRpb25zPykuCj4gPiAKPiA+IFNlZSBoZXJlIGh0dHBzOi8vcGF0Y2h3b3JrLmZyZWVkZXNr dG9wLm9yZy9wYXRjaC8xNzI3NzEvLCBjdXJyZW50bHkgd2UKPiA+IG9ubHkgY2FyZSBhYm91dCBo dWdlPXdpdGhpbl9zaXplLgo+ID4gCj4gPiA+IFdoYXQgb3RoZXIgYXBwcm9hY2hlcyB3ZXJlIGNv bnNpZGVyZWQ/Cj4gPiAKPiA+IFdlIGFsc28gdHJpZWQgaHR0cHM6Ly9wYXRjaHdvcmsuZnJlZWRl c2t0b3Aub3JnL3BhdGNoLzE1NjUyOC8sIHdoZXJlCj4gPiBpdCB3YXMgc3VnZ2VzdGVkIHRoYXQg d2UgbW91bnQgb3VyIG93biB0bXBmcyBpbnN0YW5jZS4KPiA+IAo+ID4gRm9sbG93aW5nIGZyb20g dGhhdCB3ZSBub3cgaGF2ZSBvdXIgb3duIHRtcHMgbW50IG1vdW50ZWQgd2l0aAo+ID4gaHVnZT13 aXRoaW5fc2l6ZS4gV2l0aCB0aGlzIHBhdGNoIHdlIGF2b2lkIGhhdmluZyB0byByb2xsIG91ciBv d24KPiA+IF9fc2htZW1fZmlsZV9zZXR1cCBsaWtlIGluCj4gPiBodHRwczovL3BhdGNod29yay5m cmVlZGVza3RvcC5vcmcvcGF0Y2gvMTYzMDI0Ly4KPiA+IAo+ID4gPiBXYXMgaXQgbm90IGZlYXNp YmxlIHRvIGFkZCBpOTE1LXNwZWNpZmljIG1vdW50IG9wdGlvbnMgdG8KPiA+ID4gbW0vc2htZW0u YyAoZm9yIGV4YW1wbGU/KS4KPiA+IAo+ID4gSG1tLCBJIHRoaW5rIHdpdGhpbl9zaXplIHNob3Vs ZCBzdWZmaWNlIGZvciBvdXIgbmVlZHMuCj4gCj4gaG0sIG9rLCB3ZWxsLCB1bmxlc3Mgc29tZW9u ZSBjYW4gdGhpbmsgb2Ygc29tZXRoaW5nIGNsZWFuZXIsIHBsZWFzZSBhZGQKPiBteSBhY2sgYW5k IGluY2x1ZGUgaXQgaW4gdGhlIGFwcHJvcHJpYXRlIGRybSB0cmVlLgoKVGhhbmtzLCBJIHdpbGwg ZG8gdGhhdC4gSXQnbGwgZmlyc3QgZ2V0IGluY29ycG9yYXRlZCBpbnRvIGRybS10aXAgKApodHRw czovL2NnaXQuZnJlZWRlc2t0b3Aub3JnL2RybS10aXApIG9uY2UgdGhlIGtzZWxmdGVzdHMgYXJl IGZpbmFsaXplZAoobm93IHRoYXQgd2Uga25vdyB3ZSdyZSBub3QgZmFjaW5nIHRoaXJkIHJld3Jp dGUgZm9yIGNvcmUgTU0KZGVwZW5kZW5jeSkuIEFuZCBldmVudHVhbGx5IGludG8gZHJtLW5leHQg dGhyb3VnaCBhIHB1bGwgcmVxdWVzdCB0bwpEYXZlIEFpcmxpZS4KClJlZ2FyZHMsIEpvb25hcwot LSAKSm9vbmFzIExhaHRpbmVuCk9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCkludGVsIENv cnBvcmF0aW9uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f197.google.com (mail-pf0-f197.google.com [209.85.192.197]) by kanga.kvack.org (Postfix) with ESMTP id 8B5DD6B025F for ; Tue, 29 Aug 2017 10:14:37 -0400 (EDT) Received: by mail-pf0-f197.google.com with SMTP id a2so6278486pfj.2 for ; Tue, 29 Aug 2017 07:14:37 -0700 (PDT) Received: from mga03.intel.com (mga03.intel.com. [134.134.136.65]) by mx.google.com with ESMTPS id z28si2482034pgc.252.2017.08.29.07.14.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Aug 2017 07:14:36 -0700 (PDT) Message-ID: <1504015793.5001.58.camel@linux.intel.com> Subject: Re: [Intel-gfx] [PATCH 01/23] mm/shmem: introduce shmem_file_setup_with_mnt From: Joonas Lahtinen Date: Tue, 29 Aug 2017 17:09:53 +0300 In-Reply-To: <20170825134914.50a2433a5f28ba6ac0ec708d@linux-foundation.org> References: <20170821183503.12246-1-matthew.auld@intel.com> <20170821183503.12246-2-matthew.auld@intel.com> <1503480688.6276.4.camel@linux.intel.com> <20170823153456.b3c50e1ec109fd69f672b348@linux-foundation.org> <20170825134914.50a2433a5f28ba6ac0ec708d@linux-foundation.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton , Matthew Auld , Chris Wilson Cc: linux-mm@kvack.org, Intel Graphics Development , Hugh Dickins , Dave Hansen , Matthew Auld , "Kirill A . Shutemov" On Fri, 2017-08-25 at 13:49 -0700, Andrew Morton wrote: > On Thu, 24 Aug 2017 13:04:09 +0100 Matthew Auld wrote: > > > On 23 August 2017 at 23:34, Andrew Morton wrote: > > > On Wed, 23 Aug 2017 12:31:28 +0300 Joonas Lahtinen wrote: > > > > > > > This patch has been floating around for a while now Acked and without > > > > further comments. It is blocking us from merging huge page support to > > > > drm/i915. > > > > > > > > Would you mind merging it, or prodding the right people to get it in? > > > > > > > > Regards, Joonas > > > > > > > > On Mon, 2017-08-21 at 19:34 +0100, Matthew Auld wrote: > > > > > We are planning to use our own tmpfs mnt in i915 in place of the > > > > > shm_mnt, such that we can control the mount options, in particular > > > > > huge=, which we require to support huge-gtt-pages. So rather than roll > > > > > our own version of __shmem_file_setup, it would be preferred if we could > > > > > just give shmem our mnt, and let it do the rest. > > > > > > hm, it's a bit odd. I'm having trouble locating the code which handles > > > huge=within_size (and any other options?). > > > > See here https://patchwork.freedesktop.org/patch/172771/, currently we > > only care about huge=within_size. > > > > > What other approaches were considered? > > > > We also tried https://patchwork.freedesktop.org/patch/156528/, where > > it was suggested that we mount our own tmpfs instance. > > > > Following from that we now have our own tmps mnt mounted with > > huge=within_size. With this patch we avoid having to roll our own > > __shmem_file_setup like in > > https://patchwork.freedesktop.org/patch/163024/. > > > > > Was it not feasible to add i915-specific mount options to > > > mm/shmem.c (for example?). > > > > Hmm, I think within_size should suffice for our needs. > > hm, ok, well, unless someone can think of something cleaner, please add > my ack and include it in the appropriate drm tree. Thanks, I will do that. It'll first get incorporated into drm-tip ( https://cgit.freedesktop.org/drm-tip) once the kselftests are finalized (now that we know we're not facing third rewrite for core MM dependency). And eventually into drm-next through a pull request to Dave Airlie. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org