All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "hch@infradead.org" <hch@infradead.org>,
	"viswas.g@microsemi.com" <viswas.g@microsemi.com>,
	"gerry.morong@microsemi.com" <gerry.morong@microsemi.com>,
	"mahesh.rajashekhara@microsemi.com"
	<mahesh.rajashekhara@microsemi.com>,
	"POSWALD@suse.com" <POSWALD@suse.com>,
	"scott.benesh@microsemi.com" <scott.benesh@microsemi.com>,
	"don.brace@microsemi.com" <don.brace@microsemi.com>,
	"bader.alisaleh@microsemi.com" <bader.alisaleh@microsemi.com>,
	"kevin.barnett@microsemi.com" <kevin.barnett@microsemi.com>,
	"joseph.szczypek@hpe.com" <joseph.szczypek@hpe.com>,
	"scott.teel@microsemi.com" <scott.teel@microsemi.com>,
	"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
	"justin.lindley@microsemi.com" <justin.lindley@microsemi.com>,
	"John.Hall@microsemi.com" <John.Hall@microsemi.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] sd: preserve sysfs updates to max_sectors_kb
Date: Tue, 29 Aug 2017 22:25:33 +0000	[thread overview]
Message-ID: <1504045532.2653.68.camel@wdc.com> (raw)
In-Reply-To: <4993A297653ECB4581FA5C3C31323D195B8E9191@avsrvexchmbx1.microsemi.net>

On Tue, 2017-08-29 at 19:41 +0000, Don Brace wrote:
> BLKRRPART ends up in the sd driver function sd_revalidate_disk, which resets
>         q->limits.max_sectors = min(rw_max, queue_max_hw_sectors(q));
> back to the value from VPD page 0xb0.
> 
> When you cat out max_sectors_kb, it obtains it's valuse from q->limits.max_sectors
> 
> Adding a udev rule... Will there be a delay between the watch rule and the new rule?

Hello Don,

In your original e-mail you wrote that max_sectors_kb was tuned because
of performance reasons. So does it really matter that for a very short
time max_sectors_kb does not have the optimal value?

> One more point, what will I change the value back to? The watch rule 
> changed it and I do not have the original value.

To the value you want to set max_sectors_kb to.

Bart.

  reply	other threads:[~2017-08-29 22:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 21:00 [PATCH] sd: preserve sysfs updates to max_sectors_kb Don Brace
2017-08-18 21:05 ` Bart Van Assche
2017-08-18 21:29   ` Don Brace
2017-08-18 21:46     ` Bart Van Assche
2017-08-21 19:12       ` Don Brace
2017-08-21 19:53         ` Bart Van Assche
2017-08-21 20:14           ` Don Brace
2017-08-29 17:41             ` Don Brace
2017-08-29 17:42             ` Don Brace
2017-08-29 18:13               ` Bart Van Assche
2017-08-29 18:36                 ` Don Brace
2017-08-29 19:41                   ` Don Brace
2017-08-29 22:25                     ` Bart Van Assche [this message]
2017-08-29 22:32                       ` Don Brace
2017-08-29 23:00                         ` Bart Van Assche
2017-08-30  1:24                           ` Martin K. Petersen
2017-09-09 10:32                             ` Martin Wilck
2017-09-28  1:37                               ` Martin K. Petersen
2017-09-28  1:38 ` [PATCH] scsi: sd: Do not override max_sectors_kb sysfs setting Martin K. Petersen
2017-09-29 12:26   ` Martin Wilck
2017-09-29 13:46   ` Don Brace

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504045532.2653.68.camel@wdc.com \
    --to=bart.vanassche@wdc.com \
    --cc=John.Hall@microsemi.com \
    --cc=POSWALD@suse.com \
    --cc=bader.alisaleh@microsemi.com \
    --cc=don.brace@microsemi.com \
    --cc=gerry.morong@microsemi.com \
    --cc=hch@infradead.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=joseph.szczypek@hpe.com \
    --cc=justin.lindley@microsemi.com \
    --cc=kevin.barnett@microsemi.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mahesh.rajashekhara@microsemi.com \
    --cc=scott.benesh@microsemi.com \
    --cc=scott.teel@microsemi.com \
    --cc=viswas.g@microsemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.