From: Alexandru Stefan ISAILA <aisaila@bitdefender.com>
To: "wei.liu2@citrix.com" <wei.liu2@citrix.com>
Cc: "tim@xen.org" <tim@xen.org>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"rcojocaru@bitdefender.com" <rcojocaru@bitdefender.com>,
"George.Dunlap@eu.citrix.com" <George.Dunlap@eu.citrix.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"ian.jackson@eu.citrix.com" <ian.jackson@eu.citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
"julien.grall@arm.com" <julien.grall@arm.com>,
"tamas@tklengyel.com" <tamas@tklengyel.com>,
"jbeulich@suse.com" <jbeulich@suse.com>
Subject: Re: [PATCH v5] common/vm_event: Initialize vm_event lists on domain creation
Date: Wed, 30 Aug 2017 08:29:24 +0000 [thread overview]
Message-ID: <1504081763.3450.6.camel@bitdefender.com> (raw)
In-Reply-To: <20170829155958.dk7tzcssmkqknbfl@citrix.com>
> >
> > -static int vm_event_disable(struct domain *d, struct
> > vm_event_domain *ved)
> > +static int vm_event_disable(struct domain *d, struct
> > vm_event_domain **ved)
> > {
> A lot of the code churn here and above could be avoided by changing
> ved
> in parameter list to something else (vedp?) and having a local
> variable
> called
>
> struct vm_event_domain *ved = *vedp;
>
> (I don't feel very strongly about this though)
>
I don't think it is necessary but the decision comes to the
maintainers.
Regards,
Alex
________________________
This email was scanned by Bitdefender
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2017-08-30 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 14:17 [PATCH v5] common/vm_event: Initialize vm_event lists on domain creation Alexandru Isaila
2017-08-29 15:14 ` Tamas K Lengyel
2017-08-29 15:48 ` Alexandru Stefan ISAILA
2017-08-29 15:59 ` Wei Liu
2017-08-29 17:38 ` Tamas K Lengyel
2017-08-29 17:41 ` Wei Liu
2017-08-30 7:06 ` Razvan Cojocaru
2017-08-30 8:29 ` Alexandru Stefan ISAILA [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504081763.3450.6.camel@bitdefender.com \
--to=aisaila@bitdefender.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=rcojocaru@bitdefender.com \
--cc=sstabellini@kernel.org \
--cc=tamas@tklengyel.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.