From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 39D1921E70D3B for ; Wed, 30 Aug 2017 14:37:52 -0700 (PDT) From: "Williams, Dan J" Subject: [GIT PULL] libnvdimm fix for 4.13-final Date: Wed, 30 Aug 2017 21:37:54 +0000 Message-ID: <1504129067.3089.3.camel@intel.com> Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "torvalds@linux-foundation.org" Cc: "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" List-ID: Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm libnvdimm-fixes ...to receive a single patch removing some structure definitions from a uapi header file. These payloads are never processed directly by the kernel they are simply passed through an ioctl as opaque blobs to the ACPI _DSM (Device Specific Method) interface. Userspace should not be depending on the kernel to define these payloads. We will instead provide these definitions via the existing libndctl (https://github.com/pmem/ndctl) project that has NVDIMM command helpers and other definitions. --- The following changes since commit cc4a41fe5541a73019a864883297bd5043aa6d98: Linux 4.13-rc7 (2017-08-27 17:20:40 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm libnvdimm-fixes for you to fetch changes up to 7a14724f54bf9889fcb1a9f1d4aa4e1d2e969d93: libnvdimm: clean up command definitions (2017-08-28 08:33:20 -0700) ---------------------------------------------------------------- Dan Williams (1): libnvdimm: clean up command definitions include/uapi/linux/ndctl.h | 37 ------------------------------------- 1 file changed, 37 deletions(-) commit 7a14724f54bf9889fcb1a9f1d4aa4e1d2e969d93 Author: Dan Williams Date: Mon Aug 28 08:33:20 2017 -0700 libnvdimm: clean up command definitions Remove the command payloads that do not have an associated libnvdimm ioctl. I.e. remove the payloads that would only ever be carried in the ND_CMD_CALL envelope. This prevents userspace from growing unnecessary dependencies on this kernel header when userspace already has everything it needs to craft and send these commands. Cc: Jerry Hoemann Reported-by: Yasunori Goto Signed-off-by: Dan Williams diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h index 6d3c54264d8e..3f03567631cb 100644 --- a/include/uapi/linux/ndctl.h +++ b/include/uapi/linux/ndctl.h @@ -145,43 +145,6 @@ struct nd_cmd_clear_error { __u64 cleared; } __packed; -struct nd_cmd_trans_spa { - __u64 spa; - __u32 status; - __u8 flags; - __u8 _reserved[3]; - __u64 trans_length; - __u32 num_nvdimms; - struct nd_nvdimm_device { - __u32 nfit_device_handle; - __u32 _reserved; - __u64 dpa; - } __packed devices[0]; - -} __packed; - -struct nd_cmd_ars_err_inj { - __u64 err_inj_spa_range_base; - __u64 err_inj_spa_range_length; - __u8 err_inj_options; - __u32 status; -} __packed; - -struct nd_cmd_ars_err_inj_clr { - __u64 err_inj_clr_spa_range_base; - __u64 err_inj_clr_spa_range_length; - __u32 status; -} __packed; - -struct nd_cmd_ars_err_inj_stat { - __u32 status; - __u32 inj_err_rec_count; - struct nd_error_stat_query_record { - __u64 err_inj_stat_spa_range_base; - __u64 err_inj_stat_spa_range_length; - } __packed record[0]; -} __packed; - enum { ND_CMD_IMPLEMENTED = 0, _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751409AbdH3Vh5 convert rfc822-to-8bit (ORCPT ); Wed, 30 Aug 2017 17:37:57 -0400 Received: from mga09.intel.com ([134.134.136.24]:28419 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751330AbdH3Vh4 (ORCPT ); Wed, 30 Aug 2017 17:37:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,450,1498546800"; d="scan'208";a="1167727129" From: "Williams, Dan J" To: "torvalds@linux-foundation.org" CC: "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" Subject: [GIT PULL] libnvdimm fix for 4.13-final Thread-Topic: [GIT PULL] libnvdimm fix for 4.13-final Thread-Index: AQHTIdg92760xv+xGEyILWK5KHzVTQ== Date: Wed, 30 Aug 2017 21:37:54 +0000 Message-ID: <1504129067.3089.3.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.24.10.164] Content-Type: text/plain; charset="utf-7" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm libnvdimm-fixes ...to receive a single patch removing some structure definitions from a uapi header file. These payloads are never processed directly by the kernel they are simply passed through an ioctl as opaque blobs to the ACPI +AF8-DSM (Device Specific Method) interface. Userspace should not be depending on the kernel to define these payloads. We will instead provide these definitions via the existing libndctl (https://github.com/pmem/ndctl) project that has NVDIMM command helpers and other definitions. --- The following changes since commit cc4a41fe5541a73019a864883297bd5043aa6d98: Linux 4.13-rc7 (2017-08-27 17:20:40 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm libnvdimm-fixes for you to fetch changes up to 7a14724f54bf9889fcb1a9f1d4aa4e1d2e969d93: libnvdimm: clean up command definitions (2017-08-28 08:33:20 -0700) ---------------------------------------------------------------- Dan Williams (1): libnvdimm: clean up command definitions include/uapi/linux/ndctl.h +AHw- 37 ------------------------------------- 1 file changed, 37 deletions(-) commit 7a14724f54bf9889fcb1a9f1d4aa4e1d2e969d93 Author: Dan Williams +ADw-dan.j.williams+AEA-intel.com+AD4- Date: Mon Aug 28 08:33:20 2017 -0700 libnvdimm: clean up command definitions Remove the command payloads that do not have an associated libnvdimm ioctl. I.e. remove the payloads that would only ever be carried in the ND+AF8-CMD+AF8-CALL envelope. This prevents userspace from growing unnecessary dependencies on this kernel header when userspace already has everything it needs to craft and send these commands. Cc: Jerry Hoemann +ADw-jerry.hoemann+AEA-hpe.com+AD4- Reported-by: Yasunori Goto +ADw-y-goto+AEA-jp.fujitsu.com+AD4- Signed-off-by: Dan Williams +ADw-dan.j.williams+AEA-intel.com+AD4- diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h index 6d3c54264d8e..3f03567631cb 100644 --- a/include/uapi/linux/ndctl.h +-+-+- b/include/uapi/linux/ndctl.h +AEAAQA- -145,43 +-145,6 +AEAAQA- struct nd+AF8-cmd+AF8-clear+AF8-error +AHs- +AF8AXw-u64 cleared+ADs- +AH0- +AF8AXw-packed+ADs- -struct nd+AF8-cmd+AF8-trans+AF8-spa +AHs- - +AF8AXw-u64 spa+ADs- - +AF8AXw-u32 status+ADs- - +AF8AXw-u8 flags+ADs- - +AF8AXw-u8 +AF8-reserved+AFs-3+AF0AOw- - +AF8AXw-u64 trans+AF8-length+ADs- - +AF8AXw-u32 num+AF8-nvdimms+ADs- - struct nd+AF8-nvdimm+AF8-device +AHs- - +AF8AXw-u32 nfit+AF8-device+AF8-handle+ADs- - +AF8AXw-u32 +AF8-reserved+ADs- - +AF8AXw-u64 dpa+ADs- - +AH0- +AF8AXw-packed devices+AFs-0+AF0AOw- - -+AH0- +AF8AXw-packed+ADs- - -struct nd+AF8-cmd+AF8-ars+AF8-err+AF8-inj +AHs- - +AF8AXw-u64 err+AF8-inj+AF8-spa+AF8-range+AF8-base+ADs- - +AF8AXw-u64 err+AF8-inj+AF8-spa+AF8-range+AF8-length+ADs- - +AF8AXw-u8 err+AF8-inj+AF8-options+ADs- - +AF8AXw-u32 status+ADs- -+AH0- +AF8AXw-packed+ADs- - -struct nd+AF8-cmd+AF8-ars+AF8-err+AF8-inj+AF8-clr +AHs- - +AF8AXw-u64 err+AF8-inj+AF8-clr+AF8-spa+AF8-range+AF8-base+ADs- - +AF8AXw-u64 err+AF8-inj+AF8-clr+AF8-spa+AF8-range+AF8-length+ADs- - +AF8AXw-u32 status+ADs- -+AH0- +AF8AXw-packed+ADs- - -struct nd+AF8-cmd+AF8-ars+AF8-err+AF8-inj+AF8-stat +AHs- - +AF8AXw-u32 status+ADs- - +AF8AXw-u32 inj+AF8-err+AF8-rec+AF8-count+ADs- - struct nd+AF8-error+AF8-stat+AF8-query+AF8-record +AHs- - +AF8AXw-u64 err+AF8-inj+AF8-stat+AF8-spa+AF8-range+AF8-base+ADs- - +AF8AXw-u64 err+AF8-inj+AF8-stat+AF8-spa+AF8-range+AF8-length+ADs- - +AH0- +AF8AXw-packed record+AFs-0+AF0AOw- -+AH0- +AF8AXw-packed+ADs- - enum +AHs- ND+AF8-CMD+AF8-IMPLEMENTED +AD0- 0,